[PR #396] [MERGED] Make Signal Service listen on a standard 443/80 port instead of 10000 #12574

Closed
opened 2026-08-05 02:06:12 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/396
Author: @braginini
Created: 7/23/2022
Status: Merged
Merged: 7/25/2022
Merged by: @braginini

Base: mainHead: single-port-signal


📝 Commits (4)

  • d62d37a Initial work for a single port Signal service
  • 94c2023 Migrate Signal to port 80 or 443
  • a53ac8f Migrate Signal to port 80 or 443
  • 61e7276 Update Signal port in docker compose

📊 Changes

7 files changed (+146 additions, -33 deletions)

View changed files

📝 encryption/letsencrypt.go (+4 -4)
📝 go.mod (+2 -1)
📝 go.sum (+3 -0)
📝 infrastructure_files/docker-compose.yml.tmpl (+1 -1)
📝 management/cmd/management.go (+15 -1)
📝 signal/client/grpc.go (+2 -0)
📝 signal/cmd/run.go (+119 -26)

📄 Description

This PR is a part of an effort to use standard ports (443 or 80) that are usually allowed by default in most of the environments.

Right now Signal Service runs the Let'sEncrypt manager on port 443
and a gRPC server on port 10000. There are two separate listeners.
This PR combines these listeners into one
With this change, the gRPC server runs on either 443 with TLS or 80 without TLS
by default (no --port specified).
Let's Encrypt manager always runs on port 443 if enabled.
The backward compatibility server runs on port 10000 (with TLS or without).

Agents that are running and on status Online will still be connected to 10000.
Triggering Agent restart of any version will force it to connect to port 443.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/396 **Author:** [@braginini](https://github.com/braginini) **Created:** 7/23/2022 **Status:** ✅ Merged **Merged:** 7/25/2022 **Merged by:** [@braginini](https://github.com/braginini) **Base:** `main` ← **Head:** `single-port-signal` --- ### 📝 Commits (4) - [`d62d37a`](https://github.com/netbirdio/netbird/commit/d62d37af00c2bdd61fd32967015297692c55e2d8) Initial work for a single port Signal service - [`94c2023`](https://github.com/netbirdio/netbird/commit/94c2023e6b5314acd82ce92d44f0cdecf7e10805) Migrate Signal to port 80 or 443 - [`a53ac8f`](https://github.com/netbirdio/netbird/commit/a53ac8f06136140451e5e5cd06f6f881fe064ff5) Migrate Signal to port 80 or 443 - [`61e7276`](https://github.com/netbirdio/netbird/commit/61e7276dd3b765931c81181fb9f5bb21ae2c55d6) Update Signal port in docker compose ### 📊 Changes **7 files changed** (+146 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `encryption/letsencrypt.go` (+4 -4) 📝 `go.mod` (+2 -1) 📝 `go.sum` (+3 -0) 📝 `infrastructure_files/docker-compose.yml.tmpl` (+1 -1) 📝 `management/cmd/management.go` (+15 -1) 📝 `signal/client/grpc.go` (+2 -0) 📝 `signal/cmd/run.go` (+119 -26) </details> ### 📄 Description This PR is a part of an effort to use standard ports (443 or 80) that are usually allowed by default in most of the environments. Right now Signal Service runs the Let'sEncrypt manager on port 443 and a gRPC server on port 10000. There are two separate listeners. This PR combines these listeners into one With this change, the gRPC server runs on either 443 with TLS or 80 without TLS by default (no --port specified). Let's Encrypt manager always runs on port 443 if enabled. The backward compatibility server runs on port 10000 (with TLS or without). Agents that are running and on status Online will still be connected to 10000. Triggering Agent restart of any version will force it to connect to port 443. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 02:06:12 -04:00
saavagebueno changed title from [PR #396] [MERGED] Make Signal Service listen on a standard 443/80 port instead of 10000 to [PR #396] Make Signal Service listen on a standard 443/80 port instead of 10000 2026-08-05 02:08:35 -04:00
saavagebueno changed title from [PR #396] Make Signal Service listen on a standard 443/80 port instead of 10000 to [PR #396] [MERGED] Make Signal Service listen on a standard 443/80 port instead of 10000 2026-08-05 03:06:27 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#12574