[PR #1738] [MERGED] Add limited dashboard view #14227

Closed
opened 2026-08-05 02:09:38 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/1738
Author: @pascal-fischer
Created: 3/21/2024
Status: Merged
Merged: 3/27/2024
Merged by: @braginini

Base: mainHead: feature/limited-dashboard-view


📝 Commits (10+)

  • 7d3301a add limited dashboard view settings
  • dcefb0c make peerViewBlocked required
  • 84c958d rename settings field
  • 56783c7 rename settings field in api
  • 8cd8167 remove leftover debug message
  • 6cbb638 move get groups into acocunt manager and fix IdP user response
  • 0dc97d1 using correct user
  • 31a7d6f add tests
  • 735daeb fix api response for get all groups
  • 15e7776 update group handler test

📊 Changes

17 files changed (+466 additions, -41 deletions)

View changed files

📝 management/server/account.go (+12 -1)
📝 management/server/group.go (+37 -1)
📝 management/server/http/accounts_handler.go (+2 -0)
📝 management/server/http/accounts_handler_test.go (+7 -2)
📝 management/server/http/api/openapi.yml (+15 -2)
📝 management/server/http/api/types.gen.go (+45 -5)
📝 management/server/http/groups_handler.go (+14 -8)
📝 management/server/http/groups_handler_test.go (+4 -4)
📝 management/server/http/users_handler.go (+3 -0)
📝 management/server/http/users_handler_test.go (+1 -1)
📝 management/server/mock_server/account_mock.go (+18 -9)
📝 management/server/peer.go (+9 -0)
📝 management/server/peer_test.go (+153 -2)
📝 management/server/setupkey.go (+8 -0)
📝 management/server/setupkey_test.go (+31 -0)
📝 management/server/user.go (+30 -6)
📝 management/server/user_test.go (+77 -0)

📄 Description

Describe your changes

This PR adds a new settings field regular_users_view_blocked. Is this field is set to true it will the peer responses for regular users (admins and owners still have full response). Additionally it will extend the api response when querying for users with a permissions object that includes the dashboard_view. This will help the dashboard on what to show for each user until we have a full permissions functionality throughout the project.

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/1738 **Author:** [@pascal-fischer](https://github.com/pascal-fischer) **Created:** 3/21/2024 **Status:** ✅ Merged **Merged:** 3/27/2024 **Merged by:** [@braginini](https://github.com/braginini) **Base:** `main` ← **Head:** `feature/limited-dashboard-view` --- ### 📝 Commits (10+) - [`7d3301a`](https://github.com/netbirdio/netbird/commit/7d3301a46d20353c33b46429b2c89e56dec5bbab) add limited dashboard view settings - [`dcefb0c`](https://github.com/netbirdio/netbird/commit/dcefb0c62eeb5525c5fc5d96d651a8c5538acb86) make peerViewBlocked required - [`84c958d`](https://github.com/netbirdio/netbird/commit/84c958d0f9caf1a6df6ffc0ba54e2fae1c9a32bb) rename settings field - [`56783c7`](https://github.com/netbirdio/netbird/commit/56783c71e9f59989edc6d35522fa90e1f1927204) rename settings field in api - [`8cd8167`](https://github.com/netbirdio/netbird/commit/8cd8167c76bb7387ff89126f45d2803bb4d27283) remove leftover debug message - [`6cbb638`](https://github.com/netbirdio/netbird/commit/6cbb6380ef6e8368e20111d0d9a76e24c1767fea) move get groups into acocunt manager and fix IdP user response - [`0dc97d1`](https://github.com/netbirdio/netbird/commit/0dc97d1e872b5884bb9a5b03c939839c655ed713) using correct user - [`31a7d6f`](https://github.com/netbirdio/netbird/commit/31a7d6f71d01ae438ce8bccb0cba6b28dd3186a5) add tests - [`735daeb`](https://github.com/netbirdio/netbird/commit/735daeba124acee416e655fa4915a48362af3f23) fix api response for get all groups - [`15e7776`](https://github.com/netbirdio/netbird/commit/15e77763224da5aea65e3c57dc17cc7bc380998a) update group handler test ### 📊 Changes **17 files changed** (+466 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `management/server/account.go` (+12 -1) 📝 `management/server/group.go` (+37 -1) 📝 `management/server/http/accounts_handler.go` (+2 -0) 📝 `management/server/http/accounts_handler_test.go` (+7 -2) 📝 `management/server/http/api/openapi.yml` (+15 -2) 📝 `management/server/http/api/types.gen.go` (+45 -5) 📝 `management/server/http/groups_handler.go` (+14 -8) 📝 `management/server/http/groups_handler_test.go` (+4 -4) 📝 `management/server/http/users_handler.go` (+3 -0) 📝 `management/server/http/users_handler_test.go` (+1 -1) 📝 `management/server/mock_server/account_mock.go` (+18 -9) 📝 `management/server/peer.go` (+9 -0) 📝 `management/server/peer_test.go` (+153 -2) 📝 `management/server/setupkey.go` (+8 -0) 📝 `management/server/setupkey_test.go` (+31 -0) 📝 `management/server/user.go` (+30 -6) 📝 `management/server/user_test.go` (+77 -0) </details> ### 📄 Description ## Describe your changes This PR adds a new settings field `regular_users_view_blocked`. Is this field is set to true it will the peer responses for regular users (admins and owners still have full response). Additionally it will extend the api response when querying for users with a permissions object that includes the `dashboard_view`. This will help the dashboard on what to show for each user until we have a full permissions functionality throughout the project. ## Issue ticket number and link ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 02:09:38 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#14227