[PR #2678] [MERGED] Install sh alpine fixes #15458

Closed
opened 2026-08-05 03:07:42 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/2678
Author: @simen64
Created: 9/30/2024
Status: Merged
Merged: 10/1/2024
Merged by: @mlsmaycon

Base: mainHead: install-sh_alpine_fixes


📝 Commits (3)

  • a42e485 Made changes to the peer install script that makes it work on alpine linux without changes
  • 8b1cb08 fix small oversight with doas fix
  • 1bd4a8e use try catch approach when curling binaries

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 release_files/install.sh (+4 -2)

📄 Description

Describe your changes

  1. Made the script check for doas to work with alpine linux
  2. Specified a set DNS server in the curl statement that downloads the binaries. I had issues where the curl request wouldnt resolve the URL, my theory is that since one of the redirect URL's are very long the standard DNS wont resolve it. This is what i experienced on alpine linux, and setting the google dns in the curl request fixed the issue.
  3. Change "-C" to "-c" in the sort statement, the sort version in alpine linux doesnt have the "-C" function and it works just as well with "-c"

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/2678 **Author:** [@simen64](https://github.com/simen64) **Created:** 9/30/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@mlsmaycon](https://github.com/mlsmaycon) **Base:** `main` ← **Head:** `install-sh_alpine_fixes` --- ### 📝 Commits (3) - [`a42e485`](https://github.com/netbirdio/netbird/commit/a42e485dab0e845e8012f827008e70498a0f83bc) Made changes to the peer install script that makes it work on alpine linux without changes - [`8b1cb08`](https://github.com/netbirdio/netbird/commit/8b1cb080361afabc02249804e7c4ee6384699cd5) fix small oversight with doas fix - [`1bd4a8e`](https://github.com/netbirdio/netbird/commit/1bd4a8e4b85ff2b7f3a8c02ce0fc41a22776d66c) use try catch approach when curling binaries ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `release_files/install.sh` (+4 -2) </details> ### 📄 Description ## Describe your changes 1. Made the script check for doas to work with alpine linux 2. Specified a set DNS server in the curl statement that downloads the binaries. I had issues where the curl request wouldnt resolve the URL, my theory is that since one of the redirect URL's are very long the standard DNS wont resolve it. This is what i experienced on alpine linux, and setting the google dns in the curl request fixed the issue. 3. Change "-C" to "-c" in the sort statement, the sort version in alpine linux doesnt have the "-C" function and it works just as well with "-c" ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 03:07:42 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#15458