[PR #2804] [MERGED] Unspecified address: default NetworkTypeUDP4+NetworkTypeUDP6 #15634

Closed
opened 2026-08-05 03:08:05 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/2804
Author: @victorserbu2709
Created: 10/29/2024
Status: Merged
Merged: 11/30/2024
Merged by: @mlsmaycon

Base: mainHead: main


📝 Commits (1)

  • 9915d47 Unspecified address: default NetworkTypeUDP4+NetworkTypeUDP6

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 client/iface/bind/udp_mux.go (+3 -2)

📄 Description

Describe your changes

if address is unspecified and it is ipv6 then networks = []ice.NetworkType{ice.NetworkTypeUDP4, ice.NetworkTypeUDP6}

https://github.com/netbirdio/netbird/issues/46

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/2804 **Author:** [@victorserbu2709](https://github.com/victorserbu2709) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 11/30/2024 **Merged by:** [@mlsmaycon](https://github.com/mlsmaycon) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`9915d47`](https://github.com/netbirdio/netbird/commit/9915d47b52c199656cc04e1615386710bdd016e7) Unspecified address: default NetworkTypeUDP4+NetworkTypeUDP6 ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `client/iface/bind/udp_mux.go` (+3 -2) </details> ### 📄 Description ## Describe your changes if address is unspecified and it is ipv6 then networks = []ice.NetworkType{ice.NetworkTypeUDP4, ice.NetworkTypeUDP6} ## Issue ticket number and link https://github.com/netbirdio/netbird/issues/46 ### Checklist - [X] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 03:08:05 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#15634