[PR #3335] [MERGED] [client][ui] added accessible tray icons #17114

Open
opened 2026-08-05 04:06:56 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/3335
Author: @karsa-mistmere
Created: 2/17/2025
Status: Merged
Merged: 2/17/2025
Merged by: @mlsmaycon

Base: mainHead: 3312-tray-icon-a11y


📝 Commits (6)

  • 4616b7e feat(client/ui): added accessible tray icons w/ MacOS template icon support
  • 0234c24 feat(client/ui): refactor main to decrease complexity
  • 842b8d7 feat(client/ui): further simplify event listener BL
  • fe86cf0 feat(client/ui): add dedicated netbird png logo for goreleaser
  • a93cec8 feat(client/ui): remove about icon, use netbird.png and netbird.ico instead
  • a04ea3a feat(client/ui): increase update-connected mask to remove leftover pixels from top right

📊 Changes

33 files changed (+149 additions, -33 deletions)

View changed files

📝 .goreleaser_ui.yaml (+2 -2)
📝 client/ui/client_ui.go (+147 -31)
client/ui/netbird-systemtray-connected-dark.ico (+0 -0)
client/ui/netbird-systemtray-connected-dark.png (+0 -0)
client/ui/netbird-systemtray-connected-macos.png (+0 -0)
📝 client/ui/netbird-systemtray-connected.ico (+0 -0)
📝 client/ui/netbird-systemtray-connected.png (+0 -0)
client/ui/netbird-systemtray-connecting-dark.ico (+0 -0)
client/ui/netbird-systemtray-connecting-dark.png (+0 -0)
client/ui/netbird-systemtray-connecting-macos.png (+0 -0)
client/ui/netbird-systemtray-connecting.ico (+0 -0)
client/ui/netbird-systemtray-connecting.png (+0 -0)
client/ui/netbird-systemtray-disconnected-macos.png (+0 -0)
📝 client/ui/netbird-systemtray-disconnected.ico (+0 -0)
📝 client/ui/netbird-systemtray-disconnected.png (+0 -0)
client/ui/netbird-systemtray-error-dark.ico (+0 -0)
client/ui/netbird-systemtray-error-dark.png (+0 -0)
client/ui/netbird-systemtray-error-macos.png (+0 -0)
client/ui/netbird-systemtray-error.ico (+0 -0)
client/ui/netbird-systemtray-error.png (+0 -0)

...and 13 more files

📄 Description

closes #3312 #3322

Describe your changes

  • Added accessible tray icons with:
  • Also added appropriate connecting status icons:

https://github.com/user-attachments/assets/1088132f-9664-4fed-8b9e-c534c16bba43

#3312

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/3335 **Author:** [@karsa-mistmere](https://github.com/karsa-mistmere) **Created:** 2/17/2025 **Status:** ✅ Merged **Merged:** 2/17/2025 **Merged by:** [@mlsmaycon](https://github.com/mlsmaycon) **Base:** `main` ← **Head:** `3312-tray-icon-a11y` --- ### 📝 Commits (6) - [`4616b7e`](https://github.com/netbirdio/netbird/commit/4616b7e2451ac9cf239de3612268bb872df5744d) feat(client/ui): added accessible tray icons w/ MacOS template icon support - [`0234c24`](https://github.com/netbirdio/netbird/commit/0234c24ed7cf9f8840c57612accaa312949f4e08) feat(client/ui): refactor main to decrease complexity - [`842b8d7`](https://github.com/netbirdio/netbird/commit/842b8d78b398dc8347a51a1650bf01c3cde98bfb) feat(client/ui): further simplify event listener BL - [`fe86cf0`](https://github.com/netbirdio/netbird/commit/fe86cf04ea63b7be8bb532b89572720f330f03fb) feat(client/ui): add dedicated netbird png logo for goreleaser - [`a93cec8`](https://github.com/netbirdio/netbird/commit/a93cec8fff68119b6f44d0103e3d3cdc684f0937) feat(client/ui): remove about icon, use netbird.png and netbird.ico instead - [`a04ea3a`](https://github.com/netbirdio/netbird/commit/a04ea3a692440c6b4b9d887054a83ca1d8a9e373) feat(client/ui): increase update-connected mask to remove leftover pixels from top right ### 📊 Changes **33 files changed** (+149 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `.goreleaser_ui.yaml` (+2 -2) 📝 `client/ui/client_ui.go` (+147 -31) ➕ `client/ui/netbird-systemtray-connected-dark.ico` (+0 -0) ➕ `client/ui/netbird-systemtray-connected-dark.png` (+0 -0) ➕ `client/ui/netbird-systemtray-connected-macos.png` (+0 -0) 📝 `client/ui/netbird-systemtray-connected.ico` (+0 -0) 📝 `client/ui/netbird-systemtray-connected.png` (+0 -0) ➕ `client/ui/netbird-systemtray-connecting-dark.ico` (+0 -0) ➕ `client/ui/netbird-systemtray-connecting-dark.png` (+0 -0) ➕ `client/ui/netbird-systemtray-connecting-macos.png` (+0 -0) ➕ `client/ui/netbird-systemtray-connecting.ico` (+0 -0) ➕ `client/ui/netbird-systemtray-connecting.png` (+0 -0) ➕ `client/ui/netbird-systemtray-disconnected-macos.png` (+0 -0) 📝 `client/ui/netbird-systemtray-disconnected.ico` (+0 -0) 📝 `client/ui/netbird-systemtray-disconnected.png` (+0 -0) ➕ `client/ui/netbird-systemtray-error-dark.ico` (+0 -0) ➕ `client/ui/netbird-systemtray-error-dark.png` (+0 -0) ➕ `client/ui/netbird-systemtray-error-macos.png` (+0 -0) ➕ `client/ui/netbird-systemtray-error.ico` (+0 -0) ➕ `client/ui/netbird-systemtray-error.png` (+0 -0) _...and 13 more files_ </details> ### 📄 Description closes #3312 #3322 ## Describe your changes - Added accessible tray icons with: - dark mode support on Windows and Linux, kudos to @burgosz for the PoC - [template icon support](https://developer.apple.com/documentation/appkit/nsimage/istemplate) on MacOS - Also added appropriate connecting status icons: https://github.com/user-attachments/assets/1088132f-9664-4fed-8b9e-c534c16bba43 ## Issue ticket number and link #3312 ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 04:06:56 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#17114