[PR #1915] [MERGED] Ignore cloned routes on bsd #18274

Open
opened 2026-08-05 04:08:19 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/1915
Author: @lixmal
Created: 5/2/2024
Status: Merged
Merged: 5/2/2024
Merged by: @lixmal

Base: mainHead: fix/bsd-ignore-cloned


📝 Commits (1)

  • 4f39ea5 Ignore cloned routes on macos, these can be overriden

📊 Changes

1 file changed (+2 additions, -16 deletions)

View changed files

📝 client/internal/routemanager/systemops_bsd.go (+2 -16)

📄 Description

Describe your changes

Sometimes the bsd routing table contains routes with the flag W:

W RTF_WASCLONED Route was generated as a result of cloning

These routes only appear using the a flag:
netstat -nra

This prevents us from creating routes for netbird.
This change ignores routes of this type and creates the routes, overriding the cloned ones.

#1900

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/1915 **Author:** [@lixmal](https://github.com/lixmal) **Created:** 5/2/2024 **Status:** ✅ Merged **Merged:** 5/2/2024 **Merged by:** [@lixmal](https://github.com/lixmal) **Base:** `main` ← **Head:** `fix/bsd-ignore-cloned` --- ### 📝 Commits (1) - [`4f39ea5`](https://github.com/netbirdio/netbird/commit/4f39ea545a2ff6ba2e23e9b1de6923ff7bb293a0) Ignore cloned routes on macos, these can be overriden ### 📊 Changes **1 file changed** (+2 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `client/internal/routemanager/systemops_bsd.go` (+2 -16) </details> ### 📄 Description ## Describe your changes Sometimes the bsd routing table contains routes with the flag `W`: > W RTF_WASCLONED Route was generated as a result of cloning These routes only appear using the `a` flag: `netstat -nra` This prevents us from creating routes for netbird. This change ignores routes of this type and creates the routes, overriding the cloned ones. ## Issue ticket number and link #1900 ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] Extended the README / documentation, if necessary --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 04:08:19 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#18274