[PR #5281] Fix log line which shows empty tag name #22599

Open
opened 2026-08-05 06:06:09 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/5281
Author: @gene1wood
Created: 2/9/2026
Status: 🔄 Open

Base: mainHead: fix-install.sh-log-line


📝 Commits (1)

  • 1aa9f44 Fix log line which shows empty tag name

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 release_files/install.sh (+1 -1)

📄 Description

Describe your changes

This changes the log output line used when downloading a release binary so that instead of showing a blank TAG_NAME it shows the VERSION.

This change also changes the leading whitespace on this line from a tab to 4 spaces to match it's neighboring lines.

Fixes #5280

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

This PR fixes a very small log display issue and so doesn't need documentation.

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Bug Fixes
    • Improved installation process messaging to display resolved version information instead of tag name, providing clearer feedback during binary installation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/5281 **Author:** [@gene1wood](https://github.com/gene1wood) **Created:** 2/9/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-install.sh-log-line` --- ### 📝 Commits (1) - [`1aa9f44`](https://github.com/netbirdio/netbird/commit/1aa9f445621dd26ec9dc3a8f84be99b638c6f495) Fix log line which shows empty tag name ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `release_files/install.sh` (+1 -1) </details> ### 📄 Description ## Describe your changes This changes the log output line used when downloading a release binary so that instead of showing a blank TAG_NAME it shows the VERSION. This change also changes the leading whitespace on this line from a tab to 4 spaces to match it's neighboring lines. ## Issue ticket number and link Fixes #5280 ## Stack <!-- branch-stack --> ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) This PR fixes a very small log display issue and so doesn't need documentation. ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved installation process messaging to display resolved version information instead of tag name, providing clearer feedback during binary installation. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 06:06:09 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#22599