[PR #4640] [CLOSED] [management] Add IDP timeout env variable #25957

Open
opened 2026-08-05 07:06:41 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/4640
Author: @ressys1978
Created: 10/14/2025
Status: Closed

Base: mainHead: add-idp-timeout-env-variable


📝 Commits (3)

  • 4967e21 [management] Add IDP timeout environment variable
  • 521e9b9 [management] Add IDP timeout environment variable
  • 0cb27a3 [management] Add IDP timeout environment variable

📊 Changes

8 files changed (+168 additions, -11 deletions)

View changed files

📝 management/server/idp/auth0.go (+21 -1)
📝 management/server/idp/authentik.go (+22 -4)
📝 management/server/idp/azure.go (+21 -1)
📝 management/server/idp/google_workspace.go (+21 -1)
📝 management/server/idp/jumpcloud.go (+21 -1)
📝 management/server/idp/keycloak.go (+21 -1)
📝 management/server/idp/okta.go (+20 -1)
📝 management/server/idp/zitadel.go (+21 -1)

📄 Description

Describe your changes

Introduced the NETBIRD_IDP_TIMEOUT environment variable to the management service. This allows configuring a timeout for supported IDPs. If the variable is unset or contains an invalid value, a default timeout of 10 seconds is used as a fallback.

This is needed for larger IDP environments where 10s is just not enough time.

This should fix #1386

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

I don't feel this needs to be documented at this time, as currently the number of self-hosted netbird users with larger IDP environments is probably very small.

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/4640 **Author:** [@ressys1978](https://github.com/ressys1978) **Created:** 10/14/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-idp-timeout-env-variable` --- ### 📝 Commits (3) - [`4967e21`](https://github.com/netbirdio/netbird/commit/4967e21decd3f0a4740394f2208f69a26d452635) [management] Add IDP timeout environment variable - [`521e9b9`](https://github.com/netbirdio/netbird/commit/521e9b9e741105e195b276cb7c646550334f2243) [management] Add IDP timeout environment variable - [`0cb27a3`](https://github.com/netbirdio/netbird/commit/0cb27a3cdd3428326ffcc020046fdc1908de65d6) [management] Add IDP timeout environment variable ### 📊 Changes **8 files changed** (+168 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `management/server/idp/auth0.go` (+21 -1) 📝 `management/server/idp/authentik.go` (+22 -4) 📝 `management/server/idp/azure.go` (+21 -1) 📝 `management/server/idp/google_workspace.go` (+21 -1) 📝 `management/server/idp/jumpcloud.go` (+21 -1) 📝 `management/server/idp/keycloak.go` (+21 -1) 📝 `management/server/idp/okta.go` (+20 -1) 📝 `management/server/idp/zitadel.go` (+21 -1) </details> ### 📄 Description ## Describe your changes Introduced the NETBIRD_IDP_TIMEOUT environment variable to the management service. This allows configuring a timeout for supported IDPs. If the variable is unset or contains an invalid value, a default timeout of 10 seconds is used as a fallback. This is needed for larger IDP environments where 10s is just not enough time. ## Issue ticket number and link This should fix #1386 ## Stack <!-- branch-stack --> ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) I don't feel this needs to be documented at this time, as currently the number of self-hosted netbird users with larger IDP environments is probably very small. ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:06:41 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#25957