[PR #6686] [CLOSED] [client] Increase system info gathering timeout to 60s #26655

Open
opened 2026-08-05 07:07:39 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6686
Author: @lixmal
Created: 7/7/2026
Status: Closed

Base: 0.74.3-branchHead: increase-sysinfo-timeout


📝 Commits (1)

  • 4ff5ed7 Increase system info gathering timeout from 15s to 60s

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 client/internal/engine.go (+1 -1)

📄 Description

Describe your changes

Increase the system info / posture check gathering timeout from 15s to 60s. On slower machines gathering regularly exceeds 15s, so the meta sync is skipped and the management stream connects with base info only. The timeout still bounds the sync loop against genuinely stuck system calls, and shutdown is unaffected since gathering cancels immediately with the engine context.

  • Raise systemInfoTimeout in the engine from 15s to 60s

Stack

  • 0.74.3-branch - ⚠️ No PR associated with branch

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • This change does not modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — OR I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (internal timeout constant, no user-facing behavior change)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Bug Fixes
    • Increased the time allowed for collecting system information, reducing premature timeouts during startup.
    • Helps the app wait longer before falling back to limited information, improving reliability of management and posture-related checks.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6686 **Author:** [@lixmal](https://github.com/lixmal) **Created:** 7/7/2026 **Status:** ❌ Closed **Base:** `0.74.3-branch` ← **Head:** `increase-sysinfo-timeout` --- ### 📝 Commits (1) - [`4ff5ed7`](https://github.com/netbirdio/netbird/commit/4ff5ed756da87f0069f7eada2c89c1e53f84d1b4) Increase system info gathering timeout from 15s to 60s ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `client/internal/engine.go` (+1 -1) </details> ### 📄 Description ## Describe your changes Increase the system info / posture check gathering timeout from 15s to 60s. On slower machines gathering regularly exceeds 15s, so the meta sync is skipped and the management stream connects with base info only. The timeout still bounds the sync loop against genuinely stuck system calls, and shutdown is unaffected since gathering cancels immediately with the engine context. - Raise systemInfoTimeout in the engine from 15s to 60s ## Issue ticket number and link ## Stack - `0.74.3-branch` - :warning: No PR associated with branch <!-- branch-stack --> - \#6686 :point\_left: ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [x] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first). > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (internal timeout constant, no user-facing behavior change) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from <https://github.com/netbirdio/docs> here: <https://github.com/netbirdio/docs/pull/>\_\_ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Increased the time allowed for collecting system information, reducing premature timeouts during startup. * Helps the app wait longer before falling back to limited information, improving reliability of management and posture-related checks. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:07:39 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#26655