[PR #5004] [MERGED] [infra] Preset signal port on templates #26823

Open
opened 2026-08-05 07:07:51 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/5004
Author: @mlsmaycon
Created: 12/29/2025
Status: Merged
Merged: 12/29/2025
Merged by: @bcmmbaga

Base: mainHead: fix/signal-listening-port


📝 Commits (1)

  • 2145953 Preset signal port on templates

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 infrastructure_files/docker-compose.yml.tmpl (+2 -1)

📄 Description

Describe your changes

When passing certificates to signal, it will select port 443 when no port is supplied. This changes forces port 80.

closes #4918 #4941 #4763

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated management API configuration to explicitly run on port 80.

✏️ Tip: You can customize this high-level summary in your review settings.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/5004 **Author:** [@mlsmaycon](https://github.com/mlsmaycon) **Created:** 12/29/2025 **Status:** ✅ Merged **Merged:** 12/29/2025 **Merged by:** [@bcmmbaga](https://github.com/bcmmbaga) **Base:** `main` ← **Head:** `fix/signal-listening-port` --- ### 📝 Commits (1) - [`2145953`](https://github.com/netbirdio/netbird/commit/2145953f19437a7d36ed92377ef5df207ad8d772) Preset signal port on templates ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `infrastructure_files/docker-compose.yml.tmpl` (+2 -1) </details> ### 📄 Description ## Describe your changes When passing certificates to signal, it will select port 443 when no port is supplied. This changes forces port 80. ## Issue ticket number and link closes #4918 #4941 #4763 ## Stack <!-- branch-stack --> ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **Chores** * Updated management API configuration to explicitly run on port 80. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:07:51 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#26823