[PR #5052] [CLOSED] [misc] Add no-cgo stubs to idp/dex to fix building testing binaries #26966

Open
opened 2026-08-05 07:08:01 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/5052
Author: @lixmal
Created: 1/7/2026
Status: Closed

Base: mainHead: dex-nocgo-stub


📝 Commits (1)

  • 3e187a1 Add no-cgo stubs to idp/dex to fix building testing binaries

📊 Changes

4 files changed (+228 additions, -0 deletions)

View changed files

📝 idp/dex/config.go (+2 -0)
📝 idp/dex/provider.go (+2 -0)
📝 idp/dex/provider_test.go (+2 -0)
idp/dex/stub.go (+222 -0)

📄 Description

Describe your changes

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Chores

    • Added CGO build constraints to Dex identity provider components, enabling flexible builds with or without CGO support.
  • New Features

    • Introduced non-CGO stub implementation of Dex-based identity provider with clear error messaging indicating CGO support is required for full functionality.

✏️ Tip: You can customize this high-level summary in your review settings.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/5052 **Author:** [@lixmal](https://github.com/lixmal) **Created:** 1/7/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dex-nocgo-stub` --- ### 📝 Commits (1) - [`3e187a1`](https://github.com/netbirdio/netbird/commit/3e187a11a0748a13f3eaa84b640d653be1507b82) Add no-cgo stubs to idp/dex to fix building testing binaries ### 📊 Changes **4 files changed** (+228 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `idp/dex/config.go` (+2 -0) 📝 `idp/dex/provider.go` (+2 -0) 📝 `idp/dex/provider_test.go` (+2 -0) ➕ `idp/dex/stub.go` (+222 -0) </details> ### 📄 Description ## Describe your changes ## Issue ticket number and link ## Stack <!-- branch-stack --> ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added CGO build constraints to Dex identity provider components, enabling flexible builds with or without CGO support. * **New Features** * Introduced non-CGO stub implementation of Dex-based identity provider with clear error messaging indicating CGO support is required for full functionality. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:08:01 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#26966