[PR #5155] [CLOSED] [client] Check Windows Interfaces by Name and Descrption #27237

Open
opened 2026-08-05 07:08:24 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/5155
Author: @ressys1978
Created: 1/22/2026
Status: Closed

Base: mainHead: windows-include-pangp-softinterface


📝 Commits (10+)

  • 1785913 [signal] fix goroutines and memory leak on forward messages between peers (#3896)
  • 7dd8e4e [client] Fix shared sock buffer allocation (#4409)
  • 9fb7a7e [management] split high latency grpc metrics (#4408)
  • 0bc4afd [management] remove lock and continue user update on failure (#4410)
  • e061373 [client] Don't deactivate upstream resolvers on failure (#4128)
  • fa0e64a [management] fix ephemeral flag on peer batch response (#4420)
  • 01c0c9d [management] login filter to fix multiple peers connected with the same pub key (#3986)
  • 5ae7dc4 [management] remove withContext from store methods (#4422)
  • d0dd3bc [management] remove duplicated removal of groups on peer delete (#4421)
  • 4f9c94d [misc] fix Windows client and management bench tests (#4424)

📊 Changes

1485 files changed (+310310 additions, -2853 deletions)

View changed files

.devcontainer/Dockerfile (+15 -0)
.devcontainer/devcontainer.json (+20 -0)
.dockerignore-client (+3 -0)
.editorconfig (+8 -0)
.git-branches.toml (+27 -0)
.gitattributes (+1 -0)
.githooks/pre-push (+11 -0)
.github/FUNDING.yml (+3 -0)
.github/ISSUE_TEMPLATE/bug-issue-report.md (+71 -0)
.github/ISSUE_TEMPLATE/feature_request.md (+20 -0)
.github/pull_request_template.md (+27 -0)
.github/workflows/check-license-dependencies.yml (+110 -0)
.github/workflows/docs-ack.yml (+109 -0)
.github/workflows/forum.yml (+18 -0)
.github/workflows/git-town.yml (+21 -0)
.github/workflows/golang-test-darwin.yml (+47 -0)
.github/workflows/golang-test-freebsd.yml (+51 -0)
.github/workflows/golang-test-linux.yml (+602 -0)
.github/workflows/golang-test-windows.yml (+72 -0)
.github/workflows/golangci-lint.yml (+61 -0)

...and 80 more files

📄 Description

Describe your changes

Updated the NetworkMonitor code for checking if an interface is a SoftInterface or not in Windows. Also added PANGP (Palo Alto Networks GlobalProtect) to the strings to look for in the SoftInterface detection.

This fixes https://github.com/netbirdio/netbird/issues/5077 on Windows

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Doesn't change anything that's configurable.

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced Windows network interface detection to recognize additional virtual adapter types, including GlobalProtect network adapters.
  • Tests

    • Expanded test coverage for soft interface detection on Windows.

✏️ Tip: You can customize this high-level summary in your review settings.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/5155 **Author:** [@ressys1978](https://github.com/ressys1978) **Created:** 1/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `windows-include-pangp-softinterface` --- ### 📝 Commits (10+) - [`1785913`](https://github.com/netbirdio/netbird/commit/17859139a54d9e3e78105a61ffd1e0311ec7e7cf) [signal] fix goroutines and memory leak on forward messages between peers (#3896) - [`7dd8e4e`](https://github.com/netbirdio/netbird/commit/7dd8e4ed71815d9afbbd5620c2a171ff00116a14) [client] Fix shared sock buffer allocation (#4409) - [`9fb7a7e`](https://github.com/netbirdio/netbird/commit/9fb7a7ea30a326d632d489d8b03a0bb2f03cafa9) [management] split high latency grpc metrics (#4408) - [`0bc4afd`](https://github.com/netbirdio/netbird/commit/0bc4afdaa9541292b34634dbcee95e098af42e5c) [management] remove lock and continue user update on failure (#4410) - [`e061373`](https://github.com/netbirdio/netbird/commit/e061373b149c79b099aa5bdbda7be14a892a7c04) [client] Don't deactivate upstream resolvers on failure (#4128) - [`fa0e64a`](https://github.com/netbirdio/netbird/commit/fa0e64a5e81c150e70e4385c68ae988f4dad1a7c) [management] fix ephemeral flag on peer batch response (#4420) - [`01c0c9d`](https://github.com/netbirdio/netbird/commit/01c0c9d8869fe94ded2911f79fc3c2d9f544a03a) [management] login filter to fix multiple peers connected with the same pub key (#3986) - [`5ae7dc4`](https://github.com/netbirdio/netbird/commit/5ae7dc48d10535a44480cba6b4ea9f5f6ba28070) [management] remove withContext from store methods (#4422) - [`d0dd3bc`](https://github.com/netbirdio/netbird/commit/d0dd3bc5fd33f37ef6ce6ff49e7773eb62162153) [management] remove duplicated removal of groups on peer delete (#4421) - [`4f9c94d`](https://github.com/netbirdio/netbird/commit/4f9c94d8cee407ba0c9ad21adf41f14f103b5520) [misc] fix Windows client and management bench tests (#4424) ### 📊 Changes **1485 files changed** (+310310 additions, -2853 deletions) <details> <summary>View changed files</summary> ➕ `.devcontainer/Dockerfile` (+15 -0) ➕ `.devcontainer/devcontainer.json` (+20 -0) ➕ `.dockerignore-client` (+3 -0) ➕ `.editorconfig` (+8 -0) ➕ `.git-branches.toml` (+27 -0) ➕ `.gitattributes` (+1 -0) ➕ `.githooks/pre-push` (+11 -0) ➕ `.github/FUNDING.yml` (+3 -0) ➕ `.github/ISSUE_TEMPLATE/bug-issue-report.md` (+71 -0) ➕ `.github/ISSUE_TEMPLATE/feature_request.md` (+20 -0) ➕ `.github/pull_request_template.md` (+27 -0) ➕ `.github/workflows/check-license-dependencies.yml` (+110 -0) ➕ `.github/workflows/docs-ack.yml` (+109 -0) ➕ `.github/workflows/forum.yml` (+18 -0) ➕ `.github/workflows/git-town.yml` (+21 -0) ➕ `.github/workflows/golang-test-darwin.yml` (+47 -0) ➕ `.github/workflows/golang-test-freebsd.yml` (+51 -0) ➕ `.github/workflows/golang-test-linux.yml` (+602 -0) ➕ `.github/workflows/golang-test-windows.yml` (+72 -0) ➕ `.github/workflows/golangci-lint.yml` (+61 -0) _...and 80 more files_ </details> ### 📄 Description ## Describe your changes Updated the NetworkMonitor code for checking if an interface is a SoftInterface or not in Windows. Also added PANGP (Palo Alto Networks GlobalProtect) to the strings to look for in the SoftInterface detection. ## Issue ticket number and link This fixes https://github.com/netbirdio/netbird/issues/5077 on Windows ## Stack <!-- branch-stack --> ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) Doesn't change anything that's configurable. ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes * **New Features** * Enhanced Windows network interface detection to recognize additional virtual adapter types, including GlobalProtect network adapters. * **Tests** * Expanded test coverage for soft interface detection on Windows. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:08:24 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#27237