[PR #5220] [management] Configure the NB_IDP_TIMEOUT environment variable in doc… #27397

Open
opened 2026-08-05 07:08:40 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/5220
Author: @CodingTil
Created: 1/30/2026
Status: 🔄 Open

Base: mainHead: fix/idp-timeout


📝 Commits (1)

  • 17de9fb [management] Configure the NB_IDP_TIMEOUT environment variable in docker-compose.yml from setup.env

📊 Changes

3 files changed (+4 additions, -0 deletions)

View changed files

📝 infrastructure_files/configure.sh (+1 -0)
📝 infrastructure_files/docker-compose.yml.tmpl (+1 -0)
📝 infrastructure_files/setup.env.example (+2 -0)

📄 Description

Describe your changes

Following up on #4647, the environment variable NB_IDP_TIMEOUT should be injected into the generated docker-compose.yml file. For this, its value is configurable in the setup.env file.

This PR follows up on #4647, which lacked configuration.

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

I do believe this feature (that is, being able to configure the IDP timeout) should be documented, but I see this out of scope from this PR, as this PR only follows up due to a lacking configuration option missing from #4647. And that PR did not add documentation:

I don't feel this needs to be documented at this time, as currently the number of self-hosted netbird users with larger IDP environments is probably very small.

I would be glad to add documentation at a later time though.

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Chores
    • Added timeout configuration option for identity provider management operations in containerized deployments.

✏️ Tip: You can customize this high-level summary in your review settings.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/5220 **Author:** [@CodingTil](https://github.com/CodingTil) **Created:** 1/30/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/idp-timeout` --- ### 📝 Commits (1) - [`17de9fb`](https://github.com/netbirdio/netbird/commit/17de9fb647f8be15c6218c609b790d1511d88281) [management] Configure the NB_IDP_TIMEOUT environment variable in docker-compose.yml from setup.env ### 📊 Changes **3 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `infrastructure_files/configure.sh` (+1 -0) 📝 `infrastructure_files/docker-compose.yml.tmpl` (+1 -0) 📝 `infrastructure_files/setup.env.example` (+2 -0) </details> ### 📄 Description ## Describe your changes Following up on #4647, the environment variable NB_IDP_TIMEOUT should be injected into the generated docker-compose.yml file. For this, its value is configurable in the setup.env file. ## Issue ticket number and link This PR follows up on #4647, which lacked configuration. ## Stack <!-- branch-stack --> ### Checklist - [X] Is it a bug fix - [ ] Is a typo/documentation fix - [X] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [X] Documentation is **not needed** for this change (explain why) I do believe this feature (that is, being able to configure the IDP timeout) should be documented, but I see this out of scope from this PR, as this PR only follows up due to a lacking configuration option missing from #4647. And that PR did not add documentation: > I don't feel this needs to be documented at this time, as currently the number of self-hosted netbird users with larger IDP environments is probably very small. I would be glad to add documentation at a later time though. ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added timeout configuration option for identity provider management operations in containerized deployments. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:08:40 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#27397