[PR #6094] [client] Handle management and admin url in profile add command #27555

Open
opened 2026-08-05 07:08:53 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6094
Author: @l-szczepanski-speednet
Created: 5/6/2026
Status: 🔄 Open

Base: mainHead: profile_mgmt_url


📝 Commits (1)

  • 708854d Handle management and admin url in profile add command

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 client/cmd/profile.go (+11 -0)

📄 Description

Describe your changes

I called SetConfig after profile add if there is custom management or/and admin url.

#5983

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

I used global flags that should be respected by subcommands.

Summary by CodeRabbit

  • New Features
    • Added optional management and admin URL configuration during profile creation. Users can now specify these URLs when setting up a new profile, and the system will automatically apply these configurations with improved error handling. Descriptive error messages are provided to assist users with troubleshooting and verifying their configuration settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6094 **Author:** [@l-szczepanski-speednet](https://github.com/l-szczepanski-speednet) **Created:** 5/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `profile_mgmt_url` --- ### 📝 Commits (1) - [`708854d`](https://github.com/netbirdio/netbird/commit/708854d7a5e7b1ad1b60523e09711233b5c2884b) Handle management and admin url in profile add command ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/cmd/profile.go` (+11 -0) </details> ### 📄 Description ## Describe your changes I called SetConfig after profile add if there is custom management or/and admin url. ## Issue ticket number and link #5983 ## Stack <!-- branch-stack --> ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) I used global flags that should be respected by subcommands. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added optional management and admin URL configuration during profile creation. Users can now specify these URLs when setting up a new profile, and the system will automatically apply these configurations with improved error handling. Descriptive error messages are provided to assist users with troubleshooting and verifying their configuration settings. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:08:53 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#27555