[PR #6185] [client-ui] Add non default socket file discovery #27698

Open
opened 2026-08-05 07:09:06 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6185
Author: @kiaraly
Created: 5/17/2026
Status: 🔄 Open

Base: mainHead: fix-client-ui-socket


📝 Commits (1)

  • 85e3905 [client-ui] Add non default socket file discovery

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 client/ui/client_ui.go (+4 -0)

📄 Description

Describe your changes

Applies the logic from #5425 to the client ui. Without it the ui just looks at /var/run/netbird.sock which doesn't exist with the systemd service.

https://github.com/netbirdio/netbird/issues/4269

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of the --daemon-addr CLI flag by normalizing and resolving the provided daemon service address before establishing the connection.

Review Change Stack


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6185 **Author:** [@kiaraly](https://github.com/kiaraly) **Created:** 5/17/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-client-ui-socket` --- ### 📝 Commits (1) - [`85e3905`](https://github.com/netbirdio/netbird/commit/85e390585ca0c1fabf4bd4bc4d7538ddc8c47fd5) [client-ui] Add non default socket file discovery ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/ui/client_ui.go` (+4 -0) </details> ### 📄 Description ## Describe your changes Applies the logic from #5425 to the client ui. Without it the ui just looks at `/var/run/netbird.sock` which doesn't exist with the systemd service. ## Issue ticket number and link https://github.com/netbirdio/netbird/issues/4269 ### Checklist - [x] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved handling of the `--daemon-addr` CLI flag by normalizing and resolving the provided daemon service address before establishing the connection. <!-- review_stack_entry_start --> [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/netbirdio/netbird/pull/6185?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:09:06 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#27698