[PR #6288] [client] pass entrypoint args to "netbird up" #27918

Open
opened 2026-08-05 07:09:24 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6288
Author: @lotheac
Created: 5/29/2026
Status: 🔄 Open

Base: mainHead: push-tprpuotumqlv


📝 Commits (1)

  • 82cd546 [client] pass entrypoint args to "netbird up"

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 client/netbird-entrypoint.sh (+3 -3)

📄 Description

Describe your changes

this makes passing arguments, such as --extra-iface-blacklist, work as expected.

none

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • This change does not modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — OR I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

I think it's reasonable for end users to expect that passing args to the docker container passes them to netbird.

Docs PR URL (required if "docs added" is checked)

n/a

Summary by CodeRabbit

  • Bug Fixes
    • Command-line arguments are now forwarded into the daemon startup flow so options passed at launch are honored during initialization.
    • Ensures CLI-provided configuration consistently affects the initial daemon bootstrap.
    • No changes to public interfaces; this only improves startup behavior and predictable configuration from launch.

Review Change Stack


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6288 **Author:** [@lotheac](https://github.com/lotheac) **Created:** 5/29/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `push-tprpuotumqlv` --- ### 📝 Commits (1) - [`82cd546`](https://github.com/netbirdio/netbird/commit/82cd54650b6b6bfeb3e5d1c6e54a1a0f4509223f) [client] pass entrypoint args to "netbird up" ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `client/netbird-entrypoint.sh` (+3 -3) </details> ### 📄 Description ## Describe your changes this makes passing arguments, such as --extra-iface-blacklist, work as expected. ## Issue ticket number and link none ## Stack <!-- branch-stack --> ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [X] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [X] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first). > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [X] Documentation is **not needed** for this change (explain why) I think it's reasonable for end users to expect that passing args to the docker container passes them to netbird. ### Docs PR URL (required if "docs added" is checked) n/a <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Command-line arguments are now forwarded into the daemon startup flow so options passed at launch are honored during initialization. * Ensures CLI-provided configuration consistently affects the initial daemon bootstrap. * No changes to public interfaces; this only improves startup behavior and predictable configuration from launch. <!-- review_stack_entry_start --> [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/netbirdio/netbird/pull/6288?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 07:09:24 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#27918