[PR #6366] [CLOSED] [misc] Bump to Go 1.26.4 #28095

Open
opened 2026-08-05 08:05:46 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6366
Author: @phillebaba
Created: 6/8/2026
Status: Closed

Base: mainHead: go-1.26


📝 Commits (1)

📊 Changes

9 files changed (+20 additions, -20 deletions)

View changed files

📝 .devcontainer/Dockerfile (+1 -1)
📝 .github/workflows/golang-test-linux.yml (+1 -1)
📝 client/internal/metrics/infra/ingest/Dockerfile (+2 -2)
📝 combined/Dockerfile.multistage (+1 -1)
📝 go.mod (+1 -1)
📝 management/Dockerfile.multistage (+1 -1)
📝 proxy/Dockerfile (+1 -1)
📝 proxy/Dockerfile.multistage (+1 -1)
📝 shared/auth/jwt/validator.go (+11 -11)

📄 Description

Describe your changes

Updates the Go version to 1.26.4 to enable importing of Kubernetes dependencies. It also fixes linter warnings due to use of deprecated features.

Relates to #6260

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • This change does not modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — OR I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain in build and CI images to 1.26 for improved compatibility and security.
  • Bug Fixes
    • Improved ECDSA JWT public-key handling to make token validation more robust and reliable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6366 **Author:** [@phillebaba](https://github.com/phillebaba) **Created:** 6/8/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `go-1.26` --- ### 📝 Commits (1) - [`d34fe1a`](https://github.com/netbirdio/netbird/commit/d34fe1a15c0d41a65b43d014cef0e21ba7342c83) Bump to Go 1.26.4 ### 📊 Changes **9 files changed** (+20 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+1 -1) 📝 `.github/workflows/golang-test-linux.yml` (+1 -1) 📝 `client/internal/metrics/infra/ingest/Dockerfile` (+2 -2) 📝 `combined/Dockerfile.multistage` (+1 -1) 📝 `go.mod` (+1 -1) 📝 `management/Dockerfile.multistage` (+1 -1) 📝 `proxy/Dockerfile` (+1 -1) 📝 `proxy/Dockerfile.multistage` (+1 -1) 📝 `shared/auth/jwt/validator.go` (+11 -11) </details> ### 📄 Description ## Describe your changes Updates the Go version to 1.26.4 to enable importing of Kubernetes dependencies. It also fixes linter warnings due to use of deprecated features. ## Issue ticket number and link Relates to #6260 ## Stack <!-- branch-stack --> ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [x] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first). > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated Go toolchain in build and CI images to 1.26 for improved compatibility and security. * **Bug Fixes** * Improved ECDSA JWT public-key handling to make token validation more robust and reliable. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 08:05:46 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#28095