DYNR/netbird
2
0
Fork 0
mirror of https://github.com/netbirdio/netbird.git synced 2026-08-07 02:29:06 -04:00
Code Issues 23.5k Packages Projects Releases 10 Wiki Activity

[PR #6762] [client, management] Support per-peer lazy connection state and default proxy peers to lazy #28922

New Issue
Open
opened 2026-08-05 08:07:09 -04:00 by saavagebueno · 0 comments
saavagebueno commented 2026-08-05 08:07:09 -04:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6762
Author: @lixmal
Created: 7/14/2026
Status: 🔄 Open

Base: main ← Head: lazy-conn-per-peer

📝 Commits (5)

  • 707bc3e Support per-peer lazy connection state and default proxy peers to lazy
  • e0f275c Classify forward targets from incoming config in lazy exclusion
  • b9489e5 Set IsUserspaceBind mock so lazy manager starts in engine test
  • 06ab0cb Skip lazy exclude reconciliation when the set is unchanged
  • ed309b7 Keep cached lazy flag when a sync carries no peer config

📊 Changes

16 files changed (+1279 additions, -1071 deletions)

View changed files

📝 client/internal/conn_mgr.go (+59 -88)
📝 client/internal/conn_mgr_test.go (+88 -0)
📝 client/internal/engine.go (+52 -36)
📝 client/internal/engine_lazy_exclude_test.go (+4 -2)
📝 client/internal/engine_test.go (+2 -1)
📝 management/internals/shared/grpc/components_encoder.go (+1 -0)
📝 management/internals/shared/grpc/components_encoder_test.go (+3 -3)
📝 management/internals/shared/grpc/components_envelope_response.go (+4 -4)
📝 management/internals/shared/grpc/conversion.go (+3 -2)
📝 management/server/peer/peer.go (+1 -0)
📝 shared/management/networkmap/decode.go (+1 -0)
📝 shared/management/networkmap/encode.go (+16 -2)
📝 shared/management/networkmap/envelope.go (+2 -2)
📝 shared/management/proto/management.pb.go (+1019 -931)
📝 shared/management/proto/management.proto (+21 -0)
📝 shared/management/types/component_types.go (+3 -0)

📄 Description

Describe your changes

Lazy connections were an all-or-nothing account setting. This makes laziness controllable per peer and runs the lazy connection manager continuously, so ephemeral proxy peers connect on-demand by default even when the account-wide flag is off.

  • Run the lazy connection manager whenever it is supported instead of gating it on the account-wide flag; the account flag and the local override now decide which peers default to lazy versus always-active.
  • Add a per-peer lazy override to the network map (default / lazy / eager) so management can steer individual peers in either direction.
  • Default ephemeral proxy peers to lazy on both endpoints, so shared proxy infrastructure is not kept permanently connected to every peer.
  • Keep a local NB_LAZY_CONN / MDM override authoritative over the per-peer state.
  • Reflect the resolved account-wide default in client status and update it when the flag changes at runtime.

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • This change does not modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — OR I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

No new user-facing configuration is introduced; the per-peer eager override has no admin-facing setting yet and the proxy-peer default is internal behavior.

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • New Features
    • Added per-peer lazy connection control (default/lazy/eager) via management configuration, including embedded proxy–aware lazy behavior.
    • Lazy peer eligibility and exclusions now incorporate ingress forwarding rules end-to-end.
  • Bug Fixes
    • Remote lazy feature-flag updates no longer restart or reconcile lazy peers unnecessarily.
    • Exclude-list updates avoid redundant recomputation when the effective set hasn’t changed.
  • Tests
    • Expanded coverage for per-peer lazy resolution and forwarding-rule-based exclusion behavior, plus updated engine lazy test setup.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6762 **Author:** [@lixmal](https://github.com/lixmal) **Created:** 7/14/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `lazy-conn-per-peer` --- ### 📝 Commits (5) - [`707bc3e`](https://github.com/netbirdio/netbird/commit/707bc3ea623b67e49de1fdbb0c8834a1437aba50) Support per-peer lazy connection state and default proxy peers to lazy - [`e0f275c`](https://github.com/netbirdio/netbird/commit/e0f275cc60aa9915a44789c9e3cc36978c1c7408) Classify forward targets from incoming config in lazy exclusion - [`b9489e5`](https://github.com/netbirdio/netbird/commit/b9489e5281aaf762d1c7b0064583f481c64e16ef) Set IsUserspaceBind mock so lazy manager starts in engine test - [`06ab0cb`](https://github.com/netbirdio/netbird/commit/06ab0cb3f41bf8ce491d4ff68a532b664590a407) Skip lazy exclude reconciliation when the set is unchanged - [`ed309b7`](https://github.com/netbirdio/netbird/commit/ed309b70f01cae412ce83ba0ab3113f00ec25c61) Keep cached lazy flag when a sync carries no peer config ### 📊 Changes **16 files changed** (+1279 additions, -1071 deletions) <details> <summary>View changed files</summary> 📝 `client/internal/conn_mgr.go` (+59 -88) 📝 `client/internal/conn_mgr_test.go` (+88 -0) 📝 `client/internal/engine.go` (+52 -36) 📝 `client/internal/engine_lazy_exclude_test.go` (+4 -2) 📝 `client/internal/engine_test.go` (+2 -1) 📝 `management/internals/shared/grpc/components_encoder.go` (+1 -0) 📝 `management/internals/shared/grpc/components_encoder_test.go` (+3 -3) 📝 `management/internals/shared/grpc/components_envelope_response.go` (+4 -4) 📝 `management/internals/shared/grpc/conversion.go` (+3 -2) 📝 `management/server/peer/peer.go` (+1 -0) 📝 `shared/management/networkmap/decode.go` (+1 -0) 📝 `shared/management/networkmap/encode.go` (+16 -2) 📝 `shared/management/networkmap/envelope.go` (+2 -2) 📝 `shared/management/proto/management.pb.go` (+1019 -931) 📝 `shared/management/proto/management.proto` (+21 -0) 📝 `shared/management/types/component_types.go` (+3 -0) </details> ### 📄 Description ## Describe your changes Lazy connections were an all-or-nothing account setting. This makes laziness controllable per peer and runs the lazy connection manager continuously, so ephemeral proxy peers connect on-demand by default even when the account-wide flag is off. - Run the lazy connection manager whenever it is supported instead of gating it on the account-wide flag; the account flag and the local override now decide which peers default to lazy versus always-active. - Add a per-peer lazy override to the network map (default / lazy / eager) so management can steer individual peers in either direction. - Default ephemeral proxy peers to lazy on both endpoints, so shared proxy infrastructure is not kept permanently connected to every peer. - Keep a local NB_LAZY_CONN / MDM override authoritative over the per-peer state. - Reflect the resolved account-wide default in client status and update it when the flag changes at runtime. ## Issue ticket number and link ## Stack <!-- branch-stack --> ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [x] Is a feature enhancement - [ ] It is a refactor - [x] Created tests that fail without the change (if possible) - [ ] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first). > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) No new user-facing configuration is introduced; the per-peer eager override has no admin-facing setting yet and the proxy-peer default is internal behavior. ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added per-peer lazy connection control (default/lazy/eager) via management configuration, including embedded proxy–aware lazy behavior. * Lazy peer eligibility and exclusions now incorporate ingress forwarding rules end-to-end. * **Bug Fixes** * Remote lazy feature-flag updates no longer restart or reconcile lazy peers unnecessarily. * Exclude-list updates avoid redundant recomputation when the effective set hasn’t changed. * **Tests** * Expanded coverage for per-peer lazy resolution and forwarding-rule-based exclusion behavior, plus updated engine lazy test setup. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 08:07:09 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
2021 Q4
2021 Q4
2021 Q4
2022 Q1
2022 Q1
2022 Q1
2022 Q1
2022 Q1
2022 Q1
accessibility
accessibility
accessibility
acl
acl
acl
agent
agent
agent
agent
agent
agent
Android
Android
Android
Android
Android
Android
api
api
api
authentik
authentik
authentik
automation
automation
automation
azure
azure
azure
battery-usage
battery-usage
battery-usage
bug
cache
cache
cache
client
client
client
client-ui
client-ui
client-ui
cloud
cloud
cloud
cloud-only
cloud-only
cloud-only
cloudflare
cloudflare
cloudflare
community
community
community
compatibility
compatibility
compatibility
config-idp
config-idp
config-idp
config-issue
config-issue
config-issue
connection
connection
connection
contribution
contribution
contribution
coturn
coturn
coturn
cross-vpn
cross-vpn
cross-vpn
dashboard
dashboard
dashboard
data-usage
data-usage
data-usage
distribution
distribution
distribution
dns
dns
dns
docker
docker
docker
documentation
documentation
documentation
duplicate
duplicate
duplicate
enhancement
enhancement
event-stream
event-stream
event-stream
feature-request
feature-request
feature-request
freebsd
freebsd
freebsd
getting-started
getting-started
getting-started
go
go
go
good first issue
good first issue
good first issue
gui
gui
gui
help wanted
help wanted
help wanted
home-assistant
home-assistant
home-assistant
idp
idp
idp
inconsistency
inconsistency
inconsistency
integration
integration
integration
integrations
integrations
integrations
ios
ios
ios
ipv6
ipv6
ipv6
jwt
jwt
jwt
k8s
k8s
k8s
keycloak
keycloak
keycloak
linux
linux
linux
login
login
login
macos
macos
macos
management-service
management-service
management-service
Medium
Medium
Medium
missing-docs
missing-docs
missing-docs
mobile
mobile
mobile
moved-internal
moved-internal
moved-internal
needs-review
needs-review
needs-review
netbird-ui
netbird-ui
netbird-ui
networking
networking
networking
new-platform
new-platform
new-platform
nginx
nginx
nginx
notification
notification
notification
okta
okta
okta
openwrt
openwrt
openwrt
P2
P2
P2
packaging
packaging
packaging
peer-management
peer-management
peer-management
peer-management
peer-management
peer-management
peer-management
peer-management
peer-management
performance
performance
performance
postgres
postgres
postgres
posture-checks
posture-checks
posture-checks
psk
psk
psk
pull-request
Mirrored from GitHub Pull Request
 question
question
question
refactor
refactor
refactor
relay
relay
relay
release
release
release
rfc
rfc
rfc
routes
routes
routes
security
security
security
security-improvement
security-improvement
security-improvement
security-related
security-related
security-related
self-hosting
self-hosting
self-hosting
server
server
server
signal
signal
signal
sleep-issue
sleep-issue
sleep-issue
ssh
ssh
ssh
ssl
ssl
ssl
status
status
status
store
store
store
synology
synology
synology
system-compatibility-issue
system-compatibility-issue
system-compatibility-issue
test-suite
test-suite
test-suite
third-party-integration
third-party-integration
third-party-integration
triage
triage
triage
triage
triage
triage
triage-needed
triage-needed
triage-needed
troubleshooting
troubleshooting
troubleshooting
UX
UX
UX
waiting-feedback
waiting-feedback
waiting-feedback
windows
windows
windows
wontfix
wontfix
wontfix
zitadel
zitadel
zitadel
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dynr-servers saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#28922
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?