[PR #6955] [client] Test/gui memory leak fix #29302

Open
opened 2026-08-05 08:07:50 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6955
Author: @pappz
Created: 7/29/2026
Status: 🔄 Open

Base: mainHead: test/gui-memory-leak-fix


📝 Commits (10+)

  • 29b9734 [client] Fix tray menu item leak on relayout
  • e1d82fc [client] Coalesce SubscribeStatus snapshot bursts
  • 4b915e4 [client] Hold menuMu across tray item setters
  • 4c95b20 [client] Drain buffered tick when coalesce window expires
  • b6deed3 [client] Feed tray status via direct callback instead of the event bus
  • 22e0b66 [client] Replay latest status snapshot into windows on show
  • 28ff2b7 [client] Dispatch status snapshots only to visible windows
  • 859ac60 Merge branch 'fix/tray-menu-item-leak' into test/gui-memory-leak-fix
  • 175ca4f Merge branch 'fix/subscribe-status-coalesce' into test/gui-memory-leak-fix
  • 8b4061c Merge branch 'fix/ui-status-dispatch' into test/gui-memory-leak-fix

📊 Changes

9 files changed (+234 additions, -69 deletions)

View changed files

📝 client/server/status_stream.go (+48 -3)
📝 client/ui/main.go (+35 -15)
📝 client/ui/services/daemon_feed.go (+61 -3)
📝 client/ui/services/windowmanager.go (+22 -0)
📝 client/ui/tray.go (+38 -18)
📝 client/ui/tray_profiles.go (+10 -5)
📝 client/ui/tray_session.go (+11 -14)
📝 client/ui/tray_status.go (+0 -10)
📝 client/ui/tray_update.go (+9 -1)

📄 Description

Describe your changes

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • This change does not modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — OR I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes

    • Improved status updates by coalescing bursts deterministically and delivering the latest snapshot reliably.
    • Tray and UI status handling now consistently replays the most recent cached state to newly shown windows, avoiding stale/hidden-window gaps.
    • Fixed macOS reopen and restored-window behavior to show the main window only when appropriate.
    • Stabilized tray behavior: safer menu relayout, connect/disconnect item enabling, and smoother session-expiration countdown updates.
  • Enhancements

    • Unified status propagation via Go-side subscribers, with synchronous in-order delivery and window-targeted dispatch where applicable.
    • Improved window focusing for login and progress flows via a shared “show main” hook.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6955 **Author:** [@pappz](https://github.com/pappz) **Created:** 7/29/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `test/gui-memory-leak-fix` --- ### 📝 Commits (10+) - [`29b9734`](https://github.com/netbirdio/netbird/commit/29b97340d6eeb33ef6e2761c62b0d8a078d621c6) [client] Fix tray menu item leak on relayout - [`e1d82fc`](https://github.com/netbirdio/netbird/commit/e1d82fc326427c62f39cf3d36d9468cb85ffd815) [client] Coalesce SubscribeStatus snapshot bursts - [`4b915e4`](https://github.com/netbirdio/netbird/commit/4b915e4a5a14674a133f696ee31c54396cf9c3cb) [client] Hold menuMu across tray item setters - [`4c95b20`](https://github.com/netbirdio/netbird/commit/4c95b202519a2ebd2546fb508a9244cc4ba946b0) [client] Drain buffered tick when coalesce window expires - [`b6deed3`](https://github.com/netbirdio/netbird/commit/b6deed39fbd3065a55f50f2d9b3c4495cd694712) [client] Feed tray status via direct callback instead of the event bus - [`22e0b66`](https://github.com/netbirdio/netbird/commit/22e0b664120f2c85fa13c5e5ec404ba7d22f1385) [client] Replay latest status snapshot into windows on show - [`28ff2b7`](https://github.com/netbirdio/netbird/commit/28ff2b7b3b144dfd4714b9ba314cd730ab099871) [client] Dispatch status snapshots only to visible windows - [`859ac60`](https://github.com/netbirdio/netbird/commit/859ac60c90827854954ff1bb6960ee554bf0e30f) Merge branch 'fix/tray-menu-item-leak' into test/gui-memory-leak-fix - [`175ca4f`](https://github.com/netbirdio/netbird/commit/175ca4f0e0213b9aa3d72ee0c5e3bbb771307024) Merge branch 'fix/subscribe-status-coalesce' into test/gui-memory-leak-fix - [`8b4061c`](https://github.com/netbirdio/netbird/commit/8b4061cfaf56b6eda78ff0b4bd6b8d0d1c64da97) Merge branch 'fix/ui-status-dispatch' into test/gui-memory-leak-fix ### 📊 Changes **9 files changed** (+234 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `client/server/status_stream.go` (+48 -3) 📝 `client/ui/main.go` (+35 -15) 📝 `client/ui/services/daemon_feed.go` (+61 -3) 📝 `client/ui/services/windowmanager.go` (+22 -0) 📝 `client/ui/tray.go` (+38 -18) 📝 `client/ui/tray_profiles.go` (+10 -5) 📝 `client/ui/tray_session.go` (+11 -14) 📝 `client/ui/tray_status.go` (+0 -10) 📝 `client/ui/tray_update.go` (+9 -1) </details> ### 📄 Description ## Describe your changes ## Issue ticket number and link ## Stack <!-- branch-stack --> ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [ ] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first). > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [ ] Documentation is **not needed** for this change (explain why) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- codesmith:footer --> --- <a href="https://app.blacksmith.sh/netbirdio/codesmith/netbird/pr/6955"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-light-v2.svg"><img alt="View with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/view-with-codesmith-dark-v2.svg"></picture></a> <a href="https://backend.blacksmith.sh/track/enable-autofix?expires=1787906214&installation_model_id=427504&pr_number=6955&repository=netbirdio%2Fnetbird&return_to=https%3A%2F%2Fgithub.com%2Fnetbirdio%2Fnetbird%2Fpull%2F6955&signature=c9521faaffc60ef6026f8cac70f1cb0132fbe32947bfcc65caf59f9533620231"><picture><source media="(prefers-color-scheme: dark)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-light.svg"><img alt="Autofix with [code]smith" src="https://pr-comments-assets.blacksmith.sh/codesmith/autofix-with-codesmith-dark.svg"></picture></a> <sup>Need help on this PR? Tag <code>@codesmith-bot</code> with what you need. Autofix is disabled.</sup> <!-- codesmith:autofix:disabled --> <!-- /codesmith:footer --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved status updates by coalescing bursts deterministically and delivering the latest snapshot reliably. - Tray and UI status handling now consistently replays the most recent cached state to newly shown windows, avoiding stale/hidden-window gaps. - Fixed macOS reopen and restored-window behavior to show the main window only when appropriate. - Stabilized tray behavior: safer menu relayout, connect/disconnect item enabling, and smoother session-expiration countdown updates. - **Enhancements** - Unified status propagation via Go-side subscribers, with synchronous in-order delivery and window-targeted dispatch where applicable. - Improved window focusing for login and progress flows via a shared “show main” hook. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 08:07:50 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#29302