[PR #6649] [MERGED] [management] Add vLLM e2e test #29772

Closed
opened 2026-08-05 08:08:55 -04:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbirdio/netbird/pull/6649
Author: @braginini
Created: 7/2/2026
Status: Merged
Merged: 7/2/2026
Merged by: @mlsmaycon

Base: mainHead: feature/add-vllm-support


📝 Commits (4)

  • 13194ec Add vLLM to Agent Network
  • 5d2abf1 Merge remote-tracking branch 'origin/main' into feature/add-vllm-support
  • f7fb9a3 Add vllm e2e test
  • 5cec386 Merge remote-tracking branch 'origin/main' into feature/add-vllm-support

📊 Changes

2 files changed (+284 additions, -0 deletions)

View changed files

e2e/agentnetwork/vllm_test.go (+171 -0)
e2e/harness/vllm.go (+113 -0)

📄 Description

Describe your changes

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • This change does not modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — OR I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Summary by CodeRabbit

  • New Features

    • Added end-to-end coverage for connecting to a self-hosted, OpenAI-compatible vLLM backend through the proxy.
    • Added a test harness that spins up a mock vLLM service for validation.
  • Bug Fixes

    • Verified chat completions return the expected OpenAI-style response through the proxy.
    • Confirmed usage data is captured and reflected in consumption records.
    • Added checks for access-log ingestion and stable request handling during startup.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbirdio/netbird/pull/6649 **Author:** [@braginini](https://github.com/braginini) **Created:** 7/2/2026 **Status:** ✅ Merged **Merged:** 7/2/2026 **Merged by:** [@mlsmaycon](https://github.com/mlsmaycon) **Base:** `main` ← **Head:** `feature/add-vllm-support` --- ### 📝 Commits (4) - [`13194ec`](https://github.com/netbirdio/netbird/commit/13194eca99d02c7d10617f6ccd77ee0a2d9751ee) Add vLLM to Agent Network - [`5d2abf1`](https://github.com/netbirdio/netbird/commit/5d2abf1d4e4dc5566cb018e38d71da06b6bb20bd) Merge remote-tracking branch 'origin/main' into feature/add-vllm-support - [`f7fb9a3`](https://github.com/netbirdio/netbird/commit/f7fb9a35cb1c0ed02ee48e262db0acc077c3228a) Add vllm e2e test - [`5cec386`](https://github.com/netbirdio/netbird/commit/5cec3862ab30c6eb62a72cbdd740e3b435bba02e) Merge remote-tracking branch 'origin/main' into feature/add-vllm-support ### 📊 Changes **2 files changed** (+284 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `e2e/agentnetwork/vllm_test.go` (+171 -0) ➕ `e2e/harness/vllm.go` (+113 -0) </details> ### 📄 Description ## Describe your changes ## Issue ticket number and link ## Stack <!-- branch-stack --> ### Checklist - [ ] Is it a bug fix - [ ] Is a typo/documentation fix - [ ] Is a feature enhancement - [x] It is a refactor - [ ] Created tests that fail without the change (if possible) - [ ] This change does **not** modify the public API, gRPC protocols, functionality behavior, CLI / service flags, or introduce a new feature — **OR** I have discussed it with the NetBird team beforehand (link the issue / Slack thread in the description). See [CONTRIBUTING.md](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTING.md#discuss-changes-with-the-netbird-team-first). > By submitting this pull request, you confirm that you have read and agree to the terms of the [Contributor License Agreement](https://github.com/netbirdio/netbird/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT.md). ## Documentation Select exactly one: - [ ] I added/updated documentation for this change - [x] Documentation is **not needed** for this change (explain why) ### Docs PR URL (required if "docs added" is checked) Paste the PR link from https://github.com/netbirdio/docs here: https://github.com/netbirdio/docs/pull/__ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added end-to-end coverage for connecting to a self-hosted, OpenAI-compatible vLLM backend through the proxy. * Added a test harness that spins up a mock vLLM service for validation. * **Bug Fixes** * Verified chat completions return the expected OpenAI-style response through the proxy. * Confirmed usage data is captured and reflected in consumption records. * Added checks for access-log ingestion and stable request handling during startup. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2026-08-05 08:08:55 -04:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DYNR/netbird#29772