SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #37] [MERGED] Add reusable Badge component and refactor badge usage #127

New Issue
Closed
opened 2025-11-20 04:12:57 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:12:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/37
Author: @MickLesk
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @michelroegl-brunner

Base: development ← Head: feat_badges

📝 Commits (1)

  • 0f2f126 Add reusable Badge component and refactor badge usage

📊 Changes

6 files changed (+179 additions, -86 deletions)

View changed files

➕ src/app/_components/Badge.tsx (+140 -0)
📝 src/app/_components/DarkModeProvider.tsx (+12 -9)
📝 src/app/_components/InstalledScriptsTab.tsx (+7 -32)
📝 src/app/_components/ScriptCard.tsx (+3 -14)
📝 src/app/_components/ScriptDetailModal.tsx (+6 -29)
📝 src/app/layout.tsx (+11 -2)

📄 Description

✍️ Description

Introduces a new Badge component with variants for type, updateable, privileged, status, execution mode, and note. Refactors ScriptCard, ScriptDetailModal, and InstalledScriptsTab to use the new Badge components, improving consistency and maintainability. Also updates DarkModeProvider and layout.tsx for better dark mode handling and fallback.

🔗 Related PR / Issue

Link: #30

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

Screenshot for frontend Change

image image

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/37 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `development` ← **Head:** `feat_badges` --- ### 📝 Commits (1) - [`0f2f126`](https://github.com/community-scripts/ProxmoxVE-Local/commit/0f2f126a449f177e9dc62b4434cce2cb45a305bf) Add reusable Badge component and refactor badge usage ### 📊 Changes **6 files changed** (+179 additions, -86 deletions) <details> <summary>View changed files</summary> ➕ `src/app/_components/Badge.tsx` (+140 -0) 📝 `src/app/_components/DarkModeProvider.tsx` (+12 -9) 📝 `src/app/_components/InstalledScriptsTab.tsx` (+7 -32) 📝 `src/app/_components/ScriptCard.tsx` (+3 -14) 📝 `src/app/_components/ScriptDetailModal.tsx` (+6 -29) 📝 `src/app/layout.tsx` (+11 -2) </details> ### 📄 Description <!--🛑 All Pull Requests need to made against the development branch. PRs against main will get closed. --> ## ✍️ Description Introduces a new Badge component with variants for type, updateable, privileged, status, execution mode, and note. Refactors ScriptCard, ScriptDetailModal, and InstalledScriptsTab to use the new Badge components, improving consistency and maintainability. Also updates DarkModeProvider and layout.tsx for better dark mode handling and fallback. ## 🔗 Related PR / Issue Link: #30 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. ## Screenshot for frontend Change <img width="1168" height="269" alt="image" src="https://github.com/user-attachments/assets/384e49bc-20d0-478d-9b92-08cb0e1b48a5" /> <img width="531" height="243" alt="image" src="https://github.com/user-attachments/assets/bf06bdf0-c4ef-4b68-998a-756d7991bb94" /> --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:12:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#127
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?