[PR #38] [MERGED] Add Filtering Function and sorting to ScriptsGrid #128

Closed
opened 2025-11-20 04:12:58 -05:00 by saavagebueno · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/38
Author: @MickLesk
Created: 10/6/2025
Status: Merged
Merged: 10/6/2025
Merged by: @michelroegl-brunner

Base: developmentHead: feat_filter


📝 Commits (1)

  • c1cb208 Add advanced filtering and sorting to ScriptsGrid

📊 Changes

4 files changed (+497 additions, -40 deletions)

View changed files

src/app/_components/FilterBar.tsx (+342 -0)
📝 src/app/_components/ScriptsGrid.tsx (+142 -38)
📝 src/server/api/routers/scripts.ts (+4 -2)
📝 src/server/lib/scripts.ts (+9 -0)

📄 Description

✍️ Description

Add advanced filtering and sorting to ScriptsGrid

Link: #25

Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

Screenshot for frontend Change

image

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/38 **Author:** [@MickLesk](https://github.com/MickLesk) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `development` ← **Head:** `feat_filter` --- ### 📝 Commits (1) - [`c1cb208`](https://github.com/community-scripts/ProxmoxVE-Local/commit/c1cb2085b8b1cd4c1483d54b32d661b08677353d) Add advanced filtering and sorting to ScriptsGrid ### 📊 Changes **4 files changed** (+497 additions, -40 deletions) <details> <summary>View changed files</summary> ➕ `src/app/_components/FilterBar.tsx` (+342 -0) 📝 `src/app/_components/ScriptsGrid.tsx` (+142 -38) 📝 `src/server/api/routers/scripts.ts` (+4 -2) 📝 `src/server/lib/scripts.ts` (+9 -0) </details> ### 📄 Description <!--🛑 All Pull Requests need to made against the development branch. PRs against main will get closed. --> ## ✍️ Description [Add advanced filtering and sorting to ScriptsGrid](https://github.com/community-scripts/ProxmoxVE-Local/commit/c1cb2085b8b1cd4c1483d54b32d661b08677353d) ## 🔗 Related PR / Issue Link: #25 ## ✅ Prerequisites (**X** in brackets) - [x] **Self-review completed** – Code follows project standards. - [x] **Tested thoroughly** – Changes work as expected. - [x] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. ## Screenshot for frontend Change <img width="1187" height="462" alt="image" src="https://github.com/user-attachments/assets/59ef3837-f67a-4fe8-b285-5395274c066c" /> --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [x] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:12:58 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#128