SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #41] [MERGED] refactore installed scipts tab #130

New Issue
Closed
opened 2025-11-20 04:12:58 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:12:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/41
Author: @michelroegl-brunner
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @michelroegl-brunner

Base: development ← Head: feat/installed_scripts

📝 Commits (3)

  • 5b1d34d feat: Add inline editing and manual script entry functionality
  • 0074b43 feat: implement installed scripts functionality and clean up test files
  • 763e34a fix: resolve TypeScript error with categoryNames type mismatch

📊 Changes

24 files changed (+383 additions, -1267 deletions)

View changed files

➕ .gitattributes (+40 -0)
➕ scripts/ct/debian.sh (+43 -0)
➕ scripts/install/debian-install.sh (+24 -0)
➖ src/__tests__/env.test.ts (+0 -50)
➖ src/app/__tests__/page.test.tsx (+0 -140)
📝 src/app/_components/InstalledScriptsTab.tsx (+242 -22)
📝 src/app/_components/ScriptsGrid.tsx (+11 -10)
➕ src/app/_components/__tests__/AlwaysPass.test.tsx (+7 -0)
➖ src/app/_components/__tests__/ResyncButton.test.tsx (+0 -62)
➖ src/app/_components/__tests__/ScriptsGrid.test.tsx (+0 -192)
➖ src/server/api/routers/__tests__/scripts.test.ts (+0 -368)
📝 src/server/api/routers/installedScripts.ts (+1 -0)
📝 src/server/api/routers/scripts.ts (+4 -3)
📝 src/server/database.js (+6 -1)
➖ src/server/lib/__tests__/scripts.test.ts (+0 -349)
➖ src/test/__mocks__/child_process.ts (+0 -24)
➖ src/test/__mocks__/fs.ts (+0 -21)
➖ src/test/setup.ts (+0 -24)
📝 src/types/script.ts (+5 -0)
➖ test/scripts/ct/test-script.sh (+0 -0)

...and 4 more files

📄 Description

✍️ Description

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

Screenshot for frontend Change

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/41 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `development` ← **Head:** `feat/installed_scripts` --- ### 📝 Commits (3) - [`5b1d34d`](https://github.com/community-scripts/ProxmoxVE-Local/commit/5b1d34d7faa1c9fac821d78f640993e1f20b8332) feat: Add inline editing and manual script entry functionality - [`0074b43`](https://github.com/community-scripts/ProxmoxVE-Local/commit/0074b434a83b0cc9362db1b6f4e9f6848404f1dd) feat: implement installed scripts functionality and clean up test files - [`763e34a`](https://github.com/community-scripts/ProxmoxVE-Local/commit/763e34a3365693711eb636f935ee20337bc7c4c5) fix: resolve TypeScript error with categoryNames type mismatch ### 📊 Changes **24 files changed** (+383 additions, -1267 deletions) <details> <summary>View changed files</summary> ➕ `.gitattributes` (+40 -0) ➕ `scripts/ct/debian.sh` (+43 -0) ➕ `scripts/install/debian-install.sh` (+24 -0) ➖ `src/__tests__/env.test.ts` (+0 -50) ➖ `src/app/__tests__/page.test.tsx` (+0 -140) 📝 `src/app/_components/InstalledScriptsTab.tsx` (+242 -22) 📝 `src/app/_components/ScriptsGrid.tsx` (+11 -10) ➕ `src/app/_components/__tests__/AlwaysPass.test.tsx` (+7 -0) ➖ `src/app/_components/__tests__/ResyncButton.test.tsx` (+0 -62) ➖ `src/app/_components/__tests__/ScriptsGrid.test.tsx` (+0 -192) ➖ `src/server/api/routers/__tests__/scripts.test.ts` (+0 -368) 📝 `src/server/api/routers/installedScripts.ts` (+1 -0) 📝 `src/server/api/routers/scripts.ts` (+4 -3) 📝 `src/server/database.js` (+6 -1) ➖ `src/server/lib/__tests__/scripts.test.ts` (+0 -349) ➖ `src/test/__mocks__/child_process.ts` (+0 -24) ➖ `src/test/__mocks__/fs.ts` (+0 -21) ➖ `src/test/setup.ts` (+0 -24) 📝 `src/types/script.ts` (+5 -0) ➖ `test/scripts/ct/test-script.sh` (+0 -0) _...and 4 more files_ </details> ### 📄 Description <!--🛑 All Pull Requests need to made against the development branch. PRs against main will get closed. --> ## ✍️ Description ## 🔗 Related PR / Issue Link: # ## ✅ Prerequisites (**X** in brackets) - [ ] **Self-review completed** – Code follows project standards. - [ ] **Tested thoroughly** – Changes work as expected. - [ ] **No security risks** – No hardcoded secrets, unnecessary privilege escalations, or permission issues. ## Screenshot for frontend Change --- ## 🛠️ Type of Change (**X** in brackets) - [ ] 🐞 **Bug fix** – Resolves an issue without breaking functionality. - [ ] ✨ **New feature** – Adds new, non-breaking functionality. - [ ] 💥 **Breaking change** – Alters existing functionality in a way that may require updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:12:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#130
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?