SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #39] [MERGED] feat: Add inline editing and manual script entry functionality #131

New Issue
Closed
opened 2025-11-20 04:12:59 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:12:59 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/39
Author: @michelroegl-brunner
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/installed_scripts

📝 Commits (7)

  • 8f9cae8 feat: improve button layout and UI organization (#35)
  • 4c435b7 Add category sidebar and filtering to scripts grid (#36)
  • 51bad28 Add reusable Badge component and refactor badge usage (#37)
  • 677729a Add advanced filtering and sorting to ScriptsGrid (#38)
  • 5b1d34d feat: Add inline editing and manual script entry functionality
  • 0074b43 feat: implement installed scripts functionality and clean up test files
  • 763e34a fix: resolve TypeScript error with categoryNames type mismatch

📊 Changes

98 files changed (+3207 additions, -2212 deletions)

View changed files

➕ .gitattributes (+40 -0)
➕ scripts/ct/debian.sh (+43 -0)
➕ scripts/install/debian-install.sh (+24 -0)
📝 scripts/json/2fauth.json (+1 -1)
📝 scripts/json/actualbudget.json (+1 -1)
📝 scripts/json/add-iptag.json (+1 -1)
📝 scripts/json/adguard.json (+2 -2)
📝 scripts/json/adventurelog.json (+1 -1)
📝 scripts/json/apache-guacamole.json (+1 -1)
📝 scripts/json/booklore.json (+1 -1)
📝 scripts/json/caddy.json (+13 -2)
📝 scripts/json/clean-lxcs.json (+1 -1)
📝 scripts/json/clean-orphaned-lvm.json (+1 -1)
📝 scripts/json/cloudflared.json (+1 -1)
📝 scripts/json/cockpit.json (+1 -1)
📝 scripts/json/cosmos.json (+6 -1)
📝 scripts/json/cron-update-lxcs.json (+2 -2)
📝 scripts/json/debian.json (+1 -1)
📝 scripts/json/elementsynapse.json (+4 -0)
📝 scripts/json/fstrim.json (+1 -1)

...and 78 more files

📄 Description

New Features

Inline Editing

  • Edit script names and container IDs directly in the table
  • Click 'Edit' button to enable inline editing mode
  • Save/Cancel buttons for each row
  • Real-time updates with proper validation

Manual Script Entry

  • Add pre-installed containers to the database
  • Form with script name, container ID, and server selection
  • Support for both local and SSH execution modes
  • Automatic status setting and validation

Improvements

  • Enhanced dark mode support with proper hover effects
  • Database updates to support script_name editing
  • API enhancements for better data management
  • Form validation and error handling

Use Cases

  • Track containers installed outside the system
  • Edit existing script entries for better organization
  • Manage pre-installed containers with full CRUD operations
  • Improved user experience with inline editing

Testing

  • All functionality tested and working
  • Dark mode compatibility verified
  • Form validation working correctly
  • Database operations successful

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/39 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/installed_scripts` --- ### 📝 Commits (7) - [`8f9cae8`](https://github.com/community-scripts/ProxmoxVE-Local/commit/8f9cae8b7551d0f4c9b8aa5e122dccb3ac8d67c7) feat: improve button layout and UI organization (#35) - [`4c435b7`](https://github.com/community-scripts/ProxmoxVE-Local/commit/4c435b77d2f8c7716a043557ceaea431b54c2cd1) Add category sidebar and filtering to scripts grid (#36) - [`51bad28`](https://github.com/community-scripts/ProxmoxVE-Local/commit/51bad284d431b146e6a19c7e9ae8c32b21a21c7a) Add reusable Badge component and refactor badge usage (#37) - [`677729a`](https://github.com/community-scripts/ProxmoxVE-Local/commit/677729ad9a7a32545a579735d028f3ca758ae633) Add advanced filtering and sorting to ScriptsGrid (#38) - [`5b1d34d`](https://github.com/community-scripts/ProxmoxVE-Local/commit/5b1d34d7faa1c9fac821d78f640993e1f20b8332) feat: Add inline editing and manual script entry functionality - [`0074b43`](https://github.com/community-scripts/ProxmoxVE-Local/commit/0074b434a83b0cc9362db1b6f4e9f6848404f1dd) feat: implement installed scripts functionality and clean up test files - [`763e34a`](https://github.com/community-scripts/ProxmoxVE-Local/commit/763e34a3365693711eb636f935ee20337bc7c4c5) fix: resolve TypeScript error with categoryNames type mismatch ### 📊 Changes **98 files changed** (+3207 additions, -2212 deletions) <details> <summary>View changed files</summary> ➕ `.gitattributes` (+40 -0) ➕ `scripts/ct/debian.sh` (+43 -0) ➕ `scripts/install/debian-install.sh` (+24 -0) 📝 `scripts/json/2fauth.json` (+1 -1) 📝 `scripts/json/actualbudget.json` (+1 -1) 📝 `scripts/json/add-iptag.json` (+1 -1) 📝 `scripts/json/adguard.json` (+2 -2) 📝 `scripts/json/adventurelog.json` (+1 -1) 📝 `scripts/json/apache-guacamole.json` (+1 -1) 📝 `scripts/json/booklore.json` (+1 -1) 📝 `scripts/json/caddy.json` (+13 -2) 📝 `scripts/json/clean-lxcs.json` (+1 -1) 📝 `scripts/json/clean-orphaned-lvm.json` (+1 -1) 📝 `scripts/json/cloudflared.json` (+1 -1) 📝 `scripts/json/cockpit.json` (+1 -1) 📝 `scripts/json/cosmos.json` (+6 -1) 📝 `scripts/json/cron-update-lxcs.json` (+2 -2) 📝 `scripts/json/debian.json` (+1 -1) 📝 `scripts/json/elementsynapse.json` (+4 -0) 📝 `scripts/json/fstrim.json` (+1 -1) _...and 78 more files_ </details> ### 📄 Description ## New Features ### Inline Editing - **Edit script names and container IDs directly in the table** - Click 'Edit' button to enable inline editing mode - Save/Cancel buttons for each row - Real-time updates with proper validation ### Manual Script Entry - **Add pre-installed containers to the database** - Form with script name, container ID, and server selection - Support for both local and SSH execution modes - Automatic status setting and validation ### Improvements - **Enhanced dark mode support** with proper hover effects - **Database updates** to support script_name editing - **API enhancements** for better data management - **Form validation** and error handling ## Use Cases - Track containers installed outside the system - Edit existing script entries for better organization - Manage pre-installed containers with full CRUD operations - Improved user experience with inline editing ## Testing - All functionality tested and working - Dark mode compatibility verified - Form validation working correctly - Database operations successful --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:12:59 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?