SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #68] [MERGED] chore: replace emojis with Lucide icons #158

New Issue
Closed
opened 2025-11-20 04:13:07 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:13:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/68
Author: @michelroegl-brunner
Created: 10/7/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: chore/replace_emojis

📝 Commits (1)

  • 32124bb chore: replace emojis with Lucide icons

📊 Changes

6 files changed (+93 additions, -69 deletions)

View changed files

📝 src/app/_components/FilterBar.tsx (+59 -46)
📝 src/app/_components/ScriptDetailModal.tsx (+3 -3)
📝 src/app/_components/Terminal.tsx (+13 -8)
📝 src/app/_components/VersionDisplay.tsx (+4 -3)
📝 src/app/api/trpc/[trpc]/route.ts (+1 -1)
📝 src/app/page.tsx (+13 -8)

📄 Description

Changes

This PR replaces all emojis with Lucide React icons for better accessibility, consistency, and maintainability.

Modified Files:

  • src/app/page.tsx - Main page header and tab navigation
  • src/app/_components/VersionDisplay.tsx - Version status indicator
  • src/app/_components/Terminal.tsx - Terminal controls and output prefixes
  • src/app/_components/FilterBar.tsx - Filter type icons and sort options
  • src/app/_components/ScriptDetailModal.tsx - Status messages
  • src/app/api/trpc/[trpc]/route.ts - Error logging

Icon Replacements:

  • 🚀 → <Rocket /> (main heading)
  • 📦 → <Package /> (LXC Container type, Available Scripts tab)
  • 💾 → <HardDrive /> (Downloaded Scripts tab)
  • 🗂️ → <FolderOpen /> (Installed Scripts tab)
  • 💻 → <Monitor /> (Virtual Machine type)
  • 🔧 → <Wrench /> (Add-on type)
  • 🖥️ → <Server /> (PVE Host type)
  • 📝 → <FileText /> (Sort by name)
  • 📅 → <Calendar /> (Sort by created date)
  • ✓/✅ → <Check /> (Success indicators)
  • ▶️ → <Play /> (Start button)
  • ⏹️ → <Square /> (Stop button)
  • 🗑️ → <Trash2 /> (Clear button)
  • ✕ → <X /> (Close button)
  • ❌ → [ERROR] text prefix (terminal/logs)

Benefits:

  • Better accessibility (screen readers can properly describe icons)
  • Consistent visual styling across the application
  • Tree-shakable icon imports (smaller bundle size)
  • Easier to customize (size, color, stroke width)
  • No font/encoding issues across different systems

All icons are properly sized and styled to match the existing design.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/68 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/7/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `chore/replace_emojis` --- ### 📝 Commits (1) - [`32124bb`](https://github.com/community-scripts/ProxmoxVE-Local/commit/32124bb8ec13d2f05b18805481ad4fe4a7d546c1) chore: replace emojis with Lucide icons ### 📊 Changes **6 files changed** (+93 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/FilterBar.tsx` (+59 -46) 📝 `src/app/_components/ScriptDetailModal.tsx` (+3 -3) 📝 `src/app/_components/Terminal.tsx` (+13 -8) 📝 `src/app/_components/VersionDisplay.tsx` (+4 -3) 📝 `src/app/api/trpc/[trpc]/route.ts` (+1 -1) 📝 `src/app/page.tsx` (+13 -8) </details> ### 📄 Description ## Changes This PR replaces all emojis with Lucide React icons for better accessibility, consistency, and maintainability. ### Modified Files: - `src/app/page.tsx` - Main page header and tab navigation - `src/app/_components/VersionDisplay.tsx` - Version status indicator - `src/app/_components/Terminal.tsx` - Terminal controls and output prefixes - `src/app/_components/FilterBar.tsx` - Filter type icons and sort options - `src/app/_components/ScriptDetailModal.tsx` - Status messages - `src/app/api/trpc/[trpc]/route.ts` - Error logging ### Icon Replacements: - 🚀 → `<Rocket />` (main heading) - 📦 → `<Package />` (LXC Container type, Available Scripts tab) - 💾 → `<HardDrive />` (Downloaded Scripts tab) - 🗂️ → `<FolderOpen />` (Installed Scripts tab) - 💻 → `<Monitor />` (Virtual Machine type) - 🔧 → `<Wrench />` (Add-on type) - 🖥️ → `<Server />` (PVE Host type) - 📝 → `<FileText />` (Sort by name) - 📅 → `<Calendar />` (Sort by created date) - ✓/✅ → `<Check />` (Success indicators) - ▶️ → `<Play />` (Start button) - ⏹️ → `<Square />` (Stop button) - 🗑️ → `<Trash2 />` (Clear button) - ✕ → `<X />` (Close button) - ❌ → [ERROR] text prefix (terminal/logs) ### Benefits: - Better accessibility (screen readers can properly describe icons) - Consistent visual styling across the application - Tree-shakable icon imports (smaller bundle size) - Easier to customize (size, color, stroke width) - No font/encoding issues across different systems All icons are properly sized and styled to match the existing design. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:13:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#158
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?