SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #80] [MERGED] feat: Add LXC auto-detection and cleanup of orphaned LXC #171

New Issue
Closed
opened 2025-11-20 04:13:20 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:13:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/80
Author: @michelroegl-brunner
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/detect_lxc

📝 Commits (2)

  • 90bbfac feat: Add auto-detect LXC containers feature with improved UX
  • a3e2108 feat: Add automatic cleanup and duplicate prevention for LXC auto-detection

📊 Changes

3 files changed (+594 additions, -32 deletions)

View changed files

➖ server.log (+0 -29)
📝 src/app/_components/InstalledScriptsTab.tsx (+250 -3)
📝 src/server/api/routers/installedScripts.ts (+344 -0)

📄 Description

🚀 Features Added

🔍 Auto-Detection Improvements

  • Duplicate Prevention: Auto-detection now checks for existing scripts before adding new ones
  • Smart Messaging: Shows detailed information about what was added vs skipped
  • Better UX: Replaced flashy blue messages with subtle slate color scheme

🧹 Automatic Cleanup

  • Orphaned Script Cleanup: Automatically removes scripts for containers that no longer exist
  • SSH Validation: Verifies container existence on remote servers before cleanup
  • Smart Status Messages: Informs users about what was cleaned up

🎨 UI/UX Improvements

  • Subtle Colors: Replaced bright blue with muted slate tones
  • Non-intrusive Feedback: Status messages auto-clear after appropriate time
  • Better Information: Clear indication of community-script tag requirement

🛠️ Technical Improvements

  • ESLint Compliance: Fixed all linting errors and warnings
  • Type Safety: Added proper type casting and error handling
  • Comprehensive Logging: Detailed server-side logging for debugging
  • Performance: Efficient duplicate checking and cleanup processes

🧪 Testing

  • ✅ Auto-detection works with duplicate prevention
  • ✅ Cleanup removes orphaned scripts correctly
  • ✅ UI messages are subtle and informative
  • ✅ All ESLint rules pass
  • ✅ TypeScript compilation successful

📝 Notes

  • Cleanup runs automatically when visiting Installed Scripts tab
  • Duplicate checking prevents database bloat
  • Status messages provide clear feedback without being intrusive
  • All changes maintain backward compatibility

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/80 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/detect_lxc` --- ### 📝 Commits (2) - [`90bbfac`](https://github.com/community-scripts/ProxmoxVE-Local/commit/90bbfac5f885f43a05580e3e2f3c14fd91567376) feat: Add auto-detect LXC containers feature with improved UX - [`a3e2108`](https://github.com/community-scripts/ProxmoxVE-Local/commit/a3e21082521f5ff791da66fc7a25abb5690be2b3) feat: Add automatic cleanup and duplicate prevention for LXC auto-detection ### 📊 Changes **3 files changed** (+594 additions, -32 deletions) <details> <summary>View changed files</summary> ➖ `server.log` (+0 -29) 📝 `src/app/_components/InstalledScriptsTab.tsx` (+250 -3) 📝 `src/server/api/routers/installedScripts.ts` (+344 -0) </details> ### 📄 Description ## 🚀 Features Added ### 🔍 Auto-Detection Improvements - **Duplicate Prevention**: Auto-detection now checks for existing scripts before adding new ones - **Smart Messaging**: Shows detailed information about what was added vs skipped - **Better UX**: Replaced flashy blue messages with subtle slate color scheme ### 🧹 Automatic Cleanup - **Orphaned Script Cleanup**: Automatically removes scripts for containers that no longer exist - **SSH Validation**: Verifies container existence on remote servers before cleanup - **Smart Status Messages**: Informs users about what was cleaned up ### 🎨 UI/UX Improvements - **Subtle Colors**: Replaced bright blue with muted slate tones - **Non-intrusive Feedback**: Status messages auto-clear after appropriate time - **Better Information**: Clear indication of community-script tag requirement ### 🛠️ Technical Improvements - **ESLint Compliance**: Fixed all linting errors and warnings - **Type Safety**: Added proper type casting and error handling - **Comprehensive Logging**: Detailed server-side logging for debugging - **Performance**: Efficient duplicate checking and cleanup processes ## 🧪 Testing - ✅ Auto-detection works with duplicate prevention - ✅ Cleanup removes orphaned scripts correctly - ✅ UI messages are subtle and informative - ✅ All ESLint rules pass - ✅ TypeScript compilation successful ## 📝 Notes - Cleanup runs automatically when visiting Installed Scripts tab - Duplicate checking prevents database bloat - Status messages provide clear feedback without being intrusive - All changes maintain backward compatibility --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:13:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#171
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?