SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #88] [MERGED] feat: Add sorting functionality to installed scripts table #176

New Issue
Closed
opened 2025-11-20 04:13:22 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:13:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/88
Author: @michelroegl-brunner
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/9/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/sorting_installedtab

📝 Commits (2)

  • b27f99a feat: Add sorting functionality to installed scripts table
  • cf4cf92 fix: Replace logical OR with nullish coalescing operator

📊 Changes

1 file changed (+123 additions, -24 deletions)

View changed files

📝 src/app/_components/InstalledScriptsTab.tsx (+123 -24)

📄 Description

Summary

This PR adds comprehensive sorting functionality to the installed scripts table in the InstalledScriptsTab component.

Changes Made

  • ✅ Added sortable columns for Script Name, Container ID, Server, Status, and Installation Date
  • ✅ Implemented clickable table headers with visual sort indicators (↑/↓)
  • ✅ Added ascending/descending toggle functionality
  • ✅ Maintained existing search and filter functionality
  • ✅ Set default sort by Script Name (ascending)
  • ✅ Added proper handling of null values in sorting logic

Features

  • Interactive Headers: Click any column header to sort by that column
  • Visual Feedback: Sort indicators show current sort field and direction
  • Smart Sorting: Case-insensitive text sorting, proper date sorting, null value handling
  • Seamless Integration: Works with existing search and filter functionality

Testing

  • All columns sort correctly in both ascending and descending order
  • Sorting works with filtered results
  • Null values are handled gracefully
  • UI provides clear visual feedback

Screenshots

The table headers now show sort indicators and are clickable for easy sorting by any column.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/88 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/9/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/sorting_installedtab` --- ### 📝 Commits (2) - [`b27f99a`](https://github.com/community-scripts/ProxmoxVE-Local/commit/b27f99a88e313cdd1295651aed4e24ba20ed1232) feat: Add sorting functionality to installed scripts table - [`cf4cf92`](https://github.com/community-scripts/ProxmoxVE-Local/commit/cf4cf9298e334b666b095dede64d950626674086) fix: Replace logical OR with nullish coalescing operator ### 📊 Changes **1 file changed** (+123 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/InstalledScriptsTab.tsx` (+123 -24) </details> ### 📄 Description ## Summary This PR adds comprehensive sorting functionality to the installed scripts table in the InstalledScriptsTab component. ## Changes Made - ✅ Added sortable columns for Script Name, Container ID, Server, Status, and Installation Date - ✅ Implemented clickable table headers with visual sort indicators (↑/↓) - ✅ Added ascending/descending toggle functionality - ✅ Maintained existing search and filter functionality - ✅ Set default sort by Script Name (ascending) - ✅ Added proper handling of null values in sorting logic ## Features - **Interactive Headers**: Click any column header to sort by that column - **Visual Feedback**: Sort indicators show current sort field and direction - **Smart Sorting**: Case-insensitive text sorting, proper date sorting, null value handling - **Seamless Integration**: Works with existing search and filter functionality ## Testing - All columns sort correctly in both ascending and descending order - Sorting works with filtered results - Null values are handled gracefully - UI provides clear visual feedback ## Screenshots The table headers now show sort indicators and are clickable for easy sorting by any column. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:13:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#176
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?