SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #102] [MERGED] feat: auto-select single server and remove local execution #187

New Issue
Closed
opened 2025-11-20 04:13:25 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:13:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/102
Author: @michelroegl-brunner
Created: 10/10/2025
Status: ✅ Merged
Merged: 10/10/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/simplify_ssh_execution

📝 Commits (2)

  • 1668716 feat: auto-select single server and remove local execution
  • aaa34f9 fix: remove debug messages from WebSocket output

📊 Changes

3 files changed (+92 additions, -117 deletions)

View changed files

📝 src/app/_components/ExecutionModeModal.tsx (+92 -109)
📝 src/app/_components/Terminal.tsx (+0 -1)
📝 src/server/api/routers/installedScripts.ts (+0 -7)

📄 Description

Overview

This PR implements automatic server selection when only one server is configured and removes the local execution option entirely.

Changes Made

✨ New Features

  • Auto-select single server: When exactly one server is configured, the execution modal is bypassed and the script runs immediately
  • Server settings integration: Added button to open server settings directly from execution modal when no servers are configured
  • Auto-refresh: Server list automatically refreshes when settings modal closes

🔧 Improvements

  • Removed local execution: All scripts now execute via SSH only, simplifying the execution flow
  • Updated modal title: Changed from 'Execution Mode' to 'Select Server' to better reflect functionality
  • Streamlined UI: Removed execution mode selection, focusing only on server selection

🐛 Bug Fixes

  • Cleaned up debug messages that were appearing in terminal output

Behavior Changes

  • 0 servers: Modal shows with message that servers are required + 'Open Server Settings' button
  • 1 server: Modal is skipped entirely, script immediately starts on that server via SSH
  • 2+ servers: Modal shows with server selection dropdown, user selects which server to use

Testing

  • Single server setup - auto-execution works
  • Multiple servers - manual selection works
  • No servers - settings button appears
  • Settings integration - server list refreshes after adding servers

This provides a much smoother user experience, especially for single-server setups, while maintaining full functionality for multi-server environments.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/102 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/10/2025 **Status:** ✅ Merged **Merged:** 10/10/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/simplify_ssh_execution` --- ### 📝 Commits (2) - [`1668716`](https://github.com/community-scripts/ProxmoxVE-Local/commit/16687167fba38fc4db83e857933dafea4075f298) feat: auto-select single server and remove local execution - [`aaa34f9`](https://github.com/community-scripts/ProxmoxVE-Local/commit/aaa34f9ccc88d99afe61eea8aaf915419807586e) fix: remove debug messages from WebSocket output ### 📊 Changes **3 files changed** (+92 additions, -117 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/ExecutionModeModal.tsx` (+92 -109) 📝 `src/app/_components/Terminal.tsx` (+0 -1) 📝 `src/server/api/routers/installedScripts.ts` (+0 -7) </details> ### 📄 Description ## Overview This PR implements automatic server selection when only one server is configured and removes the local execution option entirely. ## Changes Made ### ✨ New Features - **Auto-select single server**: When exactly one server is configured, the execution modal is bypassed and the script runs immediately - **Server settings integration**: Added button to open server settings directly from execution modal when no servers are configured - **Auto-refresh**: Server list automatically refreshes when settings modal closes ### 🔧 Improvements - **Removed local execution**: All scripts now execute via SSH only, simplifying the execution flow - **Updated modal title**: Changed from 'Execution Mode' to 'Select Server' to better reflect functionality - **Streamlined UI**: Removed execution mode selection, focusing only on server selection ### 🐛 Bug Fixes - Cleaned up debug messages that were appearing in terminal output ## Behavior Changes - **0 servers**: Modal shows with message that servers are required + 'Open Server Settings' button - **1 server**: Modal is skipped entirely, script immediately starts on that server via SSH - **2+ servers**: Modal shows with server selection dropdown, user selects which server to use ## Testing - [x] Single server setup - auto-execution works - [x] Multiple servers - manual selection works - [x] No servers - settings button appears - [x] Settings integration - server list refreshes after adding servers This provides a much smoother user experience, especially for single-server setups, while maintaining full functionality for multi-server environments. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:13:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#187
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?