SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-05-14 11:52:08 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #143] [MERGED] Fix script counter inconsistencies #210

New Issue
Closed
opened 2025-11-20 04:13:32 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:13:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/143
Author: @michelroegl-brunner
Created: 10/14/2025
Status: ✅ Merged
Merged: 10/14/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/counters

📝 Commits (1)

  • e82a832 fix: correct script counters to use deduplicated counts

📊 Changes

1 file changed (+31 additions, -4 deletions)

View changed files

📝 src/app/page.tsx (+31 -4)

📄 Description

Problem

The script counters in the tab headers don't match the actual counts displayed in the UI:

  • Available Scripts tab: Shows 408 in header, but CategorySidebar shows 403/394
  • Downloaded Scripts tab: Shows 395 in header, but CategorySidebar shows 394

Root Cause

The main page.tsx counter logic doesn't deduplicate scripts, while the individual tab components do. This creates confusion for users who see different numbers in the tab headers versus the content areas.

Solution

Changes Made

  1. Fixed Available Scripts Counter (src/app/page.tsx lines 73-88):

    • Now deduplicates scripts using Map by slug before counting
    • Matches the logic used in ScriptsGrid.tsx
    • Will show 403 instead of 408 (removing 5 duplicates)

  2. Fixed Downloaded Scripts Counter (src/app/page.tsx lines 90-117):

    • First deduplicates GitHub scripts using Map by slug
    • Then filters for scripts that have local versions
    • Matches the logic used in DownloadedScriptsTab.tsx
    • Will show consistent count with CategorySidebar

Deduplication Logic

  • Use slug as the unique identifier
  • Filter out scripts without valid name/slug
  • Use a Map to store only the first occurrence of each slug

Result

  • Tab header counters now match the actual displayed content
  • Eliminates user confusion from inconsistent numbers
  • All counters use the same deduplication logic across components

Testing

  • Available Scripts counter now shows deduplicated count
  • Downloaded Scripts counter now shows deduplicated count
  • All counters match between tab headers and displayed content
  • No linting errors introduced

Fixes the counter discrepancies shown in the UI where users see different numbers in tab headers versus the actual content areas.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/143 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/14/2025 **Status:** ✅ Merged **Merged:** 10/14/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/counters` --- ### 📝 Commits (1) - [`e82a832`](https://github.com/community-scripts/ProxmoxVE-Local/commit/e82a832ba72319407d6756e9cba006be7bab549e) fix: correct script counters to use deduplicated counts ### 📊 Changes **1 file changed** (+31 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/app/page.tsx` (+31 -4) </details> ### 📄 Description ## Problem The script counters in the tab headers don't match the actual counts displayed in the UI: - **Available Scripts tab**: Shows 408 in header, but CategorySidebar shows 403/394 - **Downloaded Scripts tab**: Shows 395 in header, but CategorySidebar shows 394 ## Root Cause The main `page.tsx` counter logic doesn't deduplicate scripts, while the individual tab components do. This creates confusion for users who see different numbers in the tab headers versus the content areas. ## Solution ### Changes Made 1. **Fixed Available Scripts Counter** (`src/app/page.tsx` lines 73-88): - Now deduplicates scripts using Map by `slug` before counting - Matches the logic used in `ScriptsGrid.tsx` - Will show 403 instead of 408 (removing 5 duplicates) 2. **Fixed Downloaded Scripts Counter** (`src/app/page.tsx` lines 90-117): - First deduplicates GitHub scripts using Map by `slug` - Then filters for scripts that have local versions - Matches the logic used in `DownloadedScriptsTab.tsx` - Will show consistent count with CategorySidebar ### Deduplication Logic - Use `slug` as the unique identifier - Filter out scripts without valid name/slug - Use a Map to store only the first occurrence of each slug ## Result - Tab header counters now match the actual displayed content - Eliminates user confusion from inconsistent numbers - All counters use the same deduplication logic across components ## Testing - [x] Available Scripts counter now shows deduplicated count - [x] Downloaded Scripts counter now shows deduplicated count - [x] All counters match between tab headers and displayed content - [x] No linting errors introduced Fixes the counter discrepancies shown in the UI where users see different numbers in tab headers versus the actual content areas. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:13:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#210
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?