SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #201] [MERGED] fix: harden orphan cleanup to avoid false deletions #248

New Issue
Closed
opened 2025-11-20 04:13:44 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:13:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/201
Author: @michelroegl-brunner
Created: 10/20/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/orphan-cleanup-race

📝 Commits (1)

  • e4de9cc fix(installed-scripts): prevent false orphan deletions by awaiting SSH command completion and parsing combined output; add 15s timeout and warnings for diagnostics

📊 Changes

1 file changed (+29 additions, -6 deletions)

View changed files

📝 src/server/api/routers/installedScripts.ts (+29 -6)

📄 Description

This PR fixes intermittent false orphan removals by:

  • Awaiting SSH command completion and parsing combined output
  • Adding a 15s timeout and warnings for diagnostics

This should prevent erroneously removing installed scripts when the LXC exists but transient SSH output timing caused a false negative.

Fixes: intermittent cleanup misclassification observed after auto-detect.

Label: fix

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/201 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/20/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/orphan-cleanup-race` --- ### 📝 Commits (1) - [`e4de9cc`](https://github.com/community-scripts/ProxmoxVE-Local/commit/e4de9cc8f62845357b45b496866a766ea4bdc419) fix(installed-scripts): prevent false orphan deletions by awaiting SSH command completion and parsing combined output; add 15s timeout and warnings for diagnostics ### 📊 Changes **1 file changed** (+29 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/server/api/routers/installedScripts.ts` (+29 -6) </details> ### 📄 Description This PR fixes intermittent false orphan removals by: - Awaiting SSH command completion and parsing combined output - Adding a 15s timeout and warnings for diagnostics This should prevent erroneously removing installed scripts when the LXC exists but transient SSH output timing caused a false negative. Fixes: intermittent cleanup misclassification observed after auto-detect. Label: fix --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:13:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#248
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?