SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #205] [MERGED] fix/184 script filtering count discrepancy #254

New Issue
Closed
opened 2025-11-20 04:13:45 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:13:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/205
Author: @michelroegl-brunner
Created: 10/20/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/184

📝 Commits (1)

  • 9ad9440 fix: resolve script filtering count discrepancy

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 src/app/_components/DownloadedScriptsTab.tsx (+5 -1)
📝 src/app/_components/ScriptsGrid.tsx (+5 -1)

📄 Description

Problem

When filtering downloaded scripts by type with all 4 categories selected, the count showed '398 of 399 scripts' instead of '399 of 399 scripts'.

Root Cause

The TurnKey script has type 'turnkey' which doesn't match any of the four filter categories (ct, vm, addon, pve), causing it to be excluded from filtered results even when all categories are selected.

Solution

  • Map 'turnkey' script type to 'ct' (LXC Container) category in filtering logic
  • Applied fix to both DownloadedScriptsTab and ScriptsGrid components
  • TurnKey script is LXC-related so mapping to 'ct' is appropriate

Testing

  • Verified only one script has non-standard type ('turnkey')
  • Tested filtering logic to confirm fix works correctly
  • Now shows correct count: '399 of 399 scripts' when all types selected

Fixes the filtering count discrepancy issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/205 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 10/20/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/184` --- ### 📝 Commits (1) - [`9ad9440`](https://github.com/community-scripts/ProxmoxVE-Local/commit/9ad9440b0faf4547fca37be8ea74f9f9558de445) fix: resolve script filtering count discrepancy ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/DownloadedScriptsTab.tsx` (+5 -1) 📝 `src/app/_components/ScriptsGrid.tsx` (+5 -1) </details> ### 📄 Description ## Problem When filtering downloaded scripts by type with all 4 categories selected, the count showed '398 of 399 scripts' instead of '399 of 399 scripts'. ## Root Cause The TurnKey script has type 'turnkey' which doesn't match any of the four filter categories (ct, vm, addon, pve), causing it to be excluded from filtered results even when all categories are selected. ## Solution - Map 'turnkey' script type to 'ct' (LXC Container) category in filtering logic - Applied fix to both DownloadedScriptsTab and ScriptsGrid components - TurnKey script is LXC-related so mapping to 'ct' is appropriate ## Testing - Verified only one script has non-standard type ('turnkey') - Tested filtering logic to confirm fix works correctly - Now shows correct count: '399 of 399 scripts' when all types selected Fixes the filtering count discrepancy issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:13:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#254
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?