SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #282] [MERGED] Fix x button vertical centering in filter scripts search bar #309

New Issue
Open
opened 2025-11-20 04:14:04 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/282
Author: @michelroegl-brunner
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/273

📝 Commits (1)

  • e460a05 Fix x button vertical centering in filter scripts search bar

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 src/app/_components/FilterBar.tsx (+1 -2)

📄 Description

Changes

  • Fixed vertical centering of the x (clear) button in the filter scripts search bar
  • Removed size='icon' constraint that was limiting button height to 36px
  • Changed positioning to use inset-y-0 with h-full to match the full input field height
  • Added flex items-center justify-center for proper icon centering within the button

Fixes

  • Button now properly centers vertically within the input field
  • Hover background now matches the full input height in both light and dark themes
  • Resolves issue where hover background appeared shorter than the input field

Testing

  • Verified button is vertically centered
  • Verified hover state background matches input height in both themes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/282 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/273` --- ### 📝 Commits (1) - [`e460a05`](https://github.com/community-scripts/ProxmoxVE-Local/commit/e460a05f9114526567a00c11c733e150f649cc1b) Fix x button vertical centering in filter scripts search bar ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/FilterBar.tsx` (+1 -2) </details> ### 📄 Description ## Changes - Fixed vertical centering of the x (clear) button in the filter scripts search bar - Removed `size='icon'` constraint that was limiting button height to 36px - Changed positioning to use `inset-y-0` with `h-full` to match the full input field height - Added `flex items-center justify-center` for proper icon centering within the button ## Fixes - Button now properly centers vertically within the input field - Hover background now matches the full input height in both light and dark themes - Resolves issue where hover background appeared shorter than the input field ## Testing - Verified button is vertically centered - Verified hover state background matches input height in both themes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:14:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#309
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?