SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #283] [MERGED] feat: Add delete script functionality #312

New Issue
Closed
opened 2025-11-20 04:14:04 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/283
Author: @michelroegl-brunner
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/delete_downloaded_scripts

📝 Commits (1)

  • 82d14f1 Add delete script functionality

📊 Changes

4 files changed (+223 additions, -2 deletions)

View changed files

📝 src/app/_components/ScriptDetailModal.tsx (+91 -0)
📝 src/server/api/routers/scripts.ts (+28 -0)
📝 src/server/services/scriptDownloader.js (+52 -1)
📝 src/server/services/scriptDownloader.ts (+52 -1)

📄 Description

This PR adds the ability to delete downloaded script files from the ScriptDetailModal.

Changes

  • Added deleteScript method to ScriptDownloaderService (both TypeScript and JavaScript versions)
  • Added deleteScript API endpoint to scripts router
  • Added delete button to ScriptDetailModal with confirmation modal
  • Uses ConfirmationModal component instead of plain window.confirm
  • Delete button only shows when script files exist locally
  • Includes proper error handling and success/error messages

Testing

  • Delete button appears when script files are downloaded
  • Confirmation modal appears when clicking delete
  • Script files are successfully deleted
  • UI updates after deletion to reflect file removal

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/283 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/delete_downloaded_scripts` --- ### 📝 Commits (1) - [`82d14f1`](https://github.com/community-scripts/ProxmoxVE-Local/commit/82d14f1fb1451cbc2be1633ce5f6a43937b0dbd2) Add delete script functionality ### 📊 Changes **4 files changed** (+223 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/ScriptDetailModal.tsx` (+91 -0) 📝 `src/server/api/routers/scripts.ts` (+28 -0) 📝 `src/server/services/scriptDownloader.js` (+52 -1) 📝 `src/server/services/scriptDownloader.ts` (+52 -1) </details> ### 📄 Description This PR adds the ability to delete downloaded script files from the ScriptDetailModal. ## Changes - Added `deleteScript` method to ScriptDownloaderService (both TypeScript and JavaScript versions) - Added `deleteScript` API endpoint to scripts router - Added delete button to ScriptDetailModal with confirmation modal - Uses ConfirmationModal component instead of plain window.confirm - Delete button only shows when script files exist locally - Includes proper error handling and success/error messages ## Testing - Delete button appears when script files are downloaded - Confirmation modal appears when clicking delete - Script files are successfully deleted - UI updates after deletion to reflect file removal --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:14:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#312
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?