SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #282] Fix x button vertical centering in filter scripts search bar #313

New Issue
Closed
opened 2025-11-20 04:14:04 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:04 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/community-scripts/ProxmoxVE-Local/pull/282

State: closed
Merged: Yes

Changes

  • Fixed vertical centering of the x (clear) button in the filter scripts search bar
  • Removed size='icon' constraint that was limiting button height to 36px
  • Changed positioning to use inset-y-0 with h-full to match the full input field height
  • Added flex items-center justify-center for proper icon centering within the button

Fixes

  • Button now properly centers vertically within the input field
  • Hover background now matches the full input height in both light and dark themes
  • Resolves issue where hover background appeared shorter than the input field

Testing

  • Verified button is vertically centered
  • Verified hover state background matches input height in both themes
**Original Pull Request:** https://github.com/community-scripts/ProxmoxVE-Local/pull/282 **State:** closed **Merged:** Yes --- ## Changes - Fixed vertical centering of the x (clear) button in the filter scripts search bar - Removed `size='icon'` constraint that was limiting button height to 36px - Changed positioning to use `inset-y-0` with `h-full` to match the full input field height - Added `flex items-center justify-center` for proper icon centering within the button ## Fixes - Button now properly centers vertically within the input field - Hover background now matches the full input height in both light and dark themes - Resolves issue where hover background appeared shorter than the input field ## Testing - Verified button is vertically centered - Verified hover state background matches input height in both themes
saavagebueno added the pull-request label 2025-11-20 04:14:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#313
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?