SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #285] [MERGED] feat: Add support for FQDN, IPv4, and IPv6 addresses in server settings #318

New Issue
Open
opened 2025-11-20 04:14:05 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:05 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/285
Author: @michelroegl-brunner
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/allow_fdqn_and_ipv6_for_servers

📝 Commits (1)

  • 596887d feat: Add support for FQDN, IPv4, and IPv6 addresses in server settings

📊 Changes

1 file changed (+49 additions, -7 deletions)

View changed files

📝 src/app/_components/ServerForm.tsx (+49 -7)

📄 Description

Summary

This PR adds support for FQDN (Fully Qualified Domain Names), IPv4, and IPv6 addresses in the server settings modal.

Changes

  • Replace IPv4-only validation with comprehensive address validation function
  • Support IPv4 addresses (e.g., 192.168.1.1)
  • Support IPv6 addresses including compressed format (e.g., ::1, 2001:db8::1)
  • Support FQDN/hostnames (e.g., server.example.com, localhost)
  • Update UI label from 'IP Address' to 'Host/IP Address'
  • Update placeholder text with examples for all supported formats
  • Update error messages to reflect new validation capabilities

Validation

The validation function now checks for:

  1. IPv4 addresses using RFC-compliant regex
  2. IPv6 addresses (full format, compressed format, and IPv4-mapped)
  3. FQDN/hostnames per RFC 1123 (max 253 chars, labels max 63 chars)

Testing

  • IPv4 addresses validate correctly
  • IPv6 addresses validate correctly (including compressed format)
  • FQDN/hostnames validate correctly
  • Invalid addresses show appropriate error messages
  • UI labels and placeholders updated correctly

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/285 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/allow_fdqn_and_ipv6_for_servers` --- ### 📝 Commits (1) - [`596887d`](https://github.com/community-scripts/ProxmoxVE-Local/commit/596887d19ce149a4d75edaa1c154dddaf177a56a) feat: Add support for FQDN, IPv4, and IPv6 addresses in server settings ### 📊 Changes **1 file changed** (+49 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/ServerForm.tsx` (+49 -7) </details> ### 📄 Description ## Summary This PR adds support for FQDN (Fully Qualified Domain Names), IPv4, and IPv6 addresses in the server settings modal. ## Changes - Replace IPv4-only validation with comprehensive address validation function - Support IPv4 addresses (e.g., 192.168.1.1) - Support IPv6 addresses including compressed format (e.g., ::1, 2001:db8::1) - Support FQDN/hostnames (e.g., server.example.com, localhost) - Update UI label from 'IP Address' to 'Host/IP Address' - Update placeholder text with examples for all supported formats - Update error messages to reflect new validation capabilities ## Validation The validation function now checks for: 1. IPv4 addresses using RFC-compliant regex 2. IPv6 addresses (full format, compressed format, and IPv4-mapped) 3. FQDN/hostnames per RFC 1123 (max 253 chars, labels max 63 chars) ## Testing - [x] IPv4 addresses validate correctly - [x] IPv6 addresses validate correctly (including compressed format) - [x] FQDN/hostnames validate correctly - [x] Invalid addresses show appropriate error messages - [x] UI labels and placeholders updated correctly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:14:05 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?