SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-05-10 09:51:41 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #287] [MERGED] feat: Add alpine variant support for LXC scripts #321

New Issue
Closed
opened 2025-11-20 04:14:06 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/287
Author: @michelroegl-brunner
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @michelroegl-brunner

Base: main ← Head: feat/250_chose_version

📝 Commits (2)

  • 6ad18e1 feat: Add alpine variant support for LXC scripts
  • cf3f9a5 feat: Add version toggle in TextViewer for default/alpine variants

📊 Changes

4 files changed (+523 additions, -56 deletions)

View changed files

📝 src/app/_components/ScriptDetailModal.tsx (+42 -1)
➕ src/app/_components/ScriptVersionModal.tsx (+210 -0)
📝 src/app/_components/TextViewer.tsx (+196 -55)
📝 src/server/services/scriptDownloader.js (+75 -0)

📄 Description

Summary

This PR adds support for downloading and selecting between default and alpine variants of LXC scripts.

Changes

  • Download alpine install scripts: When a script has an alpine variant, the system now downloads alpine-{slug}-install.sh from the install/ directory
  • Version selection modal: New ScriptVersionModal component allows users to choose between default and alpine versions before server selection
  • Updated installation flow: ScriptDetailModal now shows version selection when multiple variants exist, then proceeds to server selection
  • Script execution: Updated to use the selected version type to find and execute the correct script path

Technical Details

  • Updated scriptDownloader.js to download alpine install scripts when alpine CT variants exist
  • Created ScriptVersionModal.tsx component with resource requirements display
  • Modified ScriptDetailModal.tsx to integrate version selection into the installation flow
  • Script execution now uses the selected version type to determine which script to run

Testing

  • Tested with adguard script which has both default and alpine variants
  • Verified alpine install scripts are downloaded correctly
  • Confirmed version selection modal appears when multiple variants exist
  • Verified script execution uses the correct version based on user selection

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/287 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `feat/250_chose_version` --- ### 📝 Commits (2) - [`6ad18e1`](https://github.com/community-scripts/ProxmoxVE-Local/commit/6ad18e185e4d24742055038c0dec5898eefdc4f3) feat: Add alpine variant support for LXC scripts - [`cf3f9a5`](https://github.com/community-scripts/ProxmoxVE-Local/commit/cf3f9a54798802a650500202c13c756ce86892d3) feat: Add version toggle in TextViewer for default/alpine variants ### 📊 Changes **4 files changed** (+523 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/ScriptDetailModal.tsx` (+42 -1) ➕ `src/app/_components/ScriptVersionModal.tsx` (+210 -0) 📝 `src/app/_components/TextViewer.tsx` (+196 -55) 📝 `src/server/services/scriptDownloader.js` (+75 -0) </details> ### 📄 Description ## Summary This PR adds support for downloading and selecting between default and alpine variants of LXC scripts. ## Changes - **Download alpine install scripts**: When a script has an alpine variant, the system now downloads `alpine-{slug}-install.sh` from the `install/` directory - **Version selection modal**: New `ScriptVersionModal` component allows users to choose between default and alpine versions before server selection - **Updated installation flow**: `ScriptDetailModal` now shows version selection when multiple variants exist, then proceeds to server selection - **Script execution**: Updated to use the selected version type to find and execute the correct script path ## Technical Details - Updated `scriptDownloader.js` to download alpine install scripts when alpine CT variants exist - Created `ScriptVersionModal.tsx` component with resource requirements display - Modified `ScriptDetailModal.tsx` to integrate version selection into the installation flow - Script execution now uses the selected version type to determine which script to run ## Testing - Tested with adguard script which has both default and alpine variants - Verified alpine install scripts are downloaded correctly - Confirmed version selection modal appears when multiple variants exist - Verified script execution uses the correct version based on user selection --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:14:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#321
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?