SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #297] [MERGED] Fix auth cookie secure flag for HTTP in production #325

New Issue
Open
opened 2025-11-20 04:14:07 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/297
Author: @michelroegl-brunner
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/auth

📝 Commits (2)

  • 86056c9 Fix auth loop
  • 8c27eac Fix auth cookie secure flag for HTTP in production

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 src/app/_components/AuthProvider.tsx (+6 -1)
📝 src/app/api/auth/login/route.ts (+4 -1)

📄 Description

Problem

Authentication was failing in production mode when accessing the app over HTTP. Users would log in successfully but then be redirected back to the login page.

Root Cause

The cookie flag was set based on , which meant cookies required HTTPS even when the app was accessed over HTTP. Browsers would not set or send the cookie, causing authentication to fail.

Solution

  • Changed cookie flag to check the actual request protocol () instead of
  • Cookies now work correctly in both HTTP and HTTPS environments
  • Maintains security by still using when actually over HTTPS

Changes

  • Modified to detect request protocol
  • Added delay in to ensure cookie is available before verification (already committed)

Testing

  • ✅ Works in development mode (npm run dev)
  • ✅ Works in production mode over HTTP (npm start)
  • ✅ Maintains security for HTTPS connections

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/297 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/auth` --- ### 📝 Commits (2) - [`86056c9`](https://github.com/community-scripts/ProxmoxVE-Local/commit/86056c984d35be07e3cf47ed4549ba9c686c843d) Fix auth loop - [`8c27eac`](https://github.com/community-scripts/ProxmoxVE-Local/commit/8c27eacff75abe08d15caad8ece13ed365653c97) Fix auth cookie secure flag for HTTP in production ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/AuthProvider.tsx` (+6 -1) 📝 `src/app/api/auth/login/route.ts` (+4 -1) </details> ### 📄 Description ## Problem Authentication was failing in production mode when accessing the app over HTTP. Users would log in successfully but then be redirected back to the login page. ## Root Cause The cookie flag was set based on , which meant cookies required HTTPS even when the app was accessed over HTTP. Browsers would not set or send the cookie, causing authentication to fail. ## Solution - Changed cookie flag to check the actual request protocol () instead of - Cookies now work correctly in both HTTP and HTTPS environments - Maintains security by still using when actually over HTTPS ## Changes - Modified to detect request protocol - Added delay in to ensure cookie is available before verification (already committed) ## Testing - ✅ Works in development mode (npm run dev) - ✅ Works in production mode over HTTP (npm start) - ✅ Maintains security for HTTPS connections --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:14:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?