SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-06-10 09:02:42 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

[PR #304] [MERGED] fix: support IPv6 link-local addresses with zone identifiers #338

New Issue
Closed
opened 2025-11-20 04:14:11 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 04:14:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE-Local/pull/304
Author: @michelroegl-brunner
Created: 11/10/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @michelroegl-brunner

Base: main ← Head: fix/275

📝 Commits (1)

  • 03fd7bd fix: support IPv6 link-local addresses with zone identifiers in server settings

📊 Changes

1 file changed (+15 additions, -3 deletions)

View changed files

📝 src/app/_components/ServerForm.tsx (+15 -3)

📄 Description

Description

This PR fixes the server settings modal to accept IPv6 link-local addresses with zone identifiers (e.g., fe80::be24:11ff:fe28:30db%eth0).

Changes

  • Updated validateServerAddress function to handle IPv6 addresses with zone identifiers
  • Added validation for zone identifier (interface name like eth0, wlan0, etc.)
  • Updated placeholder text to include link-local address example

Testing

Tested with the following address formats:

  • ✅ IPv4: 192.168.0.254
  • ✅ Hostname: pve, pve.example.com
  • ✅ IPv6: 2a00:ae00:e2:7600:bb24:119f:fe2c:30db
  • ✅ IPv6 link-local with zone: fe80::be24:11ff:fe28:30db%eth0

Fixes the issue where link-local addresses were being rejected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE-Local/pull/304 **Author:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Created:** 11/10/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@michelroegl-brunner](https://github.com/michelroegl-brunner) **Base:** `main` ← **Head:** `fix/275` --- ### 📝 Commits (1) - [`03fd7bd`](https://github.com/community-scripts/ProxmoxVE-Local/commit/03fd7bd1e25f43d4cb4774c4549f5d0114ade013) fix: support IPv6 link-local addresses with zone identifiers in server settings ### 📊 Changes **1 file changed** (+15 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/app/_components/ServerForm.tsx` (+15 -3) </details> ### 📄 Description ## Description This PR fixes the server settings modal to accept IPv6 link-local addresses with zone identifiers (e.g., `fe80::be24:11ff:fe28:30db%eth0`). ## Changes - Updated `validateServerAddress` function to handle IPv6 addresses with zone identifiers - Added validation for zone identifier (interface name like eth0, wlan0, etc.) - Updated placeholder text to include link-local address example ## Testing Tested with the following address formats: - ✅ IPv4: `192.168.0.254` - ✅ Hostname: `pve`, `pve.example.com` - ✅ IPv6: `2a00:ae00:e2:7600:bb24:119f:fe2c:30db` - ✅ IPv6 link-local with zone: `fe80::be24:11ff:fe28:30db%eth0` Fixes the issue where link-local addresses were being rejected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 04:14:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#338
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?