SVI/ProxmoxVE-Local
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE-Local.git synced 2026-03-31 06:23:54 -04:00
Code Issues 56 Packages Projects Releases 7 Wiki Activity

Login Sessions #83

New Issue
Closed
opened 2025-11-20 04:12:27 -05:00 by saavagebueno · 3 comments
saavagebueno commented 2025-11-20 04:12:27 -05:00
Owner
Copy Link

Originally created by @gdeeble on GitHub (Oct 26, 2025).

🌟 Briefly describe the feature

Add the ability to set a timeout on the login session

📝 Detailed description

Right now, logins are 1 time use and you have to login each time you refresh. This can be cumbersome if you're messing around and refresh the page or something triggers a refresh. With session cookies and stuff, a user can refresh a multiple times and not be presented with the login screen but back to where they left off.

💡 Why is this useful?

This would be a quality of life improvement as refreshing the page can be frustrating as you have to login again. By adding it, the user could login, navigate and refresh the page and it should allow them back in without logging in again.

Originally created by @gdeeble on GitHub (Oct 26, 2025). ### 🌟 Briefly describe the feature Add the ability to set a timeout on the login session ### 📝 Detailed description Right now, logins are 1 time use and you have to login each time you refresh. This can be cumbersome if you're messing around and refresh the page or something triggers a refresh. With session cookies and stuff, a user can refresh a multiple times and not be presented with the login screen but back to where they left off. ### 💡 Why is this useful? This would be a quality of life improvement as refreshing the page can be frustrating as you have to login again. By adding it, the user could login, navigate and refresh the page and it should allow them back in without logging in again.
saavagebueno added the enhancement label 2025-11-20 04:12:27 -05:00
saavagebueno commented 2025-11-20 04:12:27 -05:00
Author
Owner
Copy Link

@gdeeble commented on GitHub (Oct 26, 2025):

If I were going to do this, I would definitely look at cookies to do it, but would also potentially look at multiple logins, roles, timeouts(1 time use vs x minutes), and implement LDAP/OIDC for integration. I know this is more for community use than enterprise style set ups but would allow flexibility.

I am going to say the level of effort though for the cookie should be low, but the expansion of capability very high, but if someone is willing to take a stab at it, I have absolutely no issue testing the code and providing reports. :)

@gdeeble commented on GitHub (Oct 26, 2025): If I were going to do this, I would definitely look at cookies to do it, but would also potentially look at multiple logins, roles, timeouts(1 time use vs x minutes), and implement LDAP/OIDC for integration. I know this is more for community use than enterprise style set ups but would allow flexibility. I am going to say the level of effort though for the cookie should be low, but the expansion of capability very high, but if someone is willing to take a stab at it, I have absolutely no issue testing the code and providing reports. :)
saavagebueno commented 2025-11-20 04:12:27 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Oct 26, 2025):

Thanks for the report, this is a bug and should not happen, i take a look as soon as i can.

@gdeeble i would be up to add oidc, i note that down.

@michelroegl-brunner commented on GitHub (Oct 26, 2025): Thanks for the report, this is a bug and should not happen, i take a look as soon as i can. @gdeeble i would be up to add oidc, i note that down.
saavagebueno commented 2025-11-20 04:12:27 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Nov 7, 2025):

The ldap, oidc will be added in the future. For now i dont see the need for extensive user roles or implementations. Or at least i dont really know what would be needed here. Maybe you can create a new feature request what you imagine would be usefull here.
@gdeeble

@michelroegl-brunner commented on GitHub (Nov 7, 2025): The ldap, oidc will be added in the future. For now i dont see the need for extensive user roles or implementations. Or at least i dont really know what would be needed here. Maybe you can create a new feature request what you imagine would be usefull here. @gdeeble
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
enhancement
feature
in progress
pull-request
Mirrored from GitHub Pull Request
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE-Local#83
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?