SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-28 16:52:43 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Homebridge script does NOT install into a container #1110

New Issue
Closed
opened 2025-11-20 05:04:35 -05:00 by saavagebueno · 18 comments
saavagebueno commented 2025-11-20 05:04:35 -05:00
Owner
Copy Link

Originally created by @bazfum on GitHub (May 15, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

install/homebridge-install.sh

📂 What was the exact command used to execute the script?

homebridge-install.sh

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

No response

📝 Provide a clear and concise description of the issue.

This script does NOT create a container but instead just installs Homebridge on the host OS. I know I should have read through it more closely but the description on the site does say it creates a container.

🔄 Steps to reproduce the issue.

run command in your proxmox shell, see install right there

❌ Paste the full error output (if available).

n/a

🖼️ Additional context (optional).

No response

Originally created by @bazfum on GitHub (May 15, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? install/homebridge-install.sh ### 📂 What was the exact command used to execute the script? homebridge-install.sh ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? _No response_ ### 📝 Provide a clear and concise description of the issue. This script does NOT create a container but instead just installs Homebridge on the host OS. I know I should have read through it more closely but the description on the site does say it creates a container. ### 🔄 Steps to reproduce the issue. run command in your proxmox shell, see install right there ### ❌ Paste the full error output (if available). n/a ### 🖼️ Additional context (optional). _No response_
saavagebueno added the bug label 2025-11-20 05:04:35 -05:00
saavagebueno commented 2025-11-20 05:04:36 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (May 15, 2025):

I dont really know what you are doing but it creates the LXC just fine?

Image

You used this command bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/homebridge.sh)"?

@michelroegl-brunner commented on GitHub (May 15, 2025): I dont really know what you are doing but it creates the LXC just fine? ![Image](https://github.com/user-attachments/assets/4c7a7f42-fba4-4c7d-b0c5-5433ad610c1b) You used this command `bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/homebridge.sh)"`?
saavagebueno commented 2025-11-20 05:04:36 -05:00
Author
Owner
Copy Link

@bazfum commented on GitHub (May 15, 2025):

Nope, it did not show any of the info there and just ran all the app-get etc commands right on the host.

@bazfum commented on GitHub (May 15, 2025): Nope, it did not show any of the info there and just ran all the app-get etc commands right on the host.
saavagebueno commented 2025-11-20 05:04:36 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (May 15, 2025):

Screenshot?

@MickLesk commented on GitHub (May 15, 2025): Screenshot?
saavagebueno commented 2025-11-20 05:04:36 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (May 16, 2025):

Nope, it did not show any of the info there and just ran all the app-get etc commands right on the host.

If you used pur script (the one i posted above) this is technical not even possible, as the script would fail befor even running the apt command, as this is run directly with the Container ID. And if it was not created, it would not be started and fail there.

The only thing wich gets installed with apt on your host is curl, maybee you saw that?

Can you please provide the exact command you used?

@michelroegl-brunner commented on GitHub (May 16, 2025): > Nope, it did not show any of the info there and just ran all the app-get etc commands right on the host. If you used pur script (the one i posted above) this is technical not even possible, as the script would fail befor even running the apt command, as this is run directly with the Container ID. And if it was not created, it would not be started and fail there. The only thing wich gets installed with apt on your host is curl, maybee you saw that? Can you please provide the exact command you used?
saavagebueno commented 2025-11-20 05:04:37 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (May 16, 2025):

So, basically the website says "run this command to install", but you went ahead add ignored it and did it the way YOU want to do it?

Man...

@tremor021 commented on GitHub (May 16, 2025): So, basically the website says "run this command to install", but you went ahead add ignored it and did it the way YOU want to do it? Man...
saavagebueno commented 2025-11-20 05:04:37 -05:00
Author
Owner
Copy Link

@bazfum commented on GitHub (May 16, 2025):

I ran the script, it never gave any of that colorful information. On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge.

When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host.

I don’t see any error handling in that script, so I just have to assume that source command at the top failed and it just kept on going where it was.

@bazfum commented on GitHub (May 16, 2025): I ran the script, it never gave any of that colorful information. On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge. When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host. I don’t see any error handling in that script, so I just have to assume that source command at the top failed and it just kept on going where it was.
saavagebueno commented 2025-11-20 05:04:37 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (May 16, 2025):

If you run this on the host, it will of course only be installed on the host... If you don't get any feedback despite curl, something is wrong. Curl has its own error handling

@MickLesk commented on GitHub (May 16, 2025): If you run this on the host, it will of course only be installed on the host... If you don't get any feedback despite curl, something is wrong. Curl has its own error handling
saavagebueno commented 2025-11-20 05:04:37 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (May 16, 2025):

I ran the script, it never gave any of that colorful information. On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge.

When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host.

I don’t see any error handling in that script, so I just have to assume that source command at the top failed and it just kept on going where it was.

To be fair, and i dont want to offend you, you should never execute shell code from the web when you can not comprehend it. Wich is okay, this is the main reason this repository even exist.
Bit blindly executing shell commands is dangerous, and you should never do it.

I will close this issue now, as this is not a issue with our script. Please run the script again and if any error occours, or even you get no output at all, pleas open a new issue for this.

And pleas, never execute commands you dont understand blindly in your shell. Our code is maintained and everey pull request needs approval from two persons. But not everey code you find online has this much scrunity. Either it can be mallicious or destroy your Operating System.

@michelroegl-brunner commented on GitHub (May 16, 2025): > I ran the script, it never gave any of that colorful information. On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge. > > When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host. > > I don’t see any error handling in that script, so I just have to assume that source command at the top failed and it just kept on going where it was. To be fair, and i dont want to offend you, you should never execute shell code from the web when you can not comprehend it. Wich is okay, this is the main reason this repository even exist. Bit blindly executing shell commands is dangerous, and you should never do it. I will close this issue now, as this is not a issue with our script. Please run the script again and if any error occours, or even you get no output at all, pleas open a new issue for this. And pleas, never execute commands you dont understand blindly in your shell. Our code is maintained and everey pull request needs approval from two persons. But not everey code you find online has this much scrunity. Either it can be mallicious or destroy your Operating System.
saavagebueno commented 2025-11-20 05:04:37 -05:00
Author
Owner
Copy Link

@bazfum commented on GitHub (May 16, 2025):

How else is it supposed to create a container if you don’t run it on the host? Every other script I’ve run from this site runs in the host shell, why would this be different? It says it’s going to create a container and then run the install in the container. It didn’t do that. That’s a bug.

@bazfum commented on GitHub (May 16, 2025): How else is it supposed to create a container if you don’t run it on the host? Every other script I’ve run from this site runs in the host shell, why would this be different? It says it’s going to create a container and then run the install in the container. It didn’t do that. That’s a bug.
saavagebueno commented 2025-11-20 05:04:37 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (May 16, 2025):

Yeah, just run the provided command from the homepage.
Do not run the code lines by itself, as there is so much automation it breaks.

I tried it yesterday on my private node (screenshot above) and tody on my test node at work, it creates the container just fine.

Maybe try debian, and if it works try homebridge again.

@michelroegl-brunner commented on GitHub (May 16, 2025): Yeah, just run the provided command from the homepage. Do not run the code lines by itself, as there is so much automation it breaks. I tried it yesterday on my private node (screenshot above) and tody on my test node at work, it creates the container just fine. Maybe try debian, and if it works try homebridge again.
saavagebueno commented 2025-11-20 05:04:38 -05:00
Author
Owner
Copy Link

@bazfum commented on GitHub (May 16, 2025):

Again, I did just run the script. In the host shell in the PM admin site. It didn’t create a container. It just installed directly on the host shell. There is no error handling in that to ensure that those PM specific commands actually run, so I have to assume that sourcing failed and it just kept going. I have run several other scripts exactly the same way and they worked. Maybe it was just a glitch, but the lack of error handling is still a bug.

@bazfum commented on GitHub (May 16, 2025): Again, I did just run the script. In the host shell in the PM admin site. It didn’t create a container. It just installed directly on the host shell. There is no error handling in that to ensure that those PM specific commands actually run, so I have to assume that sourcing failed and it just kept going. I have run several other scripts exactly the same way and they worked. Maybe it was just a glitch, but the lack of error handling is still a bug.
saavagebueno commented 2025-11-20 05:04:38 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (May 16, 2025):

And above you stated you ran the commands line by line after the script failed, now you say you did not do anything. (wich has propper error handeling, but only after the source command).
It would fail when it can not source because the functions are defined in the sourced build.func

@michelroegl-brunner commented on GitHub (May 16, 2025): And above you stated you ran the commands line by line after the script failed, now you say you did not do anything. (wich has propper error handeling, but only after the source command). It would fail when it can not source because the functions are defined in the sourced build.func
saavagebueno commented 2025-11-20 05:04:38 -05:00
Author
Owner
Copy Link

@bazfum commented on GitHub (May 16, 2025):

I never said I ran them line by line? No idea where you got that from. The only error handling I see is around the homebridge install pieces, nothing’s looking to make sure it created and entered a container.

@bazfum commented on GitHub (May 16, 2025): I never said I ran them line by line? No idea where you got that from. The only error handling I see is around the homebridge install pieces, nothing’s looking to make sure it created and entered a container.
saavagebueno commented 2025-11-20 05:04:38 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (May 16, 2025):

On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge.

When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host

What is this then?

@michelroegl-brunner commented on GitHub (May 16, 2025): On the host, it ran the exact commands listed in the script file. Installed avahi and gnupg, then added the homebridge repository and installed homeridge. When I realized what happened I immediately cleaned it up to avoid interfering with VMs running in the host What is this then?
saavagebueno commented 2025-11-20 05:04:38 -05:00
Author
Owner
Copy Link

@bazfum commented on GitHub (May 16, 2025):

It. As in the curl command. Not I, as in me manually…

@bazfum commented on GitHub (May 16, 2025): It. As in the curl command. Not I, as in me manually…
saavagebueno commented 2025-11-20 05:04:38 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (May 16, 2025):

@bazfum What you fail to understand is that our scripts use a fully featured backend set of scripts that create/build/install the container and apps inside of it, completely automated.

You clearly ran the commands one by one copy/pasting it from the script, hence bypassing all of those backend operations (creating the lxc, updating it, running the install script inside it).

Now, you can argue all you want, but only way for this to happen, the stuff you describe, is to run it the way i just said.
So, you can either cut this circlejerk right now and run the script the way its supposed to run and stop this charade.
Our scripts have half a million number of installs, you are the only one to ever have this "issue", so it's pretty clear to me what happened.

@michelroegl-brunner just close this one please. there is no point

@tremor021 commented on GitHub (May 16, 2025): @bazfum What you fail to understand is that our scripts use a fully featured backend set of scripts that create/build/install the container and apps inside of it, completely automated. You clearly ran the commands one by one copy/pasting it from the script, hence bypassing all of those backend operations (creating the lxc, updating it, running the install script inside it). Now, you can argue all you want, but only way for this to happen, the stuff you describe, is to run it the way i just said. So, you can either cut this circlejerk right now and run the script the way its supposed to run and stop this charade. Our scripts have half a million number of installs, you are the only one to ever have this "issue", so it's pretty clear to me what happened. @michelroegl-brunner just close this one please. there is no point
saavagebueno commented 2025-11-20 05:04:38 -05:00
Author
Owner
Copy Link

@bazfum commented on GitHub (May 16, 2025):

Dude, wtf? I came here to let you all know that I ran the script as instructed and it failed. No idea why you’re assuming I ran it line by line when I've been very clear that I didn’t. If you want to just write it off as a glitch or whatever and ignore me thats fine, but you don’t have to be a dick about it.

There’s definitely no error handling for that source command at the top of the script, so I have to assume GitHub failed to send that correctly and it just kept on rolling.

@bazfum commented on GitHub (May 16, 2025): Dude, wtf? I came here to let you all know that I ran the script as instructed and it failed. No idea why you’re assuming I ran it line by line when I've been very clear that I didn’t. If you want to just write it off as a glitch or whatever and ignore me thats fine, but you don’t have to be a dick about it. There’s definitely no error handling for that source command at the top of the script, so I have to assume GitHub failed to send that correctly and it just kept on rolling.
saavagebueno commented 2025-11-20 05:04:39 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (May 16, 2025):

Script run fine. Tried today on 3 different systems.

We have several Error handlings (PVE Check, Template Check, curl Check, root Check, filefs Check, Install Check, ...), its Impossible to create with this Scripts an install on the Host. It is simply not technically possible. We can't help with that either. If you want to keep arguing, go ahead, but we'll stay out of it from now on.

@MickLesk commented on GitHub (May 16, 2025): Script run fine. Tried today on 3 different systems. We have several Error handlings (PVE Check, Template Check, curl Check, root Check, filefs Check, Install Check, ...), its Impossible to create with this Scripts an install on the Host. It is simply not technically possible. We can't help with that either. If you want to keep arguing, go ahead, but we'll stay out of it from now on.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1110
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?