SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Update selfh.st/icon URLs #1116

New Issue
Closed
opened 2025-11-20 05:04:42 -05:00 by saavagebueno · 5 comments
saavagebueno commented 2025-11-20 05:04:42 -05:00
Owner
Copy Link

Originally created by @shollyethan on GitHub (May 16, 2025).

Originally assigned to: @MickLesk, @tremor021 on GitHub.

📌 Task summary

Update selfh.st/icon URLs to point to jsDelivr instead of GitHub

📋 Task details

Hey, Community Scripts team! While working through some recent requests I received for icons to be used in this repo, I noticed the current config files for each script are currently pointing to GitHub's own raw file domain:

https://raw.githubusercontent.com/selfhst/icons/refs/heads/main/webp/2fauth.webp

It would be super helpful if the team could update the links to instead use jsDelivr's free CDN service instead:

https://cdn.jsdelivr.net/gh/selfhst/icons/webp/2fauth.webp

This would not only help me track statistics/views, but the icons would also benefit from their global CDN presence.

Thanks!

Originally created by @shollyethan on GitHub (May 16, 2025). Originally assigned to: @MickLesk, @tremor021 on GitHub. ### 📌 Task summary Update selfh.st/icon URLs to point to jsDelivr instead of GitHub ### 📋 Task details Hey, Community Scripts team! While working through some recent requests I received for icons to be used in this repo, I noticed the current config files for each script are currently pointing to GitHub's own raw file domain: https://raw.githubusercontent.com/selfhst/icons/refs/heads/main/webp/2fauth.webp It would be super helpful if the team could update the links to instead use jsDelivr's free CDN service instead: https://cdn.jsdelivr.net/gh/selfhst/icons/webp/2fauth.webp This would not only help me track statistics/views, but the icons would also benefit from their global CDN presence. Thanks!
saavagebueno added the feature label 2025-11-20 05:04:42 -05:00
saavagebueno commented 2025-11-20 05:04:48 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (May 16, 2025):

We can do that, since I've been copying URLs for hours today, that's @tremor021 's job now 😄

@MickLesk commented on GitHub (May 16, 2025): We can do that, since I've been copying URLs for hours today, that's @tremor021 's job now :smile:
saavagebueno commented 2025-11-20 05:04:48 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (May 16, 2025):

Sure, we are working on updating anything anyway. Should be easy to do with a find/replace!

@michelroegl-brunner commented on GitHub (May 16, 2025): Sure, we are working on updating anything anyway. Should be easy to do with a find/replace!
saavagebueno commented 2025-11-20 05:04:48 -05:00
Author
Owner
Copy Link

@shollyethan commented on GitHub (May 16, 2025):

We can do that, since I've been copying URLs for hours today, that's @tremor021 's job now 😄

Thanks a bunch! I'm getting ready to push ~75% of the icons you requested earlier today -- I should have most of the rest added in the next day or two.

@shollyethan commented on GitHub (May 16, 2025): > We can do that, since I've been copying URLs for hours today, that's [@tremor021](https://github.com/tremor021) 's job now 😄 Thanks a bunch! I'm getting ready to push ~75% of the icons you requested earlier today -- I should have most of the rest added in the next day or two.
saavagebueno commented 2025-11-20 05:04:49 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (May 16, 2025):

We can do that, since I've been copying URLs for hours today, that's @tremor021 's job now 😄

Sure, all the hard lifting is done by me, always...

Anyway, @shollyethan those are great news.

@tremor021 commented on GitHub (May 16, 2025): > We can do that, since I've been copying URLs for hours today, that's [@tremor021](https://github.com/tremor021) 's job now 😄 Sure, all the hard lifting is done by me, always... Anyway, @shollyethan those are great news.
saavagebueno commented 2025-11-20 05:04:49 -05:00
Author
Owner
Copy Link

@tremor021 commented on GitHub (May 17, 2025):

All links use CDN now, as per your instruction @shollyethan. The update is prepared at this branch:
https://github.com/community-scripts/ProxmoxVE/tree/jsons

as soon as big boys approve this, we will push to the main branch

@tremor021 commented on GitHub (May 17, 2025): All links use CDN now, as per your instruction @shollyethan. The update is prepared at this branch: https://github.com/community-scripts/ProxmoxVE/tree/jsons as soon as big boys approve this, we will push to the main branch
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?