scripts add-iptag updates IPs of LXCs but not of VMs #1316

@MickLesk commented on GitHub (Jun 21, 2025):

When installed?

Service Output?

Config Output?

@MickLesk commented on GitHub (Jun 21, 2025): When installed? Service Output? Config Output?

saavagebueno commented

@DST73 commented on GitHub (Jun 21, 2025):

Installed some time ago and updated today

Service output:

Config file is empty

@DST73 commented on GitHub (Jun 21, 2025): Installed some time ago and updated today Service output: ![Image](https://github.com/user-attachments/assets/7ed4e7da-42f3-4ca3-9b52-f4b783fcfbc6) Config file is empty

saavagebueno commented

@MickLesk commented on GitHub (Jun 21, 2025):

@DesertGamer maybe we should add an Guide, its everytime the Same?

@MickLesk commented on GitHub (Jun 21, 2025): @DesertGamer maybe we should add an Guide, its everytime the Same?

saavagebueno commented

@DesertGamer commented on GitHub (Jun 22, 2025):

This is an interesting behavior and I'm investigating it with a test machine soon.

@DesertGamer commented on GitHub (Jun 22, 2025): This is an interesting behavior and I'm investigating it with a test machine soon.

saavagebueno commented

@Maxter3185 commented on GitHub (Jun 23, 2025):

Same error here. Installed the script maybe 2 weeks ago, but didn't have any VM at that moment so I didn't noticed that

@Maxter3185 commented on GitHub (Jun 23, 2025): Same error here. Installed the script maybe 2 weeks ago, but didn't have any VM at that moment so I didn't noticed that

saavagebueno commented

@DesertGamer commented on GitHub (Jun 23, 2025):

Tell me, please, are you trying to update the script instead of installing it from scratch?

@DesertGamer commented on GitHub (Jun 23, 2025): Tell me, please, are you trying to update the script instead of installing it from scratch?

saavagebueno commented

@DesertGamer commented on GitHub (Jun 23, 2025):

@Maxter3185, @DST73 The fact is that I checked the errors and found that the update algorithm is working incorrectly, I will make the necessary changes in the near future.

@DesertGamer commented on GitHub (Jun 23, 2025): @Maxter3185, @DST73 The fact is that I checked the errors and found that the update algorithm is working incorrectly, I will make the necessary changes in the near future.

saavagebueno commented

@DST73 commented on GitHub (Jun 23, 2025):

Ok thank you :)

@DST73 commented on GitHub (Jun 23, 2025): Ok thank you :)

saavagebueno commented

@DesertGamer commented on GitHub (Jul 2, 2025):

Guys, I'm sorry, I didn't have time to do all this at all. I wrote it down for myself and will try to roll out the fix in a couple of hours.

@DesertGamer commented on GitHub (Jul 2, 2025): Guys, I'm sorry, I didn't have time to do all this at all. I wrote it down for myself and will try to roll out the fix in a couple of hours.

saavagebueno commented

@Maxter3185 commented on GitHub (Jul 2, 2025):

Guys, I'm sorry, I didn't have time to do all this at all. I wrote it down for myself and will try to roll out the fix in a couple of hours.

@DesertGamer No worries! I've kinda fixed it yesterday (at least for me). Looking at the scripts I've found the newer version of the script moved the config files and the script from /opt/lxc-iptag to /opt/iptag, and the config file was missing in the second folder. Restarted the service and it worked.

What I've also found (I know I should open a new thread for this) is that this script is kinda heavy on the cpu time everytime it runs.

This is from the netdata console. I don't know if this is normal behaviour or not.

@Maxter3185 commented on GitHub (Jul 2, 2025): > Guys, I'm sorry, I didn't have time to do all this at all. I wrote it down for myself and will try to roll out the fix in a couple of hours. @DesertGamer No worries! I've kinda fixed it yesterday (at least for me). Looking at the scripts I've found the newer version of the script moved the config files and the script from /opt/lxc-iptag to /opt/iptag, and the config file was missing in the second folder. Restarted the service and it worked. What I've also found (I know I should open a new thread for this) is that this script is kinda heavy on the cpu time everytime it runs. ![Image](https://github.com/user-attachments/assets/beac280b-bad1-4324-9c38-9fc08547bbb5) This is from the netdata console. I don't know if this is normal behaviour or not.

saavagebueno commented

@DST73 commented on GitHub (Jul 3, 2025):

I tried the same and copied the iptag.conf and restarted the service

cp /opt/lxc-iptag/iptag.conf /opt/iptag

now my VMs get updated as well :)

@DST73 commented on GitHub (Jul 3, 2025): I tried the same and copied the iptag.conf and restarted the service `` cp /opt/lxc-iptag/iptag.conf /opt/iptag `` now my VMs get updated as well :)

saavagebueno commented

@MickLesk commented on GitHub (Jul 3, 2025):

Maybe we remove the old Install fully and then Install the new one? Not migrating, Just Check If the old exist and full remove it

@DesertGamer

@MickLesk commented on GitHub (Jul 3, 2025): Maybe we remove the old Install fully and then Install the new one? Not migrating, Just Check If the old exist and full remove it @DesertGamer

saavagebueno commented

@DesertGamer commented on GitHub (Jul 3, 2025):

@MickLesk Look, initially I planned that people who would use the old script with this would be able to seamlessly switch to the new one, for this I wrote an update algorithm, after which I noticed that it was cleaned in the commit, perhaps not intentionally, which is why I just removed this algorithm in the latest version, as it turned out not all, I I would still add a seamless transition algorithm that would be useful to users who have previously used this script.

@DesertGamer commented on GitHub (Jul 3, 2025): @MickLesk Look, initially I planned that people who would use the old script with this would be able to seamlessly switch to the new one, for this I wrote an update algorithm, after which I noticed that it was cleaned in the commit, perhaps not intentionally, which is why I just removed this algorithm in the latest version, as it turned out not all, I I would still add a seamless transition algorithm that would be useful to users who have previously used this script.

saavagebueno commented

@DesertGamer commented on GitHub (Jul 3, 2025):

Ребята, извините, я вообще не успел все это сделать. Я записал его для себя и постараюсь выкатить исправление через пару часов.

@DesertGamer Без волнений! Я вроде как исправил это вчера (по крайней мере, для меня). Просматривая скрипты, я обнаружил, что новая версия скрипта переместила конфигурационные файлы и скрипт из /opt/lxc-iptag в /opt/iptag, а конфигурационный файл отсутствовал во второй папке. Перезапустил сервис и он заработал.

Что я также обнаружил (я знаю, что мне следует открыть новую тему для этого), так это то, что этот скрипт довольно сильно расходует время процессора каждый раз, когда он запускается.

Это из консоли netdata. Я не знаю, нормальное это поведение или нет.

Please make a separate issue for this and I will definitely see what's the matter.

@DesertGamer commented on GitHub (Jul 3, 2025): > > Ребята, извините, я вообще не успел все это сделать. Я записал его для себя и постараюсь выкатить исправление через пару часов. > > [@DesertGamer](https://github.com/DesertGamer) Без волнений! Я вроде как исправил это вчера (по крайней мере, для меня). Просматривая скрипты, я обнаружил, что новая версия скрипта переместила конфигурационные файлы и скрипт из /opt/lxc-iptag в /opt/iptag, а конфигурационный файл отсутствовал во второй папке. Перезапустил сервис и он заработал. > > Что я также обнаружил (я знаю, что мне следует открыть новую тему для этого), так это то, что этот скрипт довольно сильно расходует время процессора каждый раз, когда он запускается. > > ![Image](https://github.com/user-attachments/assets/beac280b-bad1-4324-9c38-9fc08547bbb5) > > Это из консоли netdata. Я не знаю, нормальное это поведение или нет. Please make a separate issue for this and I will definitely see what's the matter.

saavagebueno commented

@DesertGamer commented on GitHub (Jul 3, 2025):

Thanks to your messages, the new version has become even better. After it is accepted, you will need to reinstall the script.

Now the function of saving the config has been added (this is optional, you can also overwrite it), as well as updating the service so that you do not worry about your current configuration.

@DesertGamer commented on GitHub (Jul 3, 2025): Thanks to your messages, the new version has become even better. After it is accepted, you will need to reinstall the script. Now the function of saving the config has been added (this is optional, you can also overwrite it), as well as updating the service so that you do not worry about your current configuration.

saavagebueno commented

@DesertGamer commented on GitHub (Jul 4, 2025):

The update has been downloaded, please use the command:

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/tools/pve/add-iptag.sh)"

You can save your old config using an additional option when updating, but I strongly recommend overwriting it.

@DesertGamer commented on GitHub (Jul 4, 2025): The update has been downloaded, please use the command: ``` bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/tools/pve/add-iptag.sh)" ``` You can save your old config using an additional option when updating, but I strongly recommend overwriting it.

saavagebueno commented