SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Increase and/or allow configuration of curl timeout for fetch_and_deploy_gh_release #1329

New Issue
Closed
opened 2025-11-20 05:08:21 -05:00 by saavagebueno · 8 comments
saavagebueno commented 2025-11-20 05:08:21 -05:00
Owner
Copy Link

Originally created by @chrislo27 on GitHub (Jun 22, 2025).

📌 Task summary

Increase and/or allow configuration of curl timeout for fetch_and_deploy_gh_release

📋 Task details

The default timeout for curl in the fetch_and_deploy_gh_release tools function is 30 seconds. This can be too short for downloading larger releases (e.g. immich tarballs), and is also dependent on the user's network and GitHub's CDN servers. While it might work for some, it may not work for others.

Line where timeout values are set: 5cf8765d9a/misc/tools.func (L744)

It would be good to increase the default timeout, allow it to be passed in as a parameter to the function, or remove it entirely.

Originally created by @chrislo27 on GitHub (Jun 22, 2025). ### 📌 Task summary Increase and/or allow configuration of curl timeout for fetch_and_deploy_gh_release ### 📋 Task details The default timeout for `curl` in the `fetch_and_deploy_gh_release` tools function is 30 seconds. This can be too short for downloading larger releases (e.g. immich tarballs), and is also dependent on the user's network and GitHub's CDN servers. While it might work for some, it may not work for others. Line where timeout values are set: https://github.com/community-scripts/ProxmoxVE/blob/5cf8765d9a650af8273e4050a43ad70be056a24a/misc/tools.func#L744 It would be good to increase the default timeout, allow it to be passed in as a parameter to the function, or remove it entirely.
saavagebueno commented 2025-11-20 05:08:21 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jun 23, 2025):

That the timeout to get the Release Version number? I think its big enough for an json with <100kb (in very large Projects)

@MickLesk commented on GitHub (Jun 23, 2025): That the timeout to get the Release Version number? I think its big enough for an json with <100kb (in very large Projects)
saavagebueno commented 2025-11-20 05:08:22 -05:00
Author
Owner
Copy Link

@vhsdream commented on GitHub (Jun 23, 2025):

@MickLesk the timeout is also used here which downloads the release itself, and in several subsequent places.

@vhsdream commented on GitHub (Jun 23, 2025): @MickLesk the timeout is also used [here](https://github.com/community-scripts/ProxmoxVE/blob/5cf8765d9a650af8273e4050a43ad70be056a24a/misc/tools.func#L789) which downloads the release itself, and in several subsequent places.
saavagebueno commented 2025-11-20 05:08:22 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jun 23, 2025):

And what is the preferred time?! I don't make it configurable, the function already has 6 different values either way.

@MickLesk commented on GitHub (Jun 23, 2025): And what is the preferred time?! I don't make it configurable, the function already has 6 different values either way.
saavagebueno commented 2025-11-20 05:08:22 -05:00
Author
Owner
Copy Link

@chrislo27 commented on GitHub (Jun 23, 2025):

I don't know why the original timeout exists so there may be a good reason for it to remain in the metadata fetch operations. Since there are already so many parameters in the function, it might be best to just remove the curl_timeout param for non-metadata fetching (or maybe just keep the connect timeout).

@chrislo27 commented on GitHub (Jun 23, 2025): I don't know why the original timeout exists so there may be a good reason for it to remain in the metadata fetch operations. Since there are already so many parameters in the function, it might be best to just remove the `curl_timeout` param for non-metadata fetching (or maybe just keep the connect timeout).
saavagebueno commented 2025-11-20 05:08:22 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jun 23, 2025):

This is in there because many have Github blocks via Adblock or PiHole -> that means it would load endlessly or not even get that far.

@MickLesk commented on GitHub (Jun 23, 2025): This is in there because many have Github blocks via Adblock or PiHole -> that means it would load endlessly or not even get that far.
saavagebueno commented 2025-11-20 05:08:22 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jun 23, 2025):

I Check tomorrow the largest Releasefile that we use, then i calculate with 100kb/s + 50% as time, maybe this should enough.

@MickLesk commented on GitHub (Jun 23, 2025): I Check tomorrow the largest Releasefile that we use, then i calculate with 100kb/s + 50% as time, maybe this should enough.
saavagebueno commented 2025-11-20 05:08:22 -05:00
Author
Owner
Copy Link

@chrislo27 commented on GitHub (Jun 23, 2025):

Thanks! For reference I was updating immich to 1.135.3 https://github.com/immich-app/immich/releases/tag/v1.135.3 which downloads the source code tarball, and that's currently just over 70 MB.

@chrislo27 commented on GitHub (Jun 23, 2025): Thanks! For reference I was updating immich to 1.135.3 https://github.com/immich-app/immich/releases/tag/v1.135.3 which downloads the source code tarball, and that's currently just over 70 MB.
saavagebueno commented 2025-11-20 05:08:23 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jun 24, 2025):

done

@MickLesk commented on GitHub (Jun 24, 2025): done
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1329
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?