SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-06-05 06:51:58 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Fix: AdventureLog - update script bug #1521

New Issue
Closed
opened 2025-11-20 05:11:45 -05:00 by saavagebueno · 1 comment
saavagebueno commented 2025-11-20 05:11:45 -05:00
Owner
Copy Link

Originally created by @mr8tom on GitHub (Jul 17, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

AdventureLog

📂 What was the exact command used to execute the script?

update

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

No response

📝 Provide a clear and concise description of the issue.

The given Update-Script does not work.

🔄 Steps to reproduce the issue.

I updated after install from here around 2025-03-20 from https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/adventurelog.sh with the known command
update

❌ Paste the full error output (if available).

There is no such backup-folder created in first time (from the given script)

cp /opt/adventurelog-backup/backend/server/.env /opt/adventurelog/backend/server/.env
cp -r /opt/adventurelog-backup/backend/server/media /opt/adventurelog/backend/server/media

🖼️ Additional context (optional).

There is no such backup-folder created in first time. I searched the forum and found your script @JesperDramsch from here: https://github.com/JesperDramsch/ProxmoxVE/blob/fix/adventurelog-update/ct/adventurelog.sh

There I had to change the linr 44 (or 45) for the correct folder (because it unzipped the downloaded update into /root):

cd /opt

...bevor unzip

....or:

unzip -q /opt/v${RELEASE}.zip -d /opt

I thought your change @JesperDramsch was committed because of #1334? But the script does not contain your change and I didn't found any other Topics for this Problem. Maybe you can have a look into it? I'm fine at v0.10.0 :)

Originally created by @mr8tom on GitHub (Jul 17, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? AdventureLog ### 📂 What was the exact command used to execute the script? update ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? _No response_ ### 📝 Provide a clear and concise description of the issue. The given Update-Script does not work. ### 🔄 Steps to reproduce the issue. I updated after install from here around 2025-03-20 from https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/adventurelog.sh with the known command `update` ### ❌ Paste the full error output (if available). There is no such backup-folder created in first time (from the given script) ``` cp /opt/adventurelog-backup/backend/server/.env /opt/adventurelog/backend/server/.env cp -r /opt/adventurelog-backup/backend/server/media /opt/adventurelog/backend/server/media ``` ### 🖼️ Additional context (optional). There is no such backup-folder created in first time. I searched the forum and found your script @JesperDramsch from here: https://github.com/JesperDramsch/ProxmoxVE/blob/fix/adventurelog-update/ct/adventurelog.sh There I had to change the linr 44 (or 45) for the correct folder (because it unzipped the downloaded update into /root): ``` cd /opt ``` ...bevor unzip ....or: ``` unzip -q /opt/v${RELEASE}.zip -d /opt ``` I thought your change @JesperDramsch was committed because of #1334? But the script does not contain your change and I didn't found any other Topics for this Problem. Maybe you can have a look into it? I'm fine at v0.10.0 :)
saavagebueno added the bug label 2025-11-20 05:11:45 -05:00
saavagebueno commented 2025-11-20 05:11:46 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jul 18, 2025):

With the linked element you are using a completely outdated logic of the script. The script was refactored 1 month ago and migrated to uv. As a result, you have now multiplied everything and you can no longer actively help. It would have made more sense to simply create the folder and execute the update, so all dependencies are no longer up to date, no uv is installed.

I have now built a PR for upcoming installations with #6066, which creates the folder beforehand, but how you do it, you have to look at the next update to see if that works without any problems.

@MickLesk commented on GitHub (Jul 18, 2025): With the linked element you are using a completely outdated logic of the script. The script was refactored 1 month ago and migrated to uv. As a result, you have now multiplied everything and you can no longer actively help. It would have made more sense to simply create the folder and execute the update, so all dependencies are no longer up to date, no uv is installed. I have now built a PR for upcoming installations with #6066, which creates the folder beforehand, but how you do it, you have to look at the next update to see if that works without any problems.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1521
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?