SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

incorrect version display #1561

New Issue
Closed
opened 2025-11-20 05:12:28 -05:00 by saavagebueno · 10 comments
saavagebueno commented 2025-11-20 05:12:28 -05:00
Owner
Copy Link

Originally created by @umrath on GitHub (Jul 25, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Immich

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://git.community-scripts.org/community-scripts/ProxmoxVE/raw/branch/main/ct/immich.sh)"

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

No response

📝 Provide a clear and concise description of the issue.

The webpage displays v0.136.0 (which is indeed the latest Immich release) but the script is hard coded to still install/update to v0.135.3.
Without looking into the source code, there is no reliable way to determine, which version is actually being installed/updated to.
That's unexpected and confusing.

The webpage should display the version the script is actually going to install/update to.

🔄 Steps to reproduce the issue.

Run script, observe v.0.135.3 being updated to.

❌ Paste the full error output (if available).

No error log as the script itself does exactly what it is supposed to do.

🖼️ Additional context (optional).

No response

Originally created by @umrath on GitHub (Jul 25, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Immich ### 📂 What was the exact command used to execute the script? bash -c "$(curl -fsSL https://git.community-scripts.org/community-scripts/ProxmoxVE/raw/branch/main/ct/immich.sh)" ### ⚙️ What settings are you using? - [ ] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? _No response_ ### 📝 Provide a clear and concise description of the issue. The webpage displays v0.136.0 (which is indeed the latest Immich release) but the script is hard coded to still install/update to v0.135.3. Without looking into the source code, there is no reliable way to determine, which version is actually being installed/updated to. That's unexpected and confusing. The webpage should display the version the script is actually going to install/update to. ### 🔄 Steps to reproduce the issue. Run script, observe v.0.135.3 being updated to. ### ❌ Paste the full error output (if available). No error log as the script itself does exactly what it is supposed to do. ### 🖼️ Additional context (optional). _No response_
saavagebueno added the bug label 2025-11-20 05:12:28 -05:00
saavagebueno commented 2025-11-20 05:12:29 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jul 25, 2025):

1.) the issue is created incorrectly
2.) this is defined on the website based on the repo, not what we install - its an crawling from newreleases.io
3.) if you had looked in PR's changelog and issues - you would have seen directly that we have pinned the version for security reasons

What a useless issue, sorry.

https://github.com/community-scripts/ProxmoxVE/issues/6211

@MickLesk commented on GitHub (Jul 25, 2025): 1.) the issue is created incorrectly 2.) this is defined on the website based on the repo, not what we install - its an crawling from newreleases.io 3.) if you had looked in PR's changelog and issues - you would have seen directly that we have pinned the version for security reasons What a useless issue, sorry. https://github.com/community-scripts/ProxmoxVE/issues/6211
saavagebueno commented 2025-11-20 05:12:29 -05:00
Author
Owner
Copy Link

@umrath commented on GitHub (Jul 25, 2025):

1.) the issue is created incorrectly 2.) this is defined on the website based on the repo, not what we install 3.) if you had looked in PR's changelog and issues - you would have seen directly that we have pinned the version for security reasons

What a useless issue, sorry.

I fail to see how the issue is created incorrectly. All necessary information to understand the issue has been provided.

How is the user supposed to know which version is actually being installed? Should people really read the code? On the page I fail to find any mentioning of version v0.135.3 being installed.

Even if what you stated is right (I cannot find the mentioned reasoning for the pinning), it doesn't change the fact that the information is inconsistent and thus confusing.

Edit: I did not check the linked #6211 as the installation does not brick. It works.

@umrath commented on GitHub (Jul 25, 2025): > 1.) the issue is created incorrectly 2.) this is defined on the website based on the repo, not what we install 3.) if you had looked in PR's changelog and issues - you would have seen directly that we have pinned the version for security reasons > > What a useless issue, sorry. I fail to see how the issue is created incorrectly. All necessary information to understand the issue has been provided. How is the user supposed to know which version is actually being installed? Should people really read the code? On the page I fail to find any mentioning of version v0.135.3 being installed. Even if what you stated is right (I cannot find the mentioned reasoning for the pinning), it doesn't change the fact that the information is inconsistent and thus confusing. Edit: I did not check the linked #6211 as the installation does not brick. It works.
saavagebueno commented 2025-11-20 05:12:29 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jul 25, 2025):

Then build a crawler that goes through every single one of our scripts and finds the exact version. Thank you, please. Make an PR for this Action and we have an correct crawler. For the newreleases.io crawler we had invest more then 5d.

You have an issue with the website and not with the script, but you create a script issue.

There were 2 active issues + 1 merged PR yesterday with the PIN explanation + 1 merged PR today to reinstall the latest version, I don't know what there is to discuss?

And yes, in the end, Read The Code. Frigate has also been pinned for a long time

@MickLesk commented on GitHub (Jul 25, 2025): Then build a crawler that goes through every single one of our scripts and finds the exact version. Thank you, please. Make an PR for this Action and we have an correct crawler. For the newreleases.io crawler we had invest more then 5d. You have an issue with the website and not with the script, but you create a script issue. There were 2 active issues + 1 merged PR yesterday with the PIN explanation + 1 merged PR today to reinstall the latest version, I don't know what there is to discuss? And yes, in the end, Read The Code. Frigate has also been pinned for a long time
saavagebueno commented 2025-11-20 05:12:30 -05:00
Author
Owner
Copy Link

@umrath commented on GitHub (Jul 25, 2025):

I never would have received such an insensible comment from tteck. :(

@umrath commented on GitHub (Jul 25, 2025): I never would have received such an insensible comment from tteck. :(
saavagebueno commented 2025-11-20 05:12:30 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jul 25, 2025):

There's nothing insensitive about that, it's a very simple explanation. It was an emergency pin to avoid bricking everything until the fix was there. And everything could be found in the repo.

@MickLesk commented on GitHub (Jul 25, 2025): There's nothing insensitive about that, it's a very simple explanation. It was an emergency pin to avoid bricking everything until the fix was there. And everything could be found in the repo.
saavagebueno commented 2025-11-20 05:12:30 -05:00
Author
Owner
Copy Link

@umrath commented on GitHub (Jul 25, 2025):

There's nothing insensitive about that, it's a very simple explanation. It was an emergency pin to avoid bricking everything until the fix was there. And everything could be found in the repo.

"What a useless issue, sorry." is surely not what I would describe as a comment that shows respect.
And essentially "read the code" is also not exactly what one would like to get as an answer.

It is a fact that the information on the webpage and the functionality of the script are inconsistent.
At the bare minimum, ackknowledging this would be the right thing to to.
I didn't expect an urgent fix or any kind of immediate activity.

It would have been absolutely sufficient to simply state:
"Yes, we know. It's a problem caused by pinning the version because of a bug discovered in #6211. We currently have no plans to fix this."

Much less effort, much more helpful and a lot less discrespectful.

@umrath commented on GitHub (Jul 25, 2025): > There's nothing insensitive about that, it's a very simple explanation. It was an emergency pin to avoid bricking everything until the fix was there. And everything could be found in the repo. "What a useless issue, sorry." is surely not what I would describe as a comment that shows respect. And essentially "read the code" is also not exactly what one would like to get as an answer. It is a fact that the information on the webpage and the functionality of the script are inconsistent. At the bare minimum, ackknowledging this would be the right thing to to. I didn't expect an urgent fix or any kind of immediate activity. It would have been absolutely sufficient to simply state: "Yes, we know. It's a problem caused by pinning the version because of a bug discovered in #6211. We currently have no plans to fix this." Much less effort, much more helpful and a lot less discrespectful.
saavagebueno commented 2025-11-20 05:12:30 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jul 25, 2025):

We just don't feel like discussing it anymore. We originally built this function on the website specifically to show users which version the underlying tool is in, not the script.

If there is any confusion, we will remove the function completely from the website - then there will be no more information anywhere.

And yes, tteck also said to leave the code beforehand.

@MickLesk commented on GitHub (Jul 25, 2025): We just don't feel like discussing it anymore. We originally built this function on the website specifically to show users which version the underlying tool is in, not the script. If there is any confusion, we will remove the function completely from the website - then there will be no more information anywhere. And yes, tteck also said to leave the code beforehand.
saavagebueno commented 2025-11-20 05:12:30 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Jul 25, 2025):

But that's also typical. Repo not set to Star, create issues, complain instead of simply going through the issues. As a precondition, it says when opening an issue:

Search first: before submitting, check if the problem has already been reported or solved in closed issues. If this is the case, comment on this issue instead of creating a new one.
Alternatively, you can also search for relevant information in the discussions in the “Announcement” or “Guide” categories.
[...]
📜 Read the script: Familiarize yourself with the content of the script and its purpose. This will help you to better understand the problem and provide relevant information.
@MickLesk commented on GitHub (Jul 25, 2025): But that's also typical. Repo not set to Star, create issues, complain instead of simply going through the issues. As a precondition, it says when opening an issue: ```md Search first: before submitting, check if the problem has already been reported or solved in closed issues. If this is the case, comment on this issue instead of creating a new one. Alternatively, you can also search for relevant information in the discussions in the “Announcement” or “Guide” categories. [...] 📜 Read the script: Familiarize yourself with the content of the script and its purpose. This will help you to better understand the problem and provide relevant information. ```
saavagebueno commented 2025-11-20 05:12:30 -05:00
Author
Owner
Copy Link

@umrath commented on GitHub (Jul 25, 2025):

We just don't feel like discussing it anymore. We originally built this function on the website specifically to show users which version the underlying tool is in, not the script.

If there is any confusion, we will remove the function completely from the website - then there will be no more information anywhere.

And yes, tteck also said to leave the code beforehand.

Just add this information to the webpage and it's clear.
A simple: "latest upstream version" would be sufficient.
But honestly: What's the benefit of displaying a version on the webpage and then install a different one?

So, yes. Removing the information would actually be reasonable.

And I read the code before installing. I even read it before updating. That's how I spotted the difference (as outlined in the initial report.)

@umrath commented on GitHub (Jul 25, 2025): > We just don't feel like discussing it anymore. We originally built this function on the website specifically to show users which version the underlying tool is in, not the script. > > If there is any confusion, we will remove the function completely from the website - then there will be no more information anywhere. > > And yes, tteck also said to leave the code beforehand. Just add this information to the webpage and it's clear. A simple: "latest upstream version" would be sufficient. But honestly: What's the benefit of displaying a version on the webpage and then install a different one? So, yes. Removing the information would actually be reasonable. And I read the code before installing. I even read it before updating. That's how I spotted the difference (as outlined in the initial report.)
saavagebueno commented 2025-11-20 05:12:31 -05:00
Author
Owner
Copy Link

@umrath commented on GitHub (Jul 25, 2025):

But that's also typical. Repo not set to Star, create issues, complain instead of simply going through the issues. As a precondition, it says when opening an issue:

Search first: before submitting, check if the problem has already been reported or solved in closed issues. If this is the case, comment on this issue instead of creating a new one.
Alternatively, you can also search for relevant information in the discussions in the “Announcement” or “Guide” categories.
[...]
📜 Read the script: Familiarize yourself with the content of the script and its purpose. This will help you to better understand the problem and provide relevant information.

I did read.
I could not find any issue about the version of the script being inconsistent with the version on the webpage.

Issue #6211 might be related but is not the same.

(And I'm sorry. I couldn't find any information that requires me to star the repo before I'm allowed to raise an issue.)

@umrath commented on GitHub (Jul 25, 2025): > But that's also typical. Repo not set to Star, create issues, complain instead of simply going through the issues. As a precondition, it says when opening an issue: > > Search first: before submitting, check if the problem has already been reported or solved in closed issues. If this is the case, comment on this issue instead of creating a new one. > Alternatively, you can also search for relevant information in the discussions in the “Announcement” or “Guide” categories. > [...] > 📜 Read the script: Familiarize yourself with the content of the script and its purpose. This will help you to better understand the problem and provide relevant information. I did read. I could not find any issue about the version of the script being inconsistent with the version on the webpage. Issue #6211 might be related but is not the same. (And I'm sorry. I couldn't find any information that requires me to star the repo before I'm allowed to raise an issue.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1561
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?