SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Syntax error in Immich scripts causes error during install #1843

New Issue
Closed
opened 2025-11-20 05:18:21 -05:00 by saavagebueno · 6 comments
saavagebueno commented 2025-11-20 05:18:21 -05:00
Owner
Copy Link

Originally created by @henworth on GitHub (Sep 4, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Immich

📂 What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://git.community-scripts.org/community-scripts/ProxmoxVE/raw/branch/main/ct/immich.sh)"

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

📈 Which Proxmox version are you on?

pve-manager/8.2.4/faa83925c9641325 (running kernel: 6.8.12-1-pve)

📝 Provide a clear and concise description of the issue.

There looks to be syntax errors in the Immich scripts that are causing install to exit prematurely. The error message is shown immediately upon executing the script:

bash: -c: line 359: unexpected EOF while looking for matching `"'

Looking at the code the issue originates here. There is a missing closing bracket that causes the quote mismatch. However, there are multiple instances of this, that line is merely the first instance. These changes were introduced in https://github.com/community-scripts/ProxmoxVE/pull/7395.

🔄 Steps to reproduce the issue.

Run the Immich script, immediately observe error.

❌ Paste the full error output (if available).

bash: -c: line 359: unexpected EOF while looking for matching `"'

🖼️ Additional context (optional).

No response

Originally created by @henworth on GitHub (Sep 4, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Immich ### 📂 What was the exact command used to execute the script? bash -c "$(curl -fsSL https://git.community-scripts.org/community-scripts/ProxmoxVE/raw/branch/main/ct/immich.sh)" ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 📈 Which Proxmox version are you on? pve-manager/8.2.4/faa83925c9641325 (running kernel: 6.8.12-1-pve) ### 📝 Provide a clear and concise description of the issue. There looks to be syntax errors in the Immich scripts that are causing install to exit prematurely. The error message is shown immediately upon executing the script: ``` bash: -c: line 359: unexpected EOF while looking for matching `"' ``` Looking at the code the issue originates [here](https://github.com/community-scripts/ProxmoxVE/blob/e74767d1a4d15c78aff5f9bb681999c5ea05caa2/ct/immich.sh#L210). There is a missing closing bracket that causes the quote mismatch. However, there are multiple instances of this, that line is merely the first instance. These changes were introduced in https://github.com/community-scripts/ProxmoxVE/pull/7395. ### 🔄 Steps to reproduce the issue. Run the Immich script, immediately observe error. ### ❌ Paste the full error output (if available). bash: -c: line 359: unexpected EOF while looking for matching `"' ### 🖼️ Additional context (optional). _No response_
saavagebueno added the bug label 2025-11-20 05:18:21 -05:00
saavagebueno commented 2025-11-20 05:18:21 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Sep 4, 2025):

@vhsdream

@MickLesk commented on GitHub (Sep 4, 2025): @vhsdream
saavagebueno commented 2025-11-20 05:18:22 -05:00
Author
Owner
Copy Link

@vhsdream commented on GitHub (Sep 4, 2025):

Bummer - looks like my autoformatter crapped out because otherwise this would have been fixed ☹️

@vhsdream commented on GitHub (Sep 4, 2025): Bummer - looks like my autoformatter crapped out because otherwise this would have been fixed ☹️
saavagebueno commented 2025-11-20 05:18:22 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Sep 4, 2025):

The autoformatter sometimes does things that are just awful. I don't use it anymore (shell-check). 😄

@MickLesk commented on GitHub (Sep 4, 2025): The autoformatter sometimes does things that are just awful. I don't use it anymore (shell-check). :smile:
saavagebueno commented 2025-11-20 05:18:22 -05:00
Author
Owner
Copy Link

@vhsdream commented on GitHub (Sep 4, 2025):

Had to disable shellcheck for the same reasons; however, annoyingly shfmt (a less aggressive alternative) did not send up any errors when I missed the closing brackets!

@vhsdream commented on GitHub (Sep 4, 2025): Had to disable shellcheck for the same reasons; however, annoyingly shfmt (a less aggressive alternative) did not send up any errors when I missed the closing brackets!
saavagebueno commented 2025-11-20 05:18:22 -05:00
Author
Owner
Copy Link

@vhsdream commented on GitHub (Sep 4, 2025):

@henworth Thanks for your quick fix!

@vhsdream commented on GitHub (Sep 4, 2025): @henworth Thanks for your quick fix!
saavagebueno commented 2025-11-20 05:18:22 -05:00
Author
Owner
Copy Link

@henworth commented on GitHub (Sep 4, 2025):

No worries! Happy to help. Definitely scratched my head for a bit because I was testing it out last night and then today it didn't work. Turns out I ran it mere minutes after your merge this morning 😂

@henworth commented on GitHub (Sep 4, 2025): No worries! Happy to help. Definitely scratched my head for a bit because I was testing it out last night and then today it didn't work. Turns out I ran it mere minutes after your merge this morning 😂
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1843
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?