SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Add Description for vm bridges #1854

New Issue
Open
opened 2025-11-20 05:18:32 -05:00 by saavagebueno · 7 comments
saavagebueno commented 2025-11-20 05:18:32 -05:00
Owner
Copy Link

Originally created by @Kaputtnique on GitHub (Sep 6, 2025).

Originally assigned to: @michelroegl-brunner on GitHub.

🌟 Briefly describe the feature

add description/comment field in the "Select network bridge"

📝 Detailed description

I would like to have a comment/Description field .. like in pve .. if someone has 5 bridges or more.. then have to watch to the bridge and see which one i wanna use..

instead of that maybe add the comment field into the process of creating new lxc/vm

"Select network bridge"

"vmbr0 Bridge COMMENTFIELD"

i would love <3 :-D

💡 Why is this useful?

to see without watching again which bridge i wanna use

if see any errors (of false spoken) , take it

Originally created by @Kaputtnique on GitHub (Sep 6, 2025). Originally assigned to: @michelroegl-brunner on GitHub. ### 🌟 Briefly describe the feature add description/comment field in the "Select network bridge" ### 📝 Detailed description I would like to have a comment/Description field .. like in pve .. if someone has 5 bridges or more.. then have to watch to the bridge and see which one i wanna use.. instead of that maybe add the comment field into the process of creating new lxc/vm "Select network bridge" "vmbr0 Bridge COMMENTFIELD" i would love <3 :-D ### 💡 Why is this useful? to see without watching again which bridge i wanna use if see any errors (of false spoken) , take it
saavagebueno added the Implemented in VED waiting push to Main label 2025-11-20 05:18:32 -05:00
saavagebueno commented 2025-11-20 05:18:33 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Sep 26, 2025):

@Kaputtnique
If got someting cooking, please try in the Development Repo bash -c "$(curl -fsSL https://git.community-scripts.org/community-scripts/ProxmoxVED/raw/branch/main/ct/debian.sh)"

To add a description for a bridge create the file nano /usr/local/community-scripts/bridge_description and add the vaules there like

vmbr0:LAN 
vmbr1:WAN

Please try and give feedback. If it works it will eventually get moved to main with the next build.func feautre bump.

@michelroegl-brunner commented on GitHub (Sep 26, 2025): @Kaputtnique If got someting cooking, please try in the Development Repo `bash -c "$(curl -fsSL https://git.community-scripts.org/community-scripts/ProxmoxVED/raw/branch/main/ct/debian.sh)"` To add a description for a bridge create the file `nano /usr/local/community-scripts/bridge_description` and add the vaules there like ``` bash vmbr0:LAN vmbr1:WAN ``` Please try and give feedback. If it works it will eventually get moved to main with the next build.func feautre bump.
saavagebueno commented 2025-11-20 05:18:33 -05:00
Author
Owner
Copy Link

@Kaputtnique commented on GitHub (Sep 26, 2025):

its working as expected.

but it is possible to get the hashtag values of the /etc/network/interfaces instead of puttin it manual into a file? I mean, yea u have to do it 1 time. buit

i got something like this

awk ' /^iface vmbr[0-9]+/ {iface=$2} iface && /^#/ {print iface ":" substr($0,2); iface=""} ' /etc/network/interfaces

to avoid manual tipping hehe is it possible to use this ? i did not tested it with more then 2 bridges

@Kaputtnique commented on GitHub (Sep 26, 2025): its working as expected. but it is possible to get the hashtag values of the /etc/network/interfaces instead of puttin it manual into a file? I mean, yea u have to do it 1 time. buit i got something like this `awk ' /^iface vmbr[0-9]+/ {iface=$2} iface && /^#/ {print iface ":" substr($0,2); iface=""} ' /etc/network/interfaces` to avoid manual tipping hehe is it possible to use this ? i did not tested it with more then 2 bridges
saavagebueno commented 2025-11-20 05:18:33 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Sep 26, 2025):

Why not the internal?

Image

Then so:

root@devpc:~#  COMMENT=$(grep '^#' /etc/network/interfaces| sed 's/^#\s*//' | tail -n1)
root@devpc:~# echo "$COMMENT"
Im Bridge enp3s0
@MickLesk commented on GitHub (Sep 26, 2025): Why not the internal? <img width="573" height="278" alt="Image" src="https://github.com/user-attachments/assets/3f472386-3dc0-4269-92f3-b388b751fe06" /> Then so: ```shell root@devpc:~# COMMENT=$(grep '^#' /etc/network/interfaces| sed 's/^#\s*//' | tail -n1) root@devpc:~# echo "$COMMENT" Im Bridge enp3s0 ```
saavagebueno commented 2025-11-20 05:18:34 -05:00
Author
Owner
Copy Link

@Kaputtnique commented on GitHub (Sep 26, 2025):

Why not the internal?
Image

Then so:

root@devpc:# COMMENT=$(grep '^#' /etc/network/interfaces| sed 's/^#\s*//' | tail -n1)
root@devpc:# echo "$COMMENT"
Im Bridge enp3s0

if that is possible it would be better yea. my 1 line works too.. but "native" ( get from system, instead of using scripts over scripts to get it ) is better. :-D

i tested ur one line.. but it shows only one? maybe i use the command wrong..

@Kaputtnique commented on GitHub (Sep 26, 2025): > Why not the internal? > <img alt="Image" width="573" height="278" src="https://private-user-images.githubusercontent.com/47820557/494440306-3f472386-3dc0-4269-92f3-b388b751fe06.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTg4OTQ5NjcsIm5iZiI6MTc1ODg5NDY2NywicGF0aCI6Ii80NzgyMDU1Ny80OTQ0NDAzMDYtM2Y0NzIzODYtM2RjMC00MjY5LTkyZjMtYjM4OGI3NTFmZTA2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTI2VDEzNTEwN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNlM2ZmOGI4MTlkNGUxNDBkNWRkNmEwNTJhZjcxZmIxNDlhMDIzYjYxZDE5MmQ0OGM5MjIwOGI0YjlmYjk5ODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VdGjegZyySVMQUvfNc-WvpzS-Qv_odTpxEVJ5NxLkMI"> > > Then so: > > root@devpc:~# COMMENT=$(grep '^#' /etc/network/interfaces| sed 's/^#\s*//' | tail -n1) > root@devpc:~# echo "$COMMENT" > Im Bridge enp3s0 if that is possible it would be better yea. my 1 line works too.. but "native" ( get from system, instead of using scripts over scripts to get it ) is better. :-D i tested ur one line.. but it shows only one? maybe i use the command wrong..
saavagebueno commented 2025-11-20 05:18:34 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Sep 26, 2025):

Why not the internal?

Image

Then so:

root@devpc:~#  COMMENT=$(grep '^#' /etc/network/interfaces| sed 's/^#\s*//' | tail -n1)
root@devpc:~# echo "$COMMENT"
Im Bridge enp3s0

Ih my, i did not even know this would work, i will refactor it next week.

@michelroegl-brunner commented on GitHub (Sep 26, 2025): > Why not the internal? > > <img width="573" height="278" alt="Image" src="https://github.com/user-attachments/assets/3f472386-3dc0-4269-92f3-b388b751fe06" /> > > Then so: > ```shell > root@devpc:~# COMMENT=$(grep '^#' /etc/network/interfaces| sed 's/^#\s*//' | tail -n1) > root@devpc:~# echo "$COMMENT" > Im Bridge enp3s0 > ``` Ih my, i did not even know this would work, i will refactor it next week.
saavagebueno commented 2025-11-20 05:18:34 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Sep 29, 2025):

Refactored so it uses the built-in comment. Will be pushed to main on next feature bump.

@michelroegl-brunner commented on GitHub (Sep 29, 2025): Refactored so it uses the built-in comment. Will be pushed to main on next feature bump.
saavagebueno commented 2025-11-20 05:18:34 -05:00
Author
Owner
Copy Link

@Kaputtnique commented on GitHub (Sep 29, 2025):

very good @michelroegl-brunner works perfect. thanks for the fast support and implementation (i know in dev.. "soon" in main xD)

@Kaputtnique commented on GitHub (Sep 29, 2025): very good @michelroegl-brunner works perfect. thanks for the fast support and implementation (i know in dev.. "soon" in main xD)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label Implemented in VED waiting push to Main
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1854
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?