SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-03-31 06:34:17 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Updating Adventurelog lxc from 0.9.0 to 0.11.0 #1857

New Issue
Closed
opened 2025-11-20 05:18:39 -05:00 by saavagebueno · 4 comments
saavagebueno commented 2025-11-20 05:18:39 -05:00
Owner
Copy Link

Originally created by @ryelle07 on GitHub (Sep 6, 2025).

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

Adventurelog

📂 What was the exact command used to execute the script?

update

⚙️ What settings are you using?

  • Default Settings
  • Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 12

📈 Which Proxmox version are you on?

8.4.12/c2ea8261d32a5020 (running kernel: 6.8.12-14-pve)

📝 Provide a clear and concise description of the issue.

unable to update my adventurelog lxc

🔄 Steps to reproduce the issue.

update, silent & verbose mode.

❌ Paste the full error output (if available).

Error Log Verbose:

vite v5.4.19 building SSR bundle for production...
✓ 31 modules transformed.
x Build failed in 913ms
error during build:
[vite]: Rollup failed to resolve import "@mapbox/togeojson" from "/opt/adventurelog/frontend/src/routes/adventures/[id]/+page.svelte".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
build.rollupOptions.external
at viteWarn (file:///opt/adventurelog/frontend/node_modules/.pnpm/vite@5.4.19_@types+node@22.15.2/node_modules/vite/dist/node/chunks/dep-C6uTJdX2.js:65839:17)
at onwarn (file:///opt/adventurelog/frontend/node_modules/.pnpm/@sveltejs+kit@2.20.7_@sveltejs+vite-plugin-svelte@3.1.2_svelte@4.2.19_vite@5.4.19_@type_94d13bc8e4cac1ceb2b92024debfbe28/node_modules/@sveltejs/kit/src/exports/vite/index.js:692:9)
at onRollupWarning (file:///opt/adventurelog/frontend/node_modules/.pnpm/vite@5.4.19_@types+node@22.15.2/node_modules/vite/dist/node/chunks/dep-C6uTJdX2.js:65869:5)
at onwarn (file:///opt/adventurelog/frontend/node_modules/.pnpm/vite@5.4.19_@types+node@22.15.2/node_modules/vite/dist/node/chunks/dep-C6uTJdX2.js:65534:7)
at file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:20740:13
at Object.logger [as onLog] (file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:22605:9)
at ModuleLoader.handleInvalidResolvedId (file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:21352:26)
at file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:21310:26
 ELIFECYCLE  Command failed with exit code 1.

[ERROR] in line 63: exit code 0: while executing command $STD pnpm build

🖼️ Additional context (optional).

No response

Originally created by @ryelle07 on GitHub (Sep 6, 2025). ### ✅ Have you read and understood the above guidelines? yes ### 📜 What is the name of the script you are using? Adventurelog ### 📂 What was the exact command used to execute the script? update ### ⚙️ What settings are you using? - [x] Default Settings - [ ] Advanced Settings ### 🖥️ Which Linux distribution are you using? Debian 12 ### 📈 Which Proxmox version are you on? 8.4.12/c2ea8261d32a5020 (running kernel: 6.8.12-14-pve) ### 📝 Provide a clear and concise description of the issue. unable to update my adventurelog lxc ### 🔄 Steps to reproduce the issue. update, silent & verbose mode. ### ❌ Paste the full error output (if available). **Error Log Verbose:** vite v5.4.19 building SSR bundle for production... ✓ 31 modules transformed. x Build failed in 913ms error during build: [vite]: Rollup failed to resolve import "@mapbox/togeojson" from "/opt/adventurelog/frontend/src/routes/adventures/[id]/+page.svelte". This is most likely unintended because it can break your application at runtime. If you do want to externalize this module explicitly add it to `build.rollupOptions.external` at viteWarn (file:///opt/adventurelog/frontend/node_modules/.pnpm/vite@5.4.19_@types+node@22.15.2/node_modules/vite/dist/node/chunks/dep-C6uTJdX2.js:65839:17) at onwarn (file:///opt/adventurelog/frontend/node_modules/.pnpm/@sveltejs+kit@2.20.7_@sveltejs+vite-plugin-svelte@3.1.2_svelte@4.2.19_vite@5.4.19_@type_94d13bc8e4cac1ceb2b92024debfbe28/node_modules/@sveltejs/kit/src/exports/vite/index.js:692:9) at onRollupWarning (file:///opt/adventurelog/frontend/node_modules/.pnpm/vite@5.4.19_@types+node@22.15.2/node_modules/vite/dist/node/chunks/dep-C6uTJdX2.js:65869:5) at onwarn (file:///opt/adventurelog/frontend/node_modules/.pnpm/vite@5.4.19_@types+node@22.15.2/node_modules/vite/dist/node/chunks/dep-C6uTJdX2.js:65534:7) at file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:20740:13 at Object.logger [as onLog] (file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:22605:9) at ModuleLoader.handleInvalidResolvedId (file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:21352:26) at file:///opt/adventurelog/frontend/node_modules/.pnpm/rollup@4.40.2/node_modules/rollup/dist/es/shared/node-entry.js:21310:26  ELIFECYCLE  Command failed with exit code 1. [ERROR] in line 63: exit code 0: while executing command $STD pnpm build ### 🖼️ Additional context (optional). _No response_
saavagebueno added the not a script issueexternal labels 2025-11-20 05:18:39 -05:00
saavagebueno commented 2025-11-20 05:18:39 -05:00
Author
Owner
Copy Link

@michelroegl-brunner commented on GitHub (Sep 6, 2025):

this seams to be a pnpm dependencie issue. Please report at the adventurelog repo.

@michelroegl-brunner commented on GitHub (Sep 6, 2025): this seams to be a pnpm dependencie issue. Please report at the adventurelog repo.
saavagebueno commented 2025-11-20 05:18:39 -05:00
Author
Owner
Copy Link

@bchanudet commented on GitHub (Sep 7, 2025):

Hello @michelroegl-brunner,

Please have a look at the linked thread by @ryelle07. The bug is not a pnpm dependency issue, nor created on the adventurelog repo side, but is caused by the update script.

The update script calls the function fetch_and_deploy_gh_release, which download the new version, extract and copy the contents to `/opt/adventurelog/'.

But, unless I missed something, the target folder is not cleaned before copying the new version into it. So, if the new version deleted now-unnecessary files since the previous version, the old files are still in /opt/adventurelog.

This is what happens here: the build error reported by @ryelle07 is triggered by a file that is not present at all in the v0.11 version, but existed in the v0.10 version. But as the target folder was not cleaned in between the updates, the build command tries to build a file that isn't necessary anymore.

The fix might be "just" to change the previous command, that creates the backup, to use a mv command instead of a cp. This would make the /opt/adventurelog folder disappear, allowing the fetch_and_deploy_gh_release function to start with an empty target folder. I'd offer a PR but can't right now as I'm abroad.

@bchanudet commented on GitHub (Sep 7, 2025): Hello @michelroegl-brunner, Please have a look at the linked thread by @ryelle07. The bug is not a pnpm dependency issue, nor created on the adventurelog repo side, but is caused by the update script. The [update script](https://github.com/community-scripts/ProxmoxVE/blob/e77612c27eda6158c3921ab753238be66aaec4a7/ct/adventurelog.sh#L44) calls the function `fetch_and_deploy_gh_release`, which download the new version, extract and copy the contents to `/opt/adventurelog/'. But, unless I missed something, **the target folder is not cleaned before copying the new version into it**. So, if the new version deleted now-unnecessary files since the previous version, the old files are still in `/opt/adventurelog`. This is what happens here: the build error reported by @ryelle07 is triggered by a file that is not present at all in the v0.11 version, but existed in the v0.10 version. But as the target folder was not cleaned in between the updates, the build command tries to build a file that isn't necessary anymore. The fix might be "just" to change the [previous command](https://github.com/community-scripts/ProxmoxVE/blob/e77612c27eda6158c3921ab753238be66aaec4a7/ct/adventurelog.sh#L41), that creates the backup, to use a `mv` command instead of a `cp`. This would make the `/opt/adventurelog` folder disappear, allowing the `fetch_and_deploy_gh_release` function to start with an empty target folder. I'd offer a PR but can't right now as I'm abroad.
saavagebueno commented 2025-11-20 05:18:39 -05:00
Author
Owner
Copy Link

@Aloe-recite commented on GitHub (Sep 19, 2025):

hi, I solved this as discovered by @ryelle07 (thanks!).
Looks like something that the script might take into account?
Thanks!

cd /opt/adventurelog/backend/server
pip3 install -r requirements.txt
systemctl restart adventurelog-backend
@Aloe-recite commented on GitHub (Sep 19, 2025): hi, I solved this as discovered by @ryelle07 (thanks!). Looks like something that the script might take into account? Thanks! ``` cd /opt/adventurelog/backend/server pip3 install -r requirements.txt systemctl restart adventurelog-backend ```
saavagebueno commented 2025-11-20 05:18:40 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Sep 19, 2025):

We dont use pip python

@MickLesk commented on GitHub (Sep 19, 2025): We dont use pip python
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label external not a script issue
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#1857
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?