SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-22 05:52:48 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

Typo in description of PBS Post Install script - (says to run on Proxmox VE shell, but should be run in PBS shell) #2352

New Issue
Open
opened 2025-11-20 05:27:54 -05:00 by saavagebueno · 2 comments
saavagebueno commented 2025-11-20 05:27:54 -05:00
Owner
Copy Link

Originally created by @Ernie8900 on GitHub (Nov 18, 2025).

Originally assigned to: @BramSuurdje on GitHub.

Please verify that you have read and understood the guidelines.

yes

What type of issue is this?

Documentation

A clear and concise description of the issue.

there is a typo in description of "How to use" the PBS Post Install script. The script says to run it only on Proxmox VE shell, but I believe it should be state to be run in PBS shell only.

In the top blue boxes the description is correct (run on PBS shell) but in the "how to use section" there is a reference to Proxmox VE shell instead of to Proxmox Backup Server shell.

Which browser are you using?

Firefox

If relevant, including screenshots or a code block can be helpful in clarifying the issue.

Image

Please provide detailed steps to reproduce the issue.

go to page:
https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pbs-install&category=Proxmox+%26+Virtualization

Originally created by @Ernie8900 on GitHub (Nov 18, 2025). Originally assigned to: @BramSuurdje on GitHub. ### Please verify that you have read and understood the guidelines. yes ### What type of issue is this? Documentation ### A clear and concise description of the issue. there is a typo in description of "How to use" the PBS Post Install script. The script says to run it only on Proxmox VE shell, but I believe it should be state to be run in PBS shell only. In the top blue boxes the description is correct (run on PBS shell) but in the "how to use section" there is a reference to Proxmox VE shell instead of to Proxmox Backup Server shell. ### Which browser are you using? Firefox ### If relevant, including screenshots or a code block can be helpful in clarifying the issue. <img width="1082" height="775" alt="Image" src="https://github.com/user-attachments/assets/5b340414-891a-4af9-858b-8700c7c77ec8" /> ### Please provide detailed steps to reproduce the issue. go to page: https://community-scripts.github.io/ProxmoxVE/scripts?id=post-pbs-install&category=Proxmox+%26+Virtualization
saavagebueno added the website label 2025-11-20 05:27:54 -05:00
saavagebueno commented 2025-11-20 05:27:55 -05:00
Author
Owner
Copy Link

@MickLesk commented on GitHub (Nov 18, 2025):

its an static text. Its overall. @BramSuurdje do you see a need for any action?

Above it marked correctly as hint:

Image
@MickLesk commented on GitHub (Nov 18, 2025): its an static text. Its overall. @BramSuurdje do you see a need for any action? Above it marked correctly as hint: <img width="571" height="98" alt="Image" src="https://github.com/user-attachments/assets/bb41941d-26c3-4ec5-a7be-b125e7073aff" />
saavagebueno commented 2025-11-20 05:27:55 -05:00
Author
Owner
Copy Link

@BramSuurdje commented on GitHub (Nov 18, 2025):

It would be possible to change this if we, for example, added the required execution environment to every JSON file. However, I’m not sure it would be worth the time, especially for this example. If you have a script that is a Proxmox Backup Server post-install, you can safely assume it needs to be executed in the Proxmox Backup Server terminal.

That said, this has been a recurring topic, with more people getting confused. Adding this information to every JSON file (for example, as an enum) would provide more flexibility.

@BramSuurdje commented on GitHub (Nov 18, 2025): It would be possible to change this if we, for example, added the required execution environment to every JSON file. However, I’m not sure it would be worth the time, especially for this example. If you have a script that is a Proxmox Backup Server post-install, you can safely assume it needs to be executed in the Proxmox Backup Server terminal. That said, this has been a recurring topic, with more people getting confused. Adding this information to every JSON file (for example, as an enum) would provide more flexibility.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label website
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?