SVI/ProxmoxVE
1
0
Fork 0
mirror of https://github.com/community-scripts/ProxmoxVE.git synced 2026-07-28 16:52:43 -04:00
Code Issues 2.6k Packages Projects Releases 10 Wiki Activity

[PR #103] [CLOSED] For Discussion: Rename nexcloudpi.sh script (breaking change) #2393

New Issue
Closed
opened 2025-11-20 05:29:37 -05:00 by saavagebueno · 0 comments
saavagebueno commented 2025-11-20 05:29:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/community-scripts/ProxmoxVE/pull/103
Author: @newzealandpaul
Created: 11/6/2024
Status: ❌ Closed

Base: main ← Head: newzealandpaul-nc1

📝 Commits (1)

  • 6fdfe26 Rename nextcloud script so it shares the same name as the alpine script and also with the title on the website

📊 Changes

1 file changed (+0 additions, -0 deletions)

View changed files

📝 ct/nextcloud.sh (+0 -0)

📄 Description

Description

On the current and tteck's website, the Next Cloud script is refeared to as "Nextcloud LXC" in the title but "NextCloudPi" in the description.

The filenames of the scripts are also inconsistant:

nextcloudpi.sh (note the "pi")
alpine-nextcloud.sh (no "pi")

When doing automatic manipulation of JSON, and validation, this requires a special case because the script names don't match the usual format. This could cause issues in the future.

Why NOT to merge

This is a breaking change. Users who have previously expected to run the nextcloudpi command, and don't check the website, will find it no longer exists.

BUT most users probably copy n paste from the website.

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)
  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Documentation update required (this change requires an update to the documentation)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/community-scripts/ProxmoxVE/pull/103 **Author:** [@newzealandpaul](https://github.com/newzealandpaul) **Created:** 11/6/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `newzealandpaul-nc1` --- ### 📝 Commits (1) - [`6fdfe26`](https://github.com/community-scripts/ProxmoxVE/commit/6fdfe26eead1621a9f1b06ed55d3382f060387e3) Rename nextcloud script so it shares the same name as the alpine script and also with the title on the website ### 📊 Changes **1 file changed** (+0 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `ct/nextcloud.sh` (+0 -0) </details> ### 📄 Description ## Description On the current and tteck's website, the Next Cloud script is refeared to as "Nextcloud LXC" in the title but "NextCloudPi" in the description. The filenames of the scripts are also inconsistant: nextcloud**pi**.sh (note the "pi") alpine-nextcloud.sh (no "pi") When doing automatic manipulation of JSON, and validation, this requires a special case because the script names don't match the usual format. This could cause issues in the future. ## Why NOT to merge This is a breaking change. Users who have previously expected to run the nextcloudpi command, and don't check the website, will find it no longer exists. BUT most users probably copy n paste from the website. ## Type of change Please check the relevant option(s): - [ ] Bug fix (non-breaking change that resolves an issue) - [ ] New feature (non-breaking change that adds functionality) - [x] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly) - [ ] New script (a fully functional and thoroughly tested script or set of scripts.) - [ ] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions) - [ ] Documentation update required (this change requires an update to the documentation) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
saavagebueno added the pull-request label 2025-11-20 05:29:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🛑 Failure to comply with the guidelines
breaking change
bug
bug
bugfix
deferred
delete script
dependencies
enhancement
external
feature
github
help wanted
Implemented in VED waiting push to Main
in project pipeline
invalid
investigation
json
maintenance
new script
new script
nice to have
not a script issue
not planned
organization
pull-request
Mirrored from GitHub Pull Request
 question
refactor
rename script
security
update script
website
wontdo
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
saavagebueno
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SVI/ProxmoxVE#2393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?